GNU bug report logs - #25604
Autoloads fake functions in foreign packages

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 25604 in the body.
You can then email your comments to 25604 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Tim Landscheidt <tim <at> tim-landscheidt.de>
To: submit <at> debbugs.gnu.org (The Gnus Bugfixing Girls + Boys)
Subject: Autoloads fake functions in foreign packages
Date: Wed, 01 Feb 2017 22:52:43 +0000

With Gnus v5.13/GNU Emacs 25.1.1 (x86_64-redhat-linux-gnu,
GTK+ Version 3.22.4) of 2016-12-15, after loading
gnus-art.el, C-h f w3 TAB completes to
w3m-toggle-inline-images even though I have not installed
the w3m package.  This is due to gnus-art.el's:

| (autoload 'w3m-toggle-inline-images "w3m")

AFAIUI, this should be rewritten as:

| (declare-function w3m-toggle-inline-images "w3m")

so that the compiler remains quiet, but the function does
not falsely appear to be existing.

There are a lot of these in Gnus (cf. "git grep
'^[^;]*(autoload' -- lisp/gnus
':(exclude)lisp/gnus/ChangeLog.*'") and Emacs overall, so a
larger clean-up might be useful.

Message #8 received at 25604 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Tim Landscheidt <tim <at> tim-landscheidt.de>
Cc: 25604 <at> debbugs.gnu.org
Subject: Re: bug#25604: Autoloads fake functions in foreign packages
Date: Thu, 12 Apr 2018 21:34:47 +0200

Tim Landscheidt <tim <at> tim-landscheidt.de> writes:

> With Gnus v5.13/GNU Emacs 25.1.1 (x86_64-redhat-linux-gnu,
> GTK+ Version 3.22.4) of 2016-12-15, after loading
> gnus-art.el, C-h f w3 TAB completes to
> w3m-toggle-inline-images even though I have not installed
> the w3m package.  This is due to gnus-art.el's:
>
> | (autoload 'w3m-toggle-inline-images "w3m")
>
> AFAIUI, this should be rewritten as:
>
> | (declare-function w3m-toggle-inline-images "w3m")
>
> so that the compiler remains quiet, but the function does
> not falsely appear to be existing.

Thanks; I've applied this to Emacs 27.1.

> There are a lot of these in Gnus (cf. "git grep
> '^[^;]*(autoload' -- lisp/gnus
> ':(exclude)lisp/gnus/ChangeLog.*'") and Emacs overall, so a
> larger clean-up might be useful.

Using autoload in these forms is mostly annoying when they refer to
packages not distributed with Emacs -- the other ones are mostly
harmless.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.