GNU bug report logs - #25536
problem in adding a prog to make in coreutils -- spread to multiple files

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: L A Walsh <coreutils <at> tlinx.org>
Subject: bug#25536: closed (Re: bug#25536: problem in adding a prog to
 make in coreutils -- spread to multiple files)
Date: Wed, 25 Jan 2017 22:40:03 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#25536: problem in adding a prog to make in coreutils -- spread to multiple files

which was filed against the coreutils package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 25536 <at> debbugs.gnu.org.

-- 
25536: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=25536
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Eric Blake <eblake <at> redhat.com>
To: L A Walsh <coreutils <at> tlinx.org>, 25536-done <at> debbugs.gnu.org
Subject: Re: bug#25536: problem in adding a prog to make in coreutils --
 spread to multiple files
Date: Wed, 25 Jan 2017 16:39:17 -0600

[Message part 3 (text/plain, inline)]

tag 25536 notabug
done

On 01/25/2017 04:09 PM, L A Walsh wrote:
> I was trying to compile a file in the 'src' dir of the coreutils,
> called 'retab.c' but I got all sorts of weird errors.  Trying
> to do a make clean and remaking it I now get it in a bunch of files:
> 
> ./lib/time.h:20:1: error: stray '@' in program
> @ PRAGMA_SYSTEM_HEADER @
> ^

> 
> Was something suppose to replace those?

Those are files inserted by gnulib, the @ markers get fixed up during
'make', provided that you didn't mess up the automake invocation.  So it
sounds like something you did prevented automake's normal rules from
properly generating those files.

> 
> 
> How does one add a file to be made?
> 
> I tried going through Makefile.in,

Wrong file. Coreutils uses automake, therefore your edits need to be
made to Makefile.am and/or the files that it includes (such as
src/local.mk).  Then you need to make sure you rerun automake to rebuild
Makefile.in, then configure (or config.status) to rebuild Makefile; if
you have all the right tools installed, then the rerun of automake and
config.status happens automatically from the existing Makefile.  But it
sounds like since you bypassed a step and messed up your tree, it may be
easiest to just rerun ./bootstrap to fix the incomplete job (bootstrap
runs automake under the hood as needed).

By the way, this isn't a bug in coreutils, so much as a build question,
so it might be better to ask similar questions directly to the
coreutils <at> gnu.org list (rather than bug-coreutils) so that we don't have
to close out a corresponding bug from the tracker.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

[signature.asc (application/pgp-signature, attachment)]

[Message part 5 (message/rfc822, inline)]

From: L A Walsh <coreutils <at> tlinx.org>
To: bug-coreutils <at> gnu.org
Subject: problem in adding a prog to make in coreutils -- spread to multiple
 files
Date: Wed, 25 Jan 2017 14:09:42 -0800

I was trying to compile a file in the 'src' dir of the coreutils,
called 'retab.c' but I got all sorts of weird errors.  Trying
to do a make clean and remaking it I now get it in a bunch of files:

./lib/time.h:20:1: error: stray '@' in program
@ PRAGMA_SYSTEM_HEADER @
^
./lib/time.h:20:24: error: stray '@' in program
@ PRAGMA_SYSTEM_HEADER @
                       ^
./lib/time.h:22:2: error: stray '@' in program
 @PRAGMA_COLUMNS @
 ^
./lib/time.h:20:3: error: unknown type name 'PRAGMA_SYSTEM_HEADER'
@ PRAGMA_SYSTEM_HEADER @
  ^
./lib/time.h:22:18: error: stray '@' in program
 @PRAGMA_COLUMNS @
                 ^
In file included from ./lib/time.h:33:0,
                from /usr/include/sys/types.h:132,
                from ./lib/sys/types.h:26,
                from lib/acl.h:24,
                from lib/copy-acl.c:22:
/usr/include/time.h:59:1: error: expected '=', ',', ';', 'asm' or 
'__attribute__' before 'typedef'
typedef __clock_t clock_t;
--------

Indeed, when I look at the .h files they have the '@' signs in them.

Was something suppose to replace those?


How does one add a file to be made?

I tried going through Makefile.in, but it seems like to add
1 file, there are about 15-20 (likely more, as I'm guessing I missed
some) places where one has to add the file.

That can't be the right way to add a file?

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.