GNU bug report logs - #25536
problem in adding a prog to make in coreutils -- spread to multiple files

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 25536 in the body.
You can then email your comments to 25536 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: L A Walsh <coreutils <at> tlinx.org>
To: bug-coreutils <at> gnu.org
Subject: problem in adding a prog to make in coreutils -- spread to multiple
 files
Date: Wed, 25 Jan 2017 14:09:42 -0800

I was trying to compile a file in the 'src' dir of the coreutils,
called 'retab.c' but I got all sorts of weird errors.  Trying
to do a make clean and remaking it I now get it in a bunch of files:

./lib/time.h:20:1: error: stray '@' in program
@ PRAGMA_SYSTEM_HEADER @
^
./lib/time.h:20:24: error: stray '@' in program
@ PRAGMA_SYSTEM_HEADER @
                       ^
./lib/time.h:22:2: error: stray '@' in program
 @PRAGMA_COLUMNS @
 ^
./lib/time.h:20:3: error: unknown type name 'PRAGMA_SYSTEM_HEADER'
@ PRAGMA_SYSTEM_HEADER @
  ^
./lib/time.h:22:18: error: stray '@' in program
 @PRAGMA_COLUMNS @
                 ^
In file included from ./lib/time.h:33:0,
                from /usr/include/sys/types.h:132,
                from ./lib/sys/types.h:26,
                from lib/acl.h:24,
                from lib/copy-acl.c:22:
/usr/include/time.h:59:1: error: expected '=', ',', ';', 'asm' or 
'__attribute__' before 'typedef'
typedef __clock_t clock_t;
--------

Indeed, when I look at the .h files they have the '@' signs in them.

Was something suppose to replace those?


How does one add a file to be made?

I tried going through Makefile.in, but it seems like to add
1 file, there are about 15-20 (likely more, as I'm guessing I missed
some) places where one has to add the file.

That can't be the right way to add a file?

Message #12 received at 25536-done <at> debbugs.gnu.org (full text, mbox):

From: Eric Blake <eblake <at> redhat.com>
To: L A Walsh <coreutils <at> tlinx.org>, 25536-done <at> debbugs.gnu.org
Subject: Re: bug#25536: problem in adding a prog to make in coreutils --
 spread to multiple files
Date: Wed, 25 Jan 2017 16:39:17 -0600

[Message part 1 (text/plain, inline)]

tag 25536 notabug
done

On 01/25/2017 04:09 PM, L A Walsh wrote:
> I was trying to compile a file in the 'src' dir of the coreutils,
> called 'retab.c' but I got all sorts of weird errors.  Trying
> to do a make clean and remaking it I now get it in a bunch of files:
> 
> ./lib/time.h:20:1: error: stray '@' in program
> @ PRAGMA_SYSTEM_HEADER @
> ^

> 
> Was something suppose to replace those?

Those are files inserted by gnulib, the @ markers get fixed up during
'make', provided that you didn't mess up the automake invocation.  So it
sounds like something you did prevented automake's normal rules from
properly generating those files.

> 
> 
> How does one add a file to be made?
> 
> I tried going through Makefile.in,

Wrong file. Coreutils uses automake, therefore your edits need to be
made to Makefile.am and/or the files that it includes (such as
src/local.mk).  Then you need to make sure you rerun automake to rebuild
Makefile.in, then configure (or config.status) to rebuild Makefile; if
you have all the right tools installed, then the rerun of automake and
config.status happens automatically from the existing Makefile.  But it
sounds like since you bypassed a step and messed up your tree, it may be
easiest to just rerun ./bootstrap to fix the incomplete job (bootstrap
runs automake under the hood as needed).

By the way, this isn't a bug in coreutils, so much as a build question,
so it might be better to ask similar questions directly to the
coreutils <at> gnu.org list (rather than bug-coreutils) so that we don't have
to close out a corresponding bug from the tracker.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

[signature.asc (application/pgp-signature, attachment)]

Message #15 received at 25536-done <at> debbugs.gnu.org (full text, mbox):

From: L A Walsh <coreutils <at> tlinx.org>
To: Eric Blake <eblake <at> redhat.com>
Cc: 25536-done <at> debbugs.gnu.org
Subject: Re: bug#25536: problem in adding a prog to make in coreutils -- spread
 to multiple files
Date: Wed, 25 Jan 2017 15:24:47 -0800

Eric Blake wrote:
> But it
> sounds like since you bypassed a step and messed up your tree, it may be
> easiest to just rerun ./bootstrap to fix the incomplete job (bootstrap
> runs automake under the hood as needed).
> 
> By the way, this isn't a bug in coreutils, so much as a build question,
> so it might be better to ask similar questions directly to the
> coreutils <at> gnu.org list (rather than bug-coreutils) so that we don't have
> to close out a corresponding bug from the tracker.
----
Sent this to coreutils, but it didn't 'echo' back...(in > 15 minutes)

Is it working correctly?

I just subscribed to it, so I'm pretty sure I have the right
address and such...

the bug-coreutils note got ack'ed back in 2 minutes,
w/your reply coming ~30 minutes later.



-------- Original Message --------
Subject: 	problem in ./bootstrap
Date: 	Wed, 25 Jan 2017 15:08:55 -0800
To: 	Coreutils <coreutils <at> gnu.org>


Tried doing a re-bootstrap, but am getting several odd messages:

yesno
  yesno-tests
  yield
Notice from module error:
If you are using GNU gettext version 0.16.1 or older, add the 
following options
to XGETTEXT_OPTIONS in your po/Makevars:
  --flag=error:3:c-format --flag=error_at_line:5:c-format
Notice from module localcharset:
If your package's tests make use of the locale_charset() function 
directly or
indirectly, you may need to define the CHARSETALIASDIR environment 
variable,
so that "make check" works before "make install". In Makefile.am syntax:
TESTS_ENVIRONMENT += @LOCALCHARSET_TESTS_ENVIRONMENT@
Notice from module propername:
If you are using GNU gettext version 0.16.1 or older, add the 
following options
to XGETTEXT_OPTIONS in your po/Makevars:
  --keyword='proper_name:1,"This is a proper name. See the gettext 
manual, section Names."'
  --keyword='proper_name_utf8:1,"This is a proper name. See the 
gettext manual, section Names."'
Notice from module strpbrk:
This module is obsolete.
Notice from module vasprintf:
If you are using GNU gettext version 0.16.1 or older, add the 
following options
to XGETTEXT_OPTIONS in your po/Makevars:
  --flag=asprintf:2:c-format --flag=vasprintf:2:c-format
Notice from module verror:
If you are using GNU gettext version 0.16.1 or older, add the 
following options
to XGETTEXT_OPTIONS in your po/Makevars:
  --flag=verror:3:c-format --flag=verror_at_line:5:c-format
Notice from module xprintf:
If you are using GNU gettext version 0.16.1 or older, add the 
following options
to XGETTEXT_OPTIONS in your po/Makevars:
  --flag=xprintf:1:c-format --flag=xvprintf:1:c-format
  --flag=xfprintf:2:c-format --flag=xvfprintf:2:c-format
Notice from module xvasprintf:
If you are using GNU gettext version 0.16.1 or older, add the 
following options
to XGETTEXT_OPTIONS in your po/Makevars: --flag=xasprintf:1:c-format
File list:
build-aux/announce-gen
....
then at the end:
top/GNUmakefile
top/maint.mk
Updating file build-aux/config.rpath (backup in build-aux/config.rpath~)
4 out of 7 hunks FAILED -- saving rejects to file 
/tmp/gloqjyZR/tempname.c.rej
gnulib/gnulib-tool: *** patch file gl/lib/tempname.c.diff didn't apply 
cleanly
gnulib/gnulib-tool: *** Stop.
./bootstrap: gnulib-tool failed



As near as I can tell my gettext lib is v0.19.2...So the messages about
gettext 0.16.1 don't seem to apply. 

So not sure why it is failing?

thanks...

Message #18 received at 25536-done <at> debbugs.gnu.org (full text, mbox):

From: Eric Blake <eblake <at> redhat.com>
To: L A Walsh <coreutils <at> tlinx.org>
Cc: 25536-done <at> debbugs.gnu.org
Subject: Re: bug#25536: problem in adding a prog to make in coreutils --
 spread to multiple files
Date: Wed, 25 Jan 2017 17:27:19 -0600

[Message part 1 (text/plain, inline)]

On 01/25/2017 05:24 PM, L A Walsh wrote:
> 
> 
> Eric Blake wrote:
>> But it
>> sounds like since you bypassed a step and messed up your tree, it may be
>> easiest to just rerun ./bootstrap to fix the incomplete job (bootstrap
>> runs automake under the hood as needed).
>>
>> By the way, this isn't a bug in coreutils, so much as a build question,
>> so it might be better to ask similar questions directly to the
>> coreutils <at> gnu.org list (rather than bug-coreutils) so that we don't have
>> to close out a corresponding bug from the tracker.
> ----
> Sent this to coreutils, but it didn't 'echo' back...(in > 15 minutes)

That's because all first-time posts (whether subscribed or not) are
human-moderated.  It should show now.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

[signature.asc (application/pgp-signature, attachment)]

Message #21 received at 25536 <at> debbugs.gnu.org (full text, mbox):

From: Pádraig Brady <P <at> draigBrady.com>
To: 25536 <at> debbugs.gnu.org, coreutils <at> tlinx.org
Subject: Re: bug#25536: problem in adding a prog to make in coreutils --
 spread to multiple files
Date: Wed, 25 Jan 2017 23:28:23 +0000

On 25/01/17 22:39, Eric Blake wrote:
> tag 25536 notabug
> done
> 
> On 01/25/2017 04:09 PM, L A Walsh wrote:
>> I was trying to compile a file in the 'src' dir of the coreutils,
>> called 'retab.c' but I got all sorts of weird errors.

>> How does one add a file to be made?

You can see what needed changing to add the latest util (b2sum) here:
http://git.sv.gnu.org/gitweb/?p=coreutils.git;a=commitdiff;h=v8.25-105-gea94589

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.