GNU bug report logs - #25491
[patch #9228] Fixes pure mark in lang_wanted()

Previous Next

Package: idutils;

Reported by: Rafael Fontenelle <INVALID.NOREPLY <at> gnu.org>

Date: Fri, 20 Jan 2017 04:09:01 UTC

Severity: normal

Tags: patch

Full log


Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Rafael Fontenelle <INVALID.NOREPLY <at> gnu.org>
To: Rafael Fontenelle <rafaelff <at> gnome.org>, bug-idutils <at> gnu.org
Subject: [patch #9228] Fixes pure mark in lang_wanted()
Date: Fri, 20 Jan 2017 02:57:51 +0000 (UTC)
URL:
  <http://savannah.gnu.org/patch/?9228>

                 Summary: Fixes pure mark in lang_wanted()
                 Project: idutils
            Submitted by: rafaelff1
            Submitted on: Fri 20 Jan 2017 12:57:50 AM BRST
                Category: None
                Priority: 5 - Normal
                  Status: None
                 Privacy: Public
             Assigned to: None
        Originator Email: 
             Open/Closed: Open
         Discussion Lock: Any

    _______________________________________________________

Details:

In current GCC, build will fail with the following output:

  CC       walker.o
walker.c: In function 'lang_wanted':
walker.c:481:1: error: function might be candidate for attribute 'pure' if it
is known to return normally [-Werror=suggest-attribute=pure]
 lang_wanted (char const *lang_name)
 ^~~~~~~~~~~
cc1: all warnings being treated as errors
make[2]: *** [Makefile:1500: walker.o] Error 1


A solution is to add _GL_ATTRIBUTE_PURE to lang_wanted().

See attached patch. 



    _______________________________________________________

File Attachments:


-------------------------------------------------------
Date: Fri 20 Jan 2017 12:57:50 AM BRST  Name:
0001-maint-mark-lang_wanted-as-pure-to-please-GCC.patch  Size: 792B   By:
rafaelff1

<http://savannah.gnu.org/patch/download.php?file_id=39515>

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?9228>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/





This bug report was last modified 8 years and 149 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.