GNU bug report logs - #25492
floating point bug in 2.1.6

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 25492 in the body.
You can then email your comments to 25492 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Daniel Llorens <daniel.llorens <at> bluewin.ch>
To: bug-guile <at> gnu.org
Subject: floating point bug in 2.1.6
Date: Fri, 20 Jan 2017 10:40:19 +0100

See below.

The bug happens after commit 35a90592501ebde7e7ddbf2486ca9d315e317d09, ‘Add unboxed floating point comparison instructions.’


> ./meta/guile 
GNU Guile 2.1.6
Copyright (C) 1995-2016 Free Software Foundation, Inc.

Guile comes with ABSOLUTELY NO WARRANTY; for details type `,show w'.
This program is free software, and you are welcome to redistribute it
under certain conditions; type `,show c' for details.

Enter `,help' for help.
scheme@(guile-user)> (define x 0.0)
scheme@(guile-user)> (< x 1.0)
$1 = #t
scheme@(guile-user)> (< x 0.9)
$2 = #f

Message #8 received at 25492 <at> debbugs.gnu.org (full text, mbox):

From: Daniel Llorens <daniel.llorens <at> bluewin.ch>
To: 25492 <at> debbugs.gnu.org
Subject: [patch] floating point bug in 2.1.6
Date: Tue, 7 Feb 2017 12:26:53 +0100

It's a trivial patch. I don't know how to test it though.


From a0028723da283d39e5ab4e43f8934506a917498b Mon Sep 17 00:00:00 2001
From: Daniel Llorens <daniel.llorens <at> bluewin.ch>
Date: Tue, 7 Feb 2017 12:14:15 +0100
Subject: [PATCH] Fix bug #25492

* libguile/vm-engine.c (BR_F64_ARITHMETIC): Fix type.
---
 libguile/vm-engine.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libguile/vm-engine.c b/libguile/vm-engine.c
index 6848406..c9a9cec 100644
--- a/libguile/vm-engine.c
+++ b/libguile/vm-engine.c
@@ -361,7 +361,7 @@
 #define BR_F64_ARITHMETIC(crel)                                         \
   {                                                                     \
     scm_t_uint32 a, b;                                                  \
-    scm_t_uint64 x, y;                                                  \
+    double x, y;                                                        \
     UNPACK_24 (op, a);                                                  \
     UNPACK_24 (ip[1], b);                                               \
     x = SP_REF_F64 (a);                                                 \
-- 
2.10.1

Message #13 received at 25492-close <at> debbugs.gnu.org (full text, mbox):

From: Daniel Llorens <daniel.llorens <at> bluewin.ch>
To: 25492-close <at> debbugs.gnu.org
Subject: Re: bug#25492: closing
Date: Tue, 7 Feb 2017 12:45:45 +0100

Fixed in a0028723da283d39e5ab4e43f8934506a917498b.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.