GNU bug report logs - #25424
25.1; sql-mode, product mysql: sql-end-of-statement: Wrong type argument: stringp, nil

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 25424 in the body.
You can then email your comments to 25424 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Tijs Mallaerts <tijs.mallaerts <at> gmail.com>
To: "bug-gnu-emacs <at> gnu.org" <bug-gnu-emacs <at> gnu.org>
Subject: 25.1; sql-mode, product mysql: sql-end-of-statement: Wrong type
 argument: stringp, nil
Date: Wed, 11 Jan 2017 22:53:46 +0000

[Message part 1 (text/plain, inline)]

To reproduce:
- activate sql-mode
- call M-x sql-set-product
- select mysql
- write a part of a query, f.ex. select * from
- call M-x sql-end-of-statement

Error: sql-end-of-statement: Wrong type argument: stringp, nil

A missing :terminator sql-product-feature of mysql seems to be causing this
issue.

In GNU Emacs 25.1.4 (x86_64-unknown-linux-gnu)
 of 2016-09-24 built on kubuntu
Windowing system distributor 'The X.Org Foundation', version 11.0.11804000
System Description:    Ubuntu 16.04.1 LTS

Configured using:
 'configure --with-x-toolkit=no'

Configured features:
XPM JPEG TIFF GIF PNG SOUND DBUS GSETTINGS NOTIFY LIBXML2 FREETYPE XFT
ZLIB X11

Important settings:
  value of $LC_MONETARY: nl_BE.UTF-8
  value of $LC_NUMERIC: nl_BE.UTF-8
  value of $LC_TIME: nl_BE.UTF-8
  value of $LANG: en_US.UTF-8
  locale-coding-system: utf-8-unix

Major mode: SQL[MySQL]

[Message part 2 (text/html, inline)]

Message #10 received at 25424 <at> debbugs.gnu.org (full text, mbox):

From: Tijs Mallaerts <tijs.mallaerts <at> gmail.com>
To: 25424 <at> debbugs.gnu.org
Subject: [PATCH] Add mysql terminator to sql-product-alist
Date: Fri, 11 Jan 2019 23:12:01 +0100

[Message part 1 (text/plain, inline)]

From b97f29e248a57aea4fe92a606bdd67d2ab274c91 Mon Sep 17 00:00:00 2001
From: tijsmallaerts <tijs.mallaerts <at> gmail.com>
Date: Fri, 11 Jan 2019 23:05:36 +0100
Subject: [PATCH] Add mysql terminator to sql-product-alist

---
 lisp/progmodes/sql.el | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/lisp/progmodes/sql.el b/lisp/progmodes/sql.el
index ebde684109..42c4ab4e9f 100644
--- a/lisp/progmodes/sql.el
+++ b/lisp/progmodes/sql.el
@@ -459,7 +459,8 @@ file.  Since that is a plaintext file, this could be
dangerous."
      :prompt-length 6
      :prompt-cont-regexp "^    -> "
      :syntax-alist ((?# . "< b"))
-     :input-filter sql-remove-tabs-filter)
+     :input-filter sql-remove-tabs-filter
+     :terminator ";")

     (oracle
      :name "Oracle"
-- 
2.17.1

[Message part 2 (text/html, inline)]

Message #13 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Tijs Mallaerts <tijs.mallaerts <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: bug#25424: Add mysql terminator to sql-product-alist
Date: Wed, 6 Feb 2019 11:49:56 +0100

[Message part 1 (text/plain, inline)]

I've sent a patch to fix bug 25424 directly to the bug entry of the bug
tracker. Is that the correct place to send the patch to, or is it
recommended to email patches to this mailing list?

Thank you!
Tijs

[Message part 2 (text/html, inline)]

Message #16 received at 25424 <at> debbugs.gnu.org (full text, mbox):

From: Tijs Mallaerts <tijs.mallaerts <at> gmail.com>
To: 25424 <at> debbugs.gnu.org
Date: Fri, 22 Mar 2019 11:33:08 +0100

[Message part 1 (text/plain, inline)]

Could someone please verify if this patch is ok?

Thank you!
Tijs

[Message part 2 (text/html, inline)]

Message #19 received at 25424 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Tijs Mallaerts <tijs.mallaerts <at> gmail.com>,
 Michael R. Mauger <michael <at> mauger.com>
Cc: 25424 <at> debbugs.gnu.org
Subject: Re: bug#25424:
Date: Fri, 22 Mar 2019 15:15:35 +0200

> From: Tijs Mallaerts <tijs.mallaerts <at> gmail.com>
> Date: Fri, 22 Mar 2019 11:33:08 +0100
> 
> Could someone please verify if this patch is ok?

Sorry for the delay, CC'ing the relevant maintainer.

Michael, could you please look at the patch proposed in
https://debbugs.gnu.org/cgi/bugreport.cgi?bug=25424#10?

Thanks.

Message #22 received at 25424 <at> debbugs.gnu.org (full text, mbox):

From: Michael Mauger <mmauger <at> protonmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: Tijs Mallaerts <tijs.mallaerts <at> gmail.com>,
 "Michael R. Mauger" <michael <at> mauger.com>,
 "25424 <at> debbugs.gnu.org" <25424 <at> debbugs.gnu.org>
Subject: Re: bug#25424:
Date: Sat, 23 Mar 2019 01:43:49 +0000

I've reviewed the issue. The fix is more appropriate in `sql-end-of-statement'. I'll commit a change to implement this.

Thanks
--
MICHAEL <at> MAUGER.COM // FSF and EFF member // GNU Emacs sql.el maintainer

‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
On Friday, March 22, 2019 9:15 AM, Eli Zaretskii <eliz <at> gnu.org> wrote:

> > From: Tijs Mallaerts tijs.mallaerts <at> gmail.com
>
> > Date: Fri, 22 Mar 2019 11:33:08 +0100
> > Could someone please verify if this patch is ok?
>
> Sorry for the delay, CC'ing the relevant maintainer.
>
> Michael, could you please look at the patch proposed in
> https://debbugs.gnu.org/cgi/bugreport.cgi?bug=25424#10?
>
> Thanks.

Message #25 received at 25424 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Michael Mauger <mmauger <at> protonmail.com>
Cc: tijs.mallaerts <at> gmail.com, michael <at> mauger.com, 25424 <at> debbugs.gnu.org
Subject: Re: bug#25424:
Date: Sat, 23 Mar 2019 08:56:36 +0200

> Date: Sat, 23 Mar 2019 01:43:49 +0000
> From: Michael Mauger <mmauger <at> protonmail.com>
> Cc: Tijs Mallaerts <tijs.mallaerts <at> gmail.com>, "Michael R. Mauger" <michael <at> mauger.com>, "25424 <at> debbugs.gnu.org" <25424 <at> debbugs.gnu.org>
> 
> I've reviewed the issue. The fix is more appropriate in `sql-end-of-statement'. I'll commit a change to implement this.

Thanks.  I see you already made a change; should we now close this bug
report?

Message #28 received at 25424 <at> debbugs.gnu.org (full text, mbox):

From: Michael Mauger <mmauger <at> protonmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: "tijs.mallaerts <at> gmail.com" <tijs.mallaerts <at> gmail.com>,
 "michael <at> mauger.com" <michael <at> mauger.com>,
 "25424 <at> debbugs.gnu.org" <25424 <at> debbugs.gnu.org>
Subject: Re: bug#25424:
Date: Sun, 24 Mar 2019 19:31:11 +0000

On Saturday, March 23, 2019 2:56 AM, Eli Zaretskii <eliz <at> gnu.org> wrote:

> > Date: Sat, 23 Mar 2019 01:43:49 +0000
>
> > I've reviewed the issue. The fix is more appropriate in `sql-end-of-statement'. I'll commit a change to implement this.
>
> Thanks. I see you already made a change; should we now close this bug
> report?

Yes, it should now be all set. The bug can be closed.

Message #33 received at 25424-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Michael Mauger <mmauger <at> protonmail.com>
Cc: tijs.mallaerts <at> gmail.com, 25424-done <at> debbugs.gnu.org
Subject: Re: bug#25424:
Date: Sun, 24 Mar 2019 21:52:17 +0200

> Date: Sun, 24 Mar 2019 19:31:11 +0000
> From: Michael Mauger <mmauger <at> protonmail.com>
> Cc: "tijs.mallaerts <at> gmail.com" <tijs.mallaerts <at> gmail.com>, "michael <at> mauger.com" <michael <at> mauger.com>, "25424 <at> debbugs.gnu.org" <25424 <at> debbugs.gnu.org>
> 
> > Thanks. I see you already made a change; should we now close this bug
> > report?
> 
> Yes, it should now be all set. The bug can be closed.

Done, thanks.

Message #41 received at 25424-done <at> debbugs.gnu.org (full text, mbox):

From: Tijs Mallaerts <tijs.mallaerts <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 25424-done <at> debbugs.gnu.org, Michael Mauger <mmauger <at> protonmail.com>
Subject: Re: bug#25424:
Date: Mon, 25 Mar 2019 20:32:34 +0100

[Message part 1 (text/plain, inline)]

Thanks a lot!

Op zo 24 mrt. 2019 om 20:52 schreef Eli Zaretskii <eliz <at> gnu.org>:

> > Date: Sun, 24 Mar 2019 19:31:11 +0000
> > From: Michael Mauger <mmauger <at> protonmail.com>
> > Cc: "tijs.mallaerts <at> gmail.com" <tijs.mallaerts <at> gmail.com>, "
> michael <at> mauger.com" <michael <at> mauger.com>, "25424 <at> debbugs.gnu.org" <
> 25424 <at> debbugs.gnu.org>
> >
> > > Thanks. I see you already made a change; should we now close this bug
> > > report?
> >
> > Yes, it should now be all set. The bug can be closed.
>
> Done, thanks.
>

[Message part 2 (text/html, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.