GNU bug report logs - #25419
give better message when trying to go to forbidden areas

Previous Next

Full log

Message #16 received at 25419-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: npostavs <at> users.sourceforge.net
Cc: 25419-done <at> debbugs.gnu.org, jidanni <at> jidanni.org
Subject: Re: bug#25419: give better message when trying to go to forbidden
 areas
Date: Fri, 27 Jan 2017 10:59:08 +0200

> From: npostavs <at> users.sourceforge.net
> Cc: 積丹尼 Dan Jacobson <jidanni <at> jidanni.org>,
>   25419 <at> debbugs.gnu.org
> Date: Wed, 18 Jan 2017 22:28:17 -0500
> 
> Eli Zaretskii <eliz <at> gnu.org> writes:
> 
> >> From: 積丹尼 Dan Jacobson
> >> 	<jidanni <at> jidanni.org>
> >> Date: Wed, 11 Jan 2017 22:44:08 +0800
> >> 
> >> Do C-x C-f ~root
> >> You will see:
> >> Setting current directory: Success, /root/
> >
> > That's because /root has a file-name handler,
> > tramp-completion-file-name-handler, and although that handler turns
> > around and calls file-accessible-directory-p, the value of errno is
> > lost in transition:
> >
> >   /* If the file name has special constructs in it,
> >      call the corresponding file handler.  */
> >   handler = Ffind_file_name_handler (absname, Qfile_accessible_directory_p);
> >   if (!NILP (handler))
> >     {
> >       Lisp_Object r = call2 (handler, Qfile_accessible_directory_p, absname);
> >       errno = 0;
> >       return r;
> >     }
> >
> > Is there any better way than arbitrarily set errno to EACCES if the
> > handler returns something other than t?
> 
> AFAICT, not without changing the interface of
> file-accessible-directory-p file handler, no.

OK, thanks.  I made that change, and I'm marking this bug done.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.