GNU bug report logs - #25418
Proposal to quiet file size modified warning

Previous Next

To reply to this bug, email your comments to 25418 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jens Rantil <jens.rantil <at> tink.se>
To: bug-gzip <at> gnu.org
Subject: Proposal to quiet file size modified warning
Date: Wed, 11 Jan 2017 17:08:29 +0100

[Message part 1 (text/plain, inline)]

Hi,

I recently tried to `--quiet` the "gzip: stdin: file size changed while
zipping" warning, but it didn't work. Looking in the source code, I noticed
that the warning doesn't seem to be suppressed by `--quiet` command line
parameter. I'm hereby attaching an untested proposed patch to also quiet
that warning as the `gzip` man page states

    Suppress all warnings.

Let me know what you think.

Cheers,
Jens

-- 
Jens Rantil
Backend engineer
Tink AB

Email: jens.rantil <at> tink.se
Phone: +46 708 84 18 32
Web: www.tink.se

Facebook <https://www.facebook.com/#!/tink.se> Linkedin
<http://www.linkedin.com/company/2735919?trk=vsrp_companies_res_photo&trkInfo=VSRPsearchId%3A1057023381369207406670%2CVSRPtargetId%3A2735919%2CVSRPcmpt%3Aprimary>
 Twitter <https://twitter.com/tink>

[Message part 2 (text/html, inline)]

[file-size-changed-suppression.patch (application/octet-stream, attachment)]

Message #8 received at 25418 <at> debbugs.gnu.org (full text, mbox):

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: Jens Rantil <jens.rantil <at> tink.se>, 25418 <at> debbugs.gnu.org
Subject: Re: bug#25418: Proposal to quiet file size modified warning
Date: Wed, 11 Jan 2017 13:03:13 -0800

Ouch, why would one want to suppress that diagnostic? It sounds like a
serious error.

Message #11 received at 25418 <at> debbugs.gnu.org (full text, mbox):

From: "Chevreux, Bastien" <bastien.chevreux <at> dsm.com>
To: Paul Eggert <eggert <at> cs.ucla.edu>, Jens Rantil <jens.rantil <at> tink.se>,
 "25418 <at> debbugs.gnu.org" <25418 <at> debbugs.gnu.org>
Subject: RE: bug#25418: Proposal to quiet file size modified warning
Date: Wed, 11 Jan 2017 22:05:53 +0000

I see two different phrasings here: "warning" in the source message vs "error" in Paul's answer.

Quickly looking through the source:
- should it be treated like a warning? If yes, why does it not use warning() and/or set an exit code ("2")?
  And if it is a warning, then it should perhaps conform to the man-page which states that all warnings are
  suppressed with --quiet.
- should it be treated as an error? If yes, I do not see an exit code ("1") being set. Is that an oversight?

B.

--
DSM Nutritional Products Microbia Inc | Bioinformatics
60 Westview Street | Lexington, MA 02421 | United States
Phone +1 781 259 7613 | Fax +1 781 259 0615


-----Original Message-----
From: bug-gzip [mailto:bug-gzip-bounces+bastien.chevreux=dsm.com <at> gnu.org] On Behalf Of Paul Eggert
Sent: Wednesday, January 11, 2017 4:03 PM
To: Jens Rantil <jens.rantil <at> tink.se>; 25418 <at> debbugs.gnu.org
Subject: bug#25418: Proposal to quiet file size modified warning

--- This mail has been sent from an external source ---


Ouch, why would one want to suppress that diagnostic? It sounds like a serious error.




________________________________

DISCLAIMER:
This e-mail is for the intended recipient only.
If you have received it by mistake please let us know by reply and then delete it from your system; access, disclosure, copying, distribution or reliance on any of it by anyone else is prohibited.
If you as intended recipient have received this e-mail incorrectly, please notify the sender (via e-mail) immediately.

Message #14 received at 25418 <at> debbugs.gnu.org (full text, mbox):

From: Jason Leschnik <jason <at> leschnik.me>
To: "Chevreux, Bastien" <bastien.chevreux <at> dsm.com>
Cc: Paul Eggert <eggert <at> cs.ucla.edu>,
 "25418 <at> debbugs.gnu.org" <25418 <at> debbugs.gnu.org>,
 Jens Rantil <jens.rantil <at> tink.se>
Subject: Re: bug#25418: Proposal to quiet file size modified warning
Date: Thu, 12 Jan 2017 09:16:53 +1100

[Message part 1 (text/plain, inline)]

On 12 January 2017 at 09:05, Chevreux, Bastien <bastien.chevreux <at> dsm.com>
wrote:

> I see two different phrasings here: "warning" in the source message vs
> "error" in Paul's answer.
>

Good point. Does Gzip still produce a valid archive if the file changes
part way through execution? If the file is valid and does not result in a
fatal error then I'd say it's a warning. But then part of me agrees with
Paul that I'd still like to know about such an event.

[Message part 2 (text/html, inline)]

Message #17 received at 25418 <at> debbugs.gnu.org (full text, mbox):

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: Jason Leschnik <jason <at> leschnik.me>,
 "Chevreux, Bastien" <bastien.chevreux <at> dsm.com>
Cc: Jens Rantil <jens.rantil <at> tink.se>,
 "25418 <at> debbugs.gnu.org" <25418 <at> debbugs.gnu.org>
Subject: Re: bug#25418: Proposal to quiet file size modified warning
Date: Wed, 11 Jan 2017 15:38:24 -0800

On 01/11/2017 02:16 PM, Jason Leschnik wrote:
> Does Gzip still produce a valid archive if the file changes
> part way through execution?

It depends on what one means by "valid". Although gzip won't dump core,
it might generate output that does not correspond to any version of the
input. The problems when a similar situation occurs when uncompressing
are worse, I expect.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.