GNU bug report logs - #25374
align command can't use align-region-separate interactively

Previous Next

Full log

Message #10 received at control <at> debbugs.gnu.org (full text, mbox):

From: npostavs <at> users.sourceforge.net
To: control <at> debbugs.gnu.org
Subject: Re: bug#25374: 25.1.91; bug
Date: Fri, 06 Jan 2017 08:42:11 -0500

retitle 25374 align command can't use align-region-separate interactively
tags 25374 moreinfo
quit

Eli Zaretskii <eliz <at> gnu.org> writes:

>> From: John Wiegley <jwiegley <at> gmail.com>
>> Date: Sun, 28 Aug 2011 00:51:56 +0800 (5 years, 18 weeks, 6 days ago)
>> 
>> From: Le Wang <l26wang <at> gmail.com>
>> 
>> It doesn't look right to me that auto region selection is not
>> accessible interactively.  The interactive "r" form is quite broken,
>> so you may want to fix it in other interactive forms as well.  Unless
>> there is a good reason you left it this way?
>
> Sorry, I don't think I understand this part.  Please elaborate what is
> broken in the interactive "r" form.
>
>> -  (interactive "r")
>> +  (interactive (if (use-region-p)
>> +                   (list (region-beginning) (region-end))
>> +                 (list nil nil)))
>
> This is not an equivalent change: the previous code would use the
> region even if it was not active (i.e. transient-mark-mode is off),
> the new code will think there's no region in that case.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.