GNU bug report logs - #25373
25.1.91; emacs align.el patch for CSS alignment

Previous Next

Package: emacs;

Reported by: John Wiegley <jwiegley <at> gmail.com>

Date: Fri, 6 Jan 2017 07:25:02 UTC

Severity: normal

Tags: patch

Merged with 23238

Found in version 25.1.91

Done: Simen Heggestøyl <simenheg <at> gmail.com>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 25373 in the body.
You can then email your comments to 25373 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#25373; Package emacs. (Fri, 06 Jan 2017 07:25:02 GMT) Full text and rfc822 format available.
Acknowledgement sent to John Wiegley <jwiegley <at> gmail.com>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Fri, 06 Jan 2017 07:25:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: John Wiegley <jwiegley <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 25.1.91; emacs align.el patch for CSS alignment
Date: Thu, 05 Jan 2017 23:23:52 -0800 (PST)

From: Le Wang <l26wang <at> gmail.com>

The regexp for CSS currently fails for the following CSS:

div.indented{
 margin-left: 2.0em;
 background: #ccccff;
 border:     1px solid red;}

because of the dash in "margin-left"

Here is a patch

--- c:/emacs/emacs-23.3/lisp/align.el   2011-01-08 12:45:14.000000000 +0800
+++ c:/Users/Le/cygwin_home/tmp/align.el        2011-08-28
00:28:28.966461600 +0800
@@ -578,7 +578,7 @@
                    (eq '- current-prefix-arg)))))

    (css-declaration
-     (regexp . "^\\s-*\\w+:\\(\\s-*\\).*;")
+     (regexp . "^\\s-*\\(?:\\w\\|\\s_\\)+:\\(\\s-*\\).*;")
     (group . (1))
     (modes . '(css-mode html-mode))))
  "A list describing all of the available alignment rules.

-- 
John Wiegley                  GPG fingerprint = 4710 CF98 AF9B 327B B80F
http://newartisans.com                          60E1 46C4 BD1A 7AC1 4BA2
Added tag(s) patch. Request was from npostavs <at> users.sourceforge.net to control <at> debbugs.gnu.org. (Fri, 06 Jan 2017 13:42:02 GMT) Full text and rfc822 format available.
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#25373; Package emacs. (Fri, 06 Jan 2017 16:44:02 GMT) Full text and rfc822 format available.

Message #10 received at 25373 <at> debbugs.gnu.org (full text, mbox):

From: Simen Heggestøyl <simenheg <at> gmail.com>
To: John Wiegley <jwiegley <at> gmail.com>
Cc: Le Wang <l26wang <at> gmail.com>, 25373 <at> debbugs.gnu.org
Subject: Re: bug#25373: 25.1.91; emacs align.el patch for CSS alignment
Date: Fri, 06 Jan 2017 17:43:07 +0100

This was fixed for Emacs 26.1 by commit d6ea6453f3d1696b
(https://debbugs.gnu.org/cgi/bugreport.cgi?bug=23238).

-- Simen
Forcibly Merged 23238 25373. Request was from Glenn Morris <rgm <at> gnu.org> to control <at> debbugs.gnu.org. (Fri, 06 Jan 2017 18:42:01 GMT) Full text and rfc822 format available.
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Sat, 04 Feb 2017 12:24:03 GMT) Full text and rfc822 format available.
This bug report was last modified 8 years and 139 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.