GNU bug report logs - #25218
flyspell.el tidy-up: remove XEmacs support and fix a spelling mistake

Previous Next

Package: emacs;

Reported by: Reuben Thomas <rrt <at> sc3d.org>

Date: Sat, 17 Dec 2016 19:15:02 UTC

Severity: wishlist

Fixed in version 26.1

Done: Glenn Morris <rgm <at> gnu.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 25218 in the body.
You can then email your comments to 25218 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#25218; Package emacs. (Sat, 17 Dec 2016 19:15:02 GMT) Full text and rfc822 format available.
Acknowledgement sent to Reuben Thomas <rrt <at> sc3d.org>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Sat, 17 Dec 2016 19:15:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Reuben Thomas <rrt <at> sc3d.org>
To: bug-emacs <bug-emacs <at> gnu.org>
Subject: flyspell.el tidy-up: remove XEmacs support and fix a spelling mistake
Date: Sat, 17 Dec 2016 19:14:00 +0000

[Message part 1 (text/plain, inline)]
The attached patches remove XEmacs support from flyspell.el (flyspell.el
has been an integral part of GNU Emacs for some time, so our version does
not need to support XEmacs), and renames an internal defun whose name was
incorrectly spelt: flyspell-ajust-cursor-point (ajust → adjust).

-- 
http://rrt.sc3d.org

[Message part 2 (text/html, inline)]
[0004-Remove-XEmacs-support-from-flyspell.el.patch (text/x-patch, attachment)]
[0005-Fix-spelling-mistake-in-private-defun-name.patch (text/x-patch, attachment)]
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#25218; Package emacs. (Sat, 17 Dec 2016 19:28:02 GMT) Full text and rfc822 format available.

Message #8 received at 25218 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Reuben Thomas <rrt <at> sc3d.org>
Cc: 25218 <at> debbugs.gnu.org
Subject: Re: bug#25218: flyspell.el tidy-up: remove XEmacs support and fix a
 spelling mistake
Date: Sat, 17 Dec 2016 21:26:30 +0200

> From: Reuben Thomas <rrt <at> sc3d.org>
> Date: Sat, 17 Dec 2016 19:14:00 +0000
> 
> The attached patches remove XEmacs support from flyspell.el (flyspell.el has been an integral part of GNU
> Emacs for some time, so our version does not need to support XEmacs), and renames an internal defun
> whose name was incorrectly spelt: flyspell-ajust-cursor-point (ajust → adjust).

Thanks, this is OK.
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#25218; Package emacs. (Sat, 17 Dec 2016 21:10:01 GMT) Full text and rfc822 format available.

Message #11 received at 25218 <at> debbugs.gnu.org (full text, mbox):

From: Reuben Thomas <rrt <at> sc3d.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 25218 <at> debbugs.gnu.org
Subject: Re: bug#25218: flyspell.el tidy-up: remove XEmacs support and fix a
 spelling mistake
Date: Sat, 17 Dec 2016 21:09:27 +0000

[Message part 1 (text/plain, inline)]
On 17 December 2016 at 19:26, Eli Zaretskii <eliz <at> gnu.org> wrote:

> > From: Reuben Thomas <rrt <at> sc3d.org>
> > Date: Sat, 17 Dec 2016 19:14:00 +0000
> >
> > The attached patches remove XEmacs support from flyspell.el (flyspell.el
> has been an integral part of GNU
> > Emacs for some time, so our version does not need to support XEmacs),
> and renames an internal defun
> > whose name was incorrectly spelt: flyspell-ajust-cursor-point (ajust →
> adjust).
>
> Thanks, this is OK.
>

​Thanks for the rapid review. I've installed the changes.

-- 
http://rrt.sc3d.org

[Message part 2 (text/html, inline)]
bug marked as fixed in version 26.1, send any further explanations to 25218 <at> debbugs.gnu.org and Reuben Thomas <rrt <at> sc3d.org> Request was from Glenn Morris <rgm <at> gnu.org> to control <at> debbugs.gnu.org. (Mon, 19 Dec 2016 18:24:01 GMT) Full text and rfc822 format available.
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#25218; Package emacs. (Mon, 19 Dec 2016 18:46:02 GMT) Full text and rfc822 format available.

Message #16 received at 25218 <at> debbugs.gnu.org (full text, mbox):

From: Agustin Martin <agustin6martin <at> gmail.com>
To: Reuben Thomas <rrt <at> sc3d.org>
Cc: 25218 <at> debbugs.gnu.org
Subject: Re: bug#25218: flyspell.el tidy-up: remove XEmacs support and fix a
 spelling mistake
Date: Mon, 19 Dec 2016 19:45:02 +0100

[Message part 1 (text/plain, inline)]
2016-12-17 20:14 GMT+01:00 Reuben Thomas <rrt <at> sc3d.org>:

> The attached patches remove XEmacs support from flyspell.el (flyspell.el
> has been an integral part of GNU Emacs for some time, so our version does
> not need to support XEmacs), and renames an internal defun whose name was
> incorrectly spelt: flyspell-ajust-cursor-point (ajust → adjust).
>

Thanks for dealing with this,

For some time I tried to keep ispell.el and flyspell.el supporting XEmacs,
so I could use the same file with minimal patches in Debian. However, since
ispell.el and flyspell.el started using the cl- stuff this was no longer
possible (hopefully for good), so Debian Emacs uses now its own ispell.el
and flyspell.el and XEmacs old stuff still provided by dictionaries.common
Debian package.

So I agree that it is no longer meaningful to keep XEmacs stuff flying
around.

-- 
Agustin

[Message part 2 (text/html, inline)]
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Tue, 17 Jan 2017 12:24:03 GMT) Full text and rfc822 format available.
This bug report was last modified 8 years and 207 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.