GNU bug report logs - #25217
[PATCH] Enable sh-mode zshrc

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 25217 in the body.
You can then email your comments to 25217 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Michihito Shigemura <m_shigemura <at> shigemk2.com>
To: bug-gnu-emacs <at> gnu.org
Cc: Michihito Shigemura <m_shigemura <at> shigemk2.com>
Subject: [PATCH] Enable sh-mode zshrc
Date: Sat, 17 Dec 2016 18:06:25 +0900

* lisp/progmodes/sh-script.el (sh-mode):
Add zsh string-match
---
 lisp/progmodes/sh-script.el | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lisp/progmodes/sh-script.el b/lisp/progmodes/sh-script.el
index 5d362e4..ac5fb19 100644
--- a/lisp/progmodes/sh-script.el
+++ b/lisp/progmodes/sh-script.el
@@ -1683,6 +1683,7 @@ sh-mode
          ((string-match "[.]bash\\>"   buffer-file-name) "bash")
          ((string-match "[.]ksh\\>"    buffer-file-name) "ksh")
          ((string-match "[.]t?csh\\(rc\\)?\\>" buffer-file-name) "csh")
+         ((string-match "[.]zsh\\(rc\\)?\\>" buffer-file-name) "zsh")
 	 ((equal (file-name-nondirectory buffer-file-name) ".profile") "sh")
          (t sh-shell-file))
    nil nil)
-- 
2.9.3

Message #8 received at 25217 <at> debbugs.gnu.org (full text, mbox):

From: Alan Third <alan <at> idiocy.org>
To: Michihito Shigemura <m_shigemura <at> shigemk2.com>
Cc: 25217 <at> debbugs.gnu.org
Subject: Re: bug#25217: [PATCH] Enable sh-mode zshrc
Date: Mon, 19 Dec 2016 09:31:22 +0000

Michihito Shigemura <m_shigemura <at> shigemk2.com> writes:

> * lisp/progmodes/sh-script.el (sh-mode):
> Add zsh string-match
> ---
>  lisp/progmodes/sh-script.el | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/lisp/progmodes/sh-script.el b/lisp/progmodes/sh-script.el
> index 5d362e4..ac5fb19 100644
> --- a/lisp/progmodes/sh-script.el
> +++ b/lisp/progmodes/sh-script.el
> @@ -1683,6 +1683,7 @@ sh-mode
>           ((string-match "[.]bash\\>"   buffer-file-name) "bash")
>           ((string-match "[.]ksh\\>"    buffer-file-name) "ksh")
>           ((string-match "[.]t?csh\\(rc\\)?\\>" buffer-file-name) "csh")
> +         ((string-match "[.]zsh\\(rc\\)?\\>" buffer-file-name) "zsh")
>  	 ((equal (file-name-nondirectory buffer-file-name) ".profile") "sh")
>           (t sh-shell-file))
>     nil nil)

Hi, looks good.

Is it worth adding support for .zshenv as well?
-- 
Alan Third

Message #11 received at 25217 <at> debbugs.gnu.org (full text, mbox):

From: Michihito Shigemura <m_shigemura <at> shigemk2.com>
To: 25217 <at> debbugs.gnu.org
Date: Mon, 19 Dec 2016 22:15:56 +0900

Thank you for your replying.

I can add support for .zshenv. But how can I send the improved patch?

Do I send it to 25217 at debbugs.gnu.org?

Message #14 received at 25217 <at> debbugs.gnu.org (full text, mbox):

From: Alan Third <alan <at> idiocy.org>
To: Michihito Shigemura <m_shigemura <at> shigemk2.com>
Cc: 25217 <at> debbugs.gnu.org
Subject: Re: bug#25217: (no subject)
Date: Mon, 19 Dec 2016 13:22:15 +0000

On Mon, Dec 19, 2016 at 10:15:56PM +0900, Michihito Shigemura wrote:
> Thank you for your replying.
> 
> I can add support for .zshenv. But how can I send the improved patch?
> 
> Do I send it to 25217 at debbugs.gnu.org?

Yes, thanks.
-- 
Alan Third

Message #17 received at 25217 <at> debbugs.gnu.org (full text, mbox):

From: Michihito Shigemura <m_shigemura <at> shigemk2.com>
To: 25217 <at> debbugs.gnu.org
Cc: Michihito Shigemura <m_shigemura <at> shigemk2.com>
Subject: [PATCH] Enable sh-mode zshrc
Date: Tue, 20 Dec 2016 21:12:35 +0900

* lisp/progmodes/sh-script.el (sh-mode):
Add zsh string-match
---
 lisp/progmodes/sh-script.el | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lisp/progmodes/sh-script.el b/lisp/progmodes/sh-script.el
index 5d362e4..a2c869d 100644
--- a/lisp/progmodes/sh-script.el
+++ b/lisp/progmodes/sh-script.el
@@ -1683,6 +1683,7 @@ sh-mode
          ((string-match "[.]bash\\>"   buffer-file-name) "bash")
          ((string-match "[.]ksh\\>"    buffer-file-name) "ksh")
          ((string-match "[.]t?csh\\(rc\\)?\\>" buffer-file-name) "csh")
+         ((string-match "[.]zsh\\(rc\\|env\\)?\\>" buffer-file-name) "zsh")
 	 ((equal (file-name-nondirectory buffer-file-name) ".profile") "sh")
          (t sh-shell-file))
    nil nil)
-- 
2.9.3

Message #20 received at 25217 <at> debbugs.gnu.org (full text, mbox):

From: Michihito Shigemura <m_shigemura <at> shigemk2.com>
To: 25217 <at> debbugs.gnu.org
Subject: Re: bug#25217
Date: Fri, 23 Dec 2016 13:07:04 +0900

I sent new patch!

Message #23 received at 25217 <at> debbugs.gnu.org (full text, mbox):

From: Alan Third <alan <at> idiocy.org>
To: Michihito Shigemura <m_shigemura <at> shigemk2.com>
Cc: 25217 <at> debbugs.gnu.org
Subject: Re: bug#25217:
Date: Sat, 24 Dec 2016 09:51:49 +0000

On Fri, Dec 23, 2016 at 01:07:04PM +0900, Michihito Shigemura wrote:
> I sent new patch!

Sorry for the slow response. It looks good to me. Have you contributed
to Emacs before?
-- 
Alan Third

Message #26 received at 25217 <at> debbugs.gnu.org (full text, mbox):

From: Michihito Shigemura <m_shigemura <at> shigemk2.com>
To: 25217 <at> debbugs.gnu.org
Subject: Re: bug#25217:
Date: Sat, 24 Dec 2016 23:11:10 +0900

Sorry, but I haven't contributed to Emacs before.

Message #31 received at 25217-done <at> debbugs.gnu.org (full text, mbox):

From: Alan Third <alan <at> idiocy.org>
To: Michihito Shigemura <m_shigemura <at> shigemk2.com>
Cc: 25217-done <at> debbugs.gnu.org
Subject: Re: bug#25217:
Date: Sun, 25 Dec 2016 19:55:56 +0000

On Sat, Dec 24, 2016 at 11:11:10PM +0900, Michihito Shigemura wrote:
> Sorry, but I haven't contributed to Emacs before.

That’s good. If you had contributed before we might have had to get
you to assign copyright, but since it’s a small change we can let it
go. If you do decide to contribute again in the future you may have to
go through the process of assigning copyright.

I’ve pushed this change to the master branch.

Thank you!
-- 
Alan Third

Message #34 received at 25217 <at> debbugs.gnu.org (full text, mbox):

From: Michihito Shigemura <m_shigemura <at> shigemk2.com>
To: 25217 <at> debbugs.gnu.org
Date: Wed, 28 Dec 2016 00:01:40 +0900

[Message part 1 (text/plain, inline)]

> That’s good. If you had contributed before we might have had to get
you to assign copyright, but since it’s a small change we can let it
go. If you do decide to contribute again in the future you may have to
go through the process of assigning copyright.

Thank you for your pushing my change. I'll be careful.

[Message part 2 (text/html, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.