GNU bug report logs - #25122
24.5; function describe-variable hangs on large variables

Previous Next

Full log

Message #80 received at 25122 <at> debbugs.gnu.org (full text, mbox):

From: npostavs <at> users.sourceforge.net
To: Thierry Volpiatto <thierry.volpiatto <at> gmail.com>
Cc: 25122 <at> debbugs.gnu.org, Stefan Monnier <monnier <at> iro.umontreal.ca>,
 Boruch Baum <boruch_baum <at> gmx.com>
Subject: Re: bug#25122: 24.5;
 function describe-variable hangs on large variables
Date: Mon, 17 Apr 2017 23:53:30 -0400

[Message part 1 (text/plain, inline)]

npostavs <at> users.sourceforge.net writes:

>>> npostavs <at> users.sourceforge.net writes:
>>>
>>> Okay, I think I found the real fix now:
>
> Same issue with indent-region.  The gains are not so dramatic for
> typical lisp code that has normal size sexps, but C-x h C-M-\ on
> subr.el's text runs twice as fast for me with the new lisp-indent-region
> function.

Had some test failures due to some corner cases, should all be fixed
now.  I think this is the final patch set.  This also fixes
lisp-indent-region and lisp-indent-line to not indent string literal
contents.

I intend to close this bug as fixed after merging these, as this does
fix the performance bug.  I will probably pursue the alternate pretty
printer separately; it doesn't help performance (after the indent-sexp
performance is fixed), but gives prettier results in some cases.  The
threading idea may also be worth looking at, but can also be considered
separately, as this bug report is already long enough.

[v3-0001-Don-t-reparse-the-sexp-in-indent-sexp-Bug-25122.patch (text/plain, attachment)]

[v3-0002-lisp-emacs-lisp-lisp-mode.el-indent-sexp-Clean-up.patch (text/plain, attachment)]

[v3-0003-Remove-ignored-argument-from-lisp-indent-line.patch (text/plain, attachment)]

[v3-0004-Add-new-lisp-indent-region-that-doesn-t-reparse-t.patch (text/plain, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.