GNU bug report logs - #25067
Emacs pretest 25.1.90 - ipython completion

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 25067 in the body.
You can then email your comments to 25067 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Edward Flanigan <eflanigan00 <at> hotmail.com>
To: "bug-gnu-emacs <at> gnu.org" <bug-gnu-emacs <at> gnu.org>
Subject: Emacs pretest 25.1.90 - ipython completion
Date: Tue, 29 Nov 2016 20:42:55 +0000

[Message part 1 (text/plain, inline)]

The ipython shell no longer recognizes my company popup on import


Python 3.5.2 |Anaconda 4.2.0 (64-bit)| (default, Jul  2 2016, 17:53:06)

IPython 5.1.0 -- An enhanced Interactive Python.


import num    will trigger completions in Emacs 25.1.1 but not Emacs 25.1.90.1




Once I import a module everything works fine in both versions

import numpy as np

np.ara      # I get popup completion for both versions of Emacs.

[Message part 2 (text/html, inline)]

Message #8 received at 25067 <at> debbugs.gnu.org (full text, mbox):

From: Edward Flanigan <eflanigan00 <at> hotmail.com>
To: "25067 <at> debbugs.gnu.org" <25067 <at> debbugs.gnu.org>
Subject: Re: bug#25067: Acknowledgement (Emacs pretest 25.1.90 - ipython
 completion)
Date: Tue, 29 Nov 2016 21:12:59 +0000

[Message part 1 (text/plain, inline)]

I'm not sure if this is related but also in ipython.

I don't get tab completion when I try to use 'run'.


> run afile.py


afile.py is in the working directory and completes properly in emacs 25.1 but not 25.1.9.1

[Message part 2 (text/html, inline)]

Message #11 received at 25067 <at> debbugs.gnu.org (full text, mbox):

From: Noam Postavsky <npostavs <at> users.sourceforge.net>
To: Edward Flanigan <eflanigan00 <at> hotmail.com>
Cc: "25067 <at> debbugs.gnu.org" <25067 <at> debbugs.gnu.org>
Subject: Re: bug#25067: Acknowledgement (Emacs pretest 25.1.90 - ipython
 completion)
Date: Tue, 29 Nov 2016 18:02:40 -0500

On Tue, Nov 29, 2016 at 4:12 PM, Edward Flanigan
<eflanigan00 <at> hotmail.com> wrote:
> I'm not sure if this is related but also in ipython.
>
> I don't get tab completion when I try to use 'run'.
>
>
>> run afile.py
>
>
> afile.py is in the working directory and completes properly in emacs 25.1
> but not 25.1.9.1

This looks related to #24401.

Message #14 received at 25067 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Clément Pit--Claudel <clement.pit <at> gmail.com>,
 Noam Postavsky <npostavs <at> users.sourceforge.net>
Cc: eflanigan00 <at> hotmail.com, 25067 <at> debbugs.gnu.org
Subject: Re: bug#25067: Acknowledgement (Emacs pretest 25.1.90 - ipython
 completion)
Date: Sun, 18 Dec 2016 17:23:02 +0200

> From: Noam Postavsky <npostavs <at> users.sourceforge.net>
> Date: Tue, 29 Nov 2016 18:02:40 -0500
> Cc: "25067 <at> debbugs.gnu.org" <25067 <at> debbugs.gnu.org>
> 
> On Tue, Nov 29, 2016 at 4:12 PM, Edward Flanigan
> <eflanigan00 <at> hotmail.com> wrote:
> > I'm not sure if this is related but also in ipython.
> >
> > I don't get tab completion when I try to use 'run'.
> >
> >
> >> run afile.py
> >
> >
> > afile.py is in the working directory and completes properly in emacs 25.1
> > but not 25.1.9.1
> 
> This looks related to #24401.

Clément, could you please look into this?  I'd like to fix this for
Emacs 25.2.

Thanks.

Message #17 received at 25067 <at> debbugs.gnu.org (full text, mbox):

From: Clément Pit--Claudel <clement.pit <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>,
 Noam Postavsky <npostavs <at> users.sourceforge.net>
Cc: eflanigan00 <at> hotmail.com, 25067 <at> debbugs.gnu.org
Subject: Re: bug#25067: Acknowledgement (Emacs pretest 25.1.90 - ipython
 completion)
Date: Sun, 18 Dec 2016 11:16:50 -0500

[Message part 1 (text/plain, inline)]

On 2016-12-18 10:23, Eli Zaretskii wrote:
>> From: Noam Postavsky <npostavs <at> users.sourceforge.net>
>> Date: Tue, 29 Nov 2016 18:02:40 -0500
>> Cc: "25067 <at> debbugs.gnu.org" <25067 <at> debbugs.gnu.org>
>>
>> On Tue, Nov 29, 2016 at 4:12 PM, Edward Flanigan
>> <eflanigan00 <at> hotmail.com> wrote:
>>> I'm not sure if this is related but also in ipython.
>>>
>>> I don't get tab completion when I try to use 'run'.
> 
> Clément, could you please look into this?  I'd like to fix this for
> Emacs 25.2.

Sure.

Edward, can you clarify which settings you're using? A recipe starting from emacs -Q would be ideal.
(IPython doesn't seem to work at all for me in Emacs; it was broken by 227e996946d4629fa8f6d665564a37668290c87f)

Cheers,
Clément.

[signature.asc (application/pgp-signature, attachment)]

Message #20 received at 25067 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Clément Pit--Claudel <clement.pit <at> gmail.com>
Cc: 25067 <at> debbugs.gnu.org, eflanigan00 <at> hotmail.com,
 npostavs <at> users.sourceforge.net
Subject: Re: bug#25067: Acknowledgement (Emacs pretest 25.1.90 - ipython
 completion)
Date: Sun, 18 Dec 2016 19:01:42 +0200

> Cc: eflanigan00 <at> hotmail.com, 25067 <at> debbugs.gnu.org
> From: Clément Pit--Claudel <clement.pit <at> gmail.com>
> Date: Sun, 18 Dec 2016 11:16:50 -0500
> 
> > Clément, could you please look into this?  I'd like to fix this for
> > Emacs 25.2.
> 
> Sure.

Thanks.

> (IPython doesn't seem to work at all for me in Emacs; it was broken by 227e996946d4629fa8f6d665564a37668290c87f)

Is there a bug report about that?

Message #23 received at 25067 <at> debbugs.gnu.org (full text, mbox):

From: Clément Pit--Claudel <clement.pit <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 25067 <at> debbugs.gnu.org, eflanigan00 <at> hotmail.com,
 npostavs <at> users.sourceforge.net
Subject: Re: bug#25067: Acknowledgement (Emacs pretest 25.1.90 - ipython
 completion)
Date: Sun, 18 Dec 2016 12:29:51 -0500

[Message part 1 (text/plain, inline)]

On 2016-12-18 12:01, Eli Zaretskii wrote:
>> (IPython doesn't seem to work at all for me in Emacs; it was broken by 227e996946d4629fa8f6d665564a37668290c87f)
> 
> Is there a bug report about that?

I just created one (#25222).

Clément.

[signature.asc (application/pgp-signature, attachment)]

Message #26 received at 25067 <at> debbugs.gnu.org (full text, mbox):

From: Edward Flanigan <eflanigan00 <at> hotmail.com>
To: "25067 <at> debbugs.gnu.org" <25067 <at> debbugs.gnu.org>
Subject: #25067 Emacs pretest 25.1.91 - ipython completion
Date: Tue, 3 Jan 2017 17:27:55 +0000

[Message part 1 (text/plain, inline)]

Python 3.5.2 |Anaconda 4.2.0 (64-bit)| (default, Jul  2 2016, 17:53:06)
IPython 5.1.0 -- An enhanced Interactive Python.


Recipe is the following:


emacs -q


eval-region on this:


(setq
 python-shell-interpreter "ipython3"
 python-shell-interpreter-args "--simple-prompt --pprint")



Then open *Python* which will be ipython 5.1.0

The following don't work anymore in the pre-test


1.) import num [TAB]  shows possible completions in 25.1.1 but doesn't in the pretest

2.) run afile [TAB] shows possible completions for the files in the directory that match afile*

3.) cd adirec [TAB] shows possible completions

[Message part 2 (text/html, inline)]

Message #31 received at 25067 <at> debbugs.gnu.org (full text, mbox):

From: npostavs <at> users.sourceforge.net
To: Edward Flanigan <eflanigan00 <at> hotmail.com>
Cc: "25067 <at> debbugs.gnu.org" <25067 <at> debbugs.gnu.org>
Subject: Re: bug#25067: #25067 Emacs pretest 25.1.91 - ipython completion
Date: Fri, 03 Feb 2017 19:03:40 -0500

Edward Flanigan <eflanigan00 <at> hotmail.com> writes:

> Python 3.5.2 |Anaconda 4.2.0 (64-bit)| (default, Jul 2 2016, 17:53:06)
> IPython 5.1.0 -- An enhanced Interactive Python.
>
> Recipe is the following:
>
> emacs -q
>
> eval-region on this:
>
> (setq
> python-shell-interpreter "ipython3"
> python-shell-interpreter-args "--simple-prompt --pprint")
>
> Then open *Python* which will be ipython 5.1.0
>
> The following don't work anymore in the pre-test
>
> 1.) import num [TAB] shows possible completions in 25.1.1 but doesn't in the pretest
>
> 2.) run afile [TAB] shows possible completions for the files in the directory that match afile*
>
> 3.) cd adirec [TAB] shows possible completions 

The behaviour from 25.1 can be restored by doing

    (add-to-list 'python-shell-completion-native-disabled-interpreters
                 "ipython")

So it looks like the problem is the fix for #24401 which enables native
completion work for python 3.5, also enables it for ipython, but native
completion doesn't actually work for ipython.

Message #34 received at 25067 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: npostavs <at> users.sourceforge.net
Cc: eflanigan00 <at> hotmail.com, 25067 <at> debbugs.gnu.org
Subject: Re: bug#25067: #25067 Emacs pretest 25.1.91 - ipython completion
Date: Sat, 04 Feb 2017 10:56:26 +0200

> From: npostavs <at> users.sourceforge.net
> Date: Fri, 03 Feb 2017 19:03:40 -0500
> Cc: "25067 <at> debbugs.gnu.org" <25067 <at> debbugs.gnu.org>
> 
> The behaviour from 25.1 can be restored by doing
> 
>     (add-to-list 'python-shell-completion-native-disabled-interpreters
>                  "ipython")
> 
> So it looks like the problem is the fix for #24401 which enables native
> completion work for python 3.5, also enables it for ipython, but native
> completion doesn't actually work for ipython.

Is there any safe way to fix this for Emacs 25.2?

Thanks.

Message #37 received at 25067 <at> debbugs.gnu.org (full text, mbox):

From: npostavs <at> users.sourceforge.net
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: eflanigan00 <at> hotmail.com, 25067 <at> debbugs.gnu.org
Subject: Re: bug#25067: #25067 Emacs pretest 25.1.91 - ipython completion
Date: Sat, 04 Feb 2017 09:39:46 -0500

Eli Zaretskii <eliz <at> gnu.org> writes:

>> From: npostavs <at> users.sourceforge.net
>> Date: Fri, 03 Feb 2017 19:03:40 -0500
>> Cc: "25067 <at> debbugs.gnu.org" <25067 <at> debbugs.gnu.org>
>> 
>> The behaviour from 25.1 can be restored by doing
>> 
>>     (add-to-list 'python-shell-completion-native-disabled-interpreters
>>                  "ipython")
>> 
>> So it looks like the problem is the fix for #24401 which enables native
>> completion work for python 3.5, also enables it for ipython, but native
>> completion doesn't actually work for ipython.
>
> Is there any safe way to fix this for Emacs 25.2?

I think the patch below is safe.  Although I can't say that I understand
what "native completion" actually means.

--- i/lisp/progmodes/python.el
+++ w/lisp/progmodes/python.el
@@ -3255,8 +3255,10 @@ python-shell-completion-string-code
   "Completion string code must work for (i)pdb.")
 
 (defcustom python-shell-completion-native-disabled-interpreters
-  ;; PyPy's readline cannot handle some escape sequences yet.
-  (list "pypy")
+  ;; PyPy's readline cannot handle some escape sequences yet.  Native
+  ;; completion was found to be non-functional for IPython (see
+  ;; Bug#25067).
+  (list "pypy" "ipython")
   "List of disabled interpreters.
 When a match is found, native completion is disabled."
   :version "25.1"

Message #40 received at 25067 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: npostavs <at> users.sourceforge.net,
 Clément Pit--Claudel <clement.pitclaudel <at> live.com>
Cc: eflanigan00 <at> hotmail.com, 25067 <at> debbugs.gnu.org
Subject: Re: bug#25067: #25067 Emacs pretest 25.1.91 - ipython completion
Date: Sat, 04 Feb 2017 18:52:58 +0200

> From: npostavs <at> users.sourceforge.net
> Cc: 25067 <at> debbugs.gnu.org,  eflanigan00 <at> hotmail.com
> Date: Sat, 04 Feb 2017 09:39:46 -0500
> 
> Eli Zaretskii <eliz <at> gnu.org> writes:
> 
> >> From: npostavs <at> users.sourceforge.net
> >> Date: Fri, 03 Feb 2017 19:03:40 -0500
> >> Cc: "25067 <at> debbugs.gnu.org" <25067 <at> debbugs.gnu.org>
> >> 
> >> The behaviour from 25.1 can be restored by doing
> >> 
> >>     (add-to-list 'python-shell-completion-native-disabled-interpreters
> >>                  "ipython")
> >> 
> >> So it looks like the problem is the fix for #24401 which enables native
> >> completion work for python 3.5, also enables it for ipython, but native
> >> completion doesn't actually work for ipython.
> >
> > Is there any safe way to fix this for Emacs 25.2?
> 
> I think the patch below is safe.

I agree.  Clément, any objections?

Thanks.

Message #43 received at 25067 <at> debbugs.gnu.org (full text, mbox):

From: Clément Pit--Claudel <clement.pitclaudel <at> live.com>
To: Eli Zaretskii <eliz <at> gnu.org>, npostavs <at> users.sourceforge.net
Cc: eflanigan00 <at> hotmail.com, 25067 <at> debbugs.gnu.org
Subject: Re: bug#25067: #25067 Emacs pretest 25.1.91 - ipython completion
Date: Mon, 6 Feb 2017 20:51:46 -0500

[Message part 1 (text/plain, inline)]

On 2017-02-04 11:52, Eli Zaretskii wrote:
>> From: npostavs <at> users.sourceforge.net
>> Cc: 25067 <at> debbugs.gnu.org,  eflanigan00 <at> hotmail.com
>> Date: Sat, 04 Feb 2017 09:39:46 -0500
>>
>> Eli Zaretskii <eliz <at> gnu.org> writes:
>>
>>>> From: npostavs <at> users.sourceforge.net
>>>> Date: Fri, 03 Feb 2017 19:03:40 -0500
>>>> Cc: "25067 <at> debbugs.gnu.org" <25067 <at> debbugs.gnu.org>
>>>>
>>>> The behaviour from 25.1 can be restored by doing
>>>>
>>>>     (add-to-list 'python-shell-completion-native-disabled-interpreters
>>>>                  "ipython")
>>>>
>>>> So it looks like the problem is the fix for #24401 which enables native
>>>> completion work for python 3.5, also enables it for ipython, but native
>>>> completion doesn't actually work for ipython.
>>>
>>> Is there any safe way to fix this for Emacs 25.2?
>>
>> I think the patch below is safe.
> 
> I agree.  Clément, any objections?

None.  The patch looks great, thanks!

Clément.

[signature.asc (application/pgp-signature, attachment)]

Message #46 received at 25067 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Clément Pit--Claudel <clement.pitclaudel <at> live.com>
Cc: 25067 <at> debbugs.gnu.org, eflanigan00 <at> hotmail.com,
 npostavs <at> users.sourceforge.net
Subject: Re: bug#25067: #25067 Emacs pretest 25.1.91 - ipython completion
Date: Tue, 07 Feb 2017 17:35:04 +0200

> Cc: 25067 <at> debbugs.gnu.org, eflanigan00 <at> hotmail.com
> From: Clément Pit--Claudel <clement.pitclaudel <at> live.com>
> Date: Mon, 6 Feb 2017 20:51:46 -0500
> 
> >>>> The behaviour from 25.1 can be restored by doing
> >>>>
> >>>>     (add-to-list 'python-shell-completion-native-disabled-interpreters
> >>>>                  "ipython")
> >>>>
> >>>> So it looks like the problem is the fix for #24401 which enables native
> >>>> completion work for python 3.5, also enables it for ipython, but native
> >>>> completion doesn't actually work for ipython.
> >>>
> >>> Is there any safe way to fix this for Emacs 25.2?
> >>
> >> I think the patch below is safe.
> > 
> > I agree.  Clément, any objections?
> 
> None.  The patch looks great, thanks!

Thanks.  Let's get it into the emacs-25 branch, then.

Message #49 received at 25067 <at> debbugs.gnu.org (full text, mbox):

From: npostavs <at> users.sourceforge.net
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: Clément Pit--Claudel <clement.pitclaudel <at> live.com>,
 eflanigan00 <at> hotmail.com, 25067 <at> debbugs.gnu.org
Subject: Re: bug#25067: #25067 Emacs pretest 25.1.91 - ipython completion
Date: Tue, 07 Feb 2017 21:21:54 -0500

tags 25067 fixed
close 25067 25.2
quit

Eli Zaretskii <eliz <at> gnu.org> writes:

>> Cc: 25067 <at> debbugs.gnu.org, eflanigan00 <at> hotmail.com
>> From: Clément Pit--Claudel <clement.pitclaudel <at> live.com>
>> Date: Mon, 6 Feb 2017 20:51:46 -0500
>> 
>> >>>> The behaviour from 25.1 can be restored by doing
>> >>>>
>> >>>>     (add-to-list 'python-shell-completion-native-disabled-interpreters
>> >>>>                  "ipython")
>> >>>>
>> >>>> So it looks like the problem is the fix for #24401 which enables native
>> >>>> completion work for python 3.5, also enables it for ipython, but native
>> >>>> completion doesn't actually work for ipython.
>> >>>
>> >>> Is there any safe way to fix this for Emacs 25.2?
>> >>
>> >> I think the patch below is safe.
>> > 
>> > I agree.  Clément, any objections?
>> 
>> None.  The patch looks great, thanks!
>
> Thanks.  Let's get it into the emacs-25 branch, then.

Pushed [1: 0ba9932d14]

1: 2017-02-07 21:18:19 -0500 0ba9932d1446e91fcc96f1d3303fac5ca5029d71
  Disable native completion for ipython (Bug#25067)

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.