GNU bug report logs - #24983
[PATCH] * lisp/eshell/esh-mode.el: Fix typo

Previous Next

Package: emacs;

Reported by: Chunyang Xu <mail <at> xuchunyang.me>

Date: Tue, 22 Nov 2016 04:41:02 UTC

Severity: normal

Tags: patch

Done: Eli Zaretskii <eliz <at> gnu.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Chunyang Xu <mail <at> xuchunyang.me>
Subject: bug#24983: closed (Re: bug#24983: [PATCH] * lisp/eshell/esh-mode.el:
 Fix typo)
Date: Fri, 25 Nov 2016 09:22:02 +0000
[Message part 1 (text/plain, inline)]
Your bug report

#24983: [PATCH] * lisp/eshell/esh-mode.el: Fix typo

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 24983 <at> debbugs.gnu.org.

-- 
24983: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=24983
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: Eli Zaretskii <eliz <at> gnu.org>
To: Chunyang Xu <mail <at> xuchunyang.me>
Cc: 24983-done <at> debbugs.gnu.org
Subject: Re: bug#24983: [PATCH] * lisp/eshell/esh-mode.el: Fix typo
Date: Fri, 25 Nov 2016 11:21:28 +0200
> From: Chunyang Xu <mail <at> xuchunyang.me>
> Date: Tue, 22 Nov 2016 12:11:53 +0800
> Cc: Chunyang Xu <mail <at> xuchunyang.me>
> 
> ---
>  lisp/eshell/esh-mode.el | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lisp/eshell/esh-mode.el b/lisp/eshell/esh-mode.el
> index 104841d..e687fd2 100644
> --- a/lisp/eshell/esh-mode.el
> +++ b/lisp/eshell/esh-mode.el
> @@ -143,7 +143,7 @@ eshell-scroll-to-bottom-on-output
>    :type '(radio (const :tag "Do not scroll Eshell windows" nil)
>  		(const :tag "Scroll all windows showing the buffer" all)
>  		(const :tag "Scroll only the selected window" this)
> -		(const :tag "Scroll all windows other than selected" this))
> +		(const :tag "Scroll all windows other than selected" others))
>    :group 'eshell-mode)

Thanks, pushed to the emacs-25 branch.

in the future, please accompany your changes with a ChangeLog-style
commit log entry, as described in CONTRIBUTE.

[Message part 3 (message/rfc822, inline)]
From: Chunyang Xu <mail <at> xuchunyang.me>
To: bug-gnu-emacs <at> gnu.org
Cc: Chunyang Xu <mail <at> xuchunyang.me>
Subject: [PATCH] * lisp/eshell/esh-mode.el: Fix typo
Date: Tue, 22 Nov 2016 12:11:53 +0800
---
 lisp/eshell/esh-mode.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/eshell/esh-mode.el b/lisp/eshell/esh-mode.el
index 104841d..e687fd2 100644
--- a/lisp/eshell/esh-mode.el
+++ b/lisp/eshell/esh-mode.el
@@ -143,7 +143,7 @@ eshell-scroll-to-bottom-on-output
   :type '(radio (const :tag "Do not scroll Eshell windows" nil)
 		(const :tag "Scroll all windows showing the buffer" all)
 		(const :tag "Scroll only the selected window" this)
-		(const :tag "Scroll all windows other than selected" this))
+		(const :tag "Scroll all windows other than selected" others))
   :group 'eshell-mode)
 
 (defcustom eshell-scroll-show-maximum-output t
-- 
2.7.4






This bug report was last modified 8 years and 239 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.