GNU bug report logs - #24983
[PATCH] * lisp/eshell/esh-mode.el: Fix typo

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 24983 in the body.
You can then email your comments to 24983 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Chunyang Xu <mail <at> xuchunyang.me>
To: bug-gnu-emacs <at> gnu.org
Cc: Chunyang Xu <mail <at> xuchunyang.me>
Subject: [PATCH] * lisp/eshell/esh-mode.el: Fix typo
Date: Tue, 22 Nov 2016 12:11:53 +0800

---
 lisp/eshell/esh-mode.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/eshell/esh-mode.el b/lisp/eshell/esh-mode.el
index 104841d..e687fd2 100644
--- a/lisp/eshell/esh-mode.el
+++ b/lisp/eshell/esh-mode.el
@@ -143,7 +143,7 @@ eshell-scroll-to-bottom-on-output
   :type '(radio (const :tag "Do not scroll Eshell windows" nil)
 		(const :tag "Scroll all windows showing the buffer" all)
 		(const :tag "Scroll only the selected window" this)
-		(const :tag "Scroll all windows other than selected" this))
+		(const :tag "Scroll all windows other than selected" others))
   :group 'eshell-mode)
 
 (defcustom eshell-scroll-show-maximum-output t
-- 
2.7.4

Message #10 received at 24983-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Chunyang Xu <mail <at> xuchunyang.me>
Cc: 24983-done <at> debbugs.gnu.org
Subject: Re: bug#24983: [PATCH] * lisp/eshell/esh-mode.el: Fix typo
Date: Fri, 25 Nov 2016 11:21:28 +0200

> From: Chunyang Xu <mail <at> xuchunyang.me>
> Date: Tue, 22 Nov 2016 12:11:53 +0800
> Cc: Chunyang Xu <mail <at> xuchunyang.me>
> 
> ---
>  lisp/eshell/esh-mode.el | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lisp/eshell/esh-mode.el b/lisp/eshell/esh-mode.el
> index 104841d..e687fd2 100644
> --- a/lisp/eshell/esh-mode.el
> +++ b/lisp/eshell/esh-mode.el
> @@ -143,7 +143,7 @@ eshell-scroll-to-bottom-on-output
>    :type '(radio (const :tag "Do not scroll Eshell windows" nil)
>  		(const :tag "Scroll all windows showing the buffer" all)
>  		(const :tag "Scroll only the selected window" this)
> -		(const :tag "Scroll all windows other than selected" this))
> +		(const :tag "Scroll all windows other than selected" others))
>    :group 'eshell-mode)

Thanks, pushed to the emacs-25 branch.

in the future, please accompany your changes with a ChangeLog-style
commit log entry, as described in CONTRIBUTE.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.