GNU bug report logs - #24820
Imenu in `python-mode' does not display function name for async def

Previous Next

Package: emacs;

Reported by: Dmitry Lazurkin <dilaz03 <at> gmail.com>

Date: Sat, 29 Oct 2016 20:02:02 UTC

Severity: minor

Tags: fixed, patch

Merged with 25734

Found in version 25

Fixed in version 26.1

Done: npostavs <at> users.sourceforge.net

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 24820 in the body.
You can then email your comments to 24820 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#24820; Package emacs. (Sat, 29 Oct 2016 20:02:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Dmitry Lazurkin <dilaz03 <at> gmail.com>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Sat, 29 Oct 2016 20:02:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Lazurkin <dilaz03 <at> gmail.com>
To: submit <at> debbugs.gnu.org
Subject: Imenu in `python-mode' does not display function name for async def
Date: Sat, 29 Oct 2016 17:34:53 +0300
Package: emacs
Version: 25
Tags: patch

From 9429522de96c27980f61bc107c4801216994d80b Mon Sep 17 00:00:00 2001
From: Dmitry Lazurkin <dilaz03 <at> gmail.com>
Date: Sat, 29 Oct 2016 16:51:40 +0300
Subject: [PATCH] Fix extracting async def type and name in python mode imenu

* lisp/progmodes/python.el (python-imenu--get-defun-type-name):
New function.
(python-imenu--build-tree): Use python-imenu--get-defun-type-name for
extract async or simple def type and name at current position.
* test/automated/python-tests.el (python-imenu-create-index-1,
python-imenu-create-flat-index-1): Add async def's.
---
 lisp/progmodes/python.el       | 16 +++++++++++-----
 test/automated/python-tests.el | 12 ++++++++++--
 2 files changed, 21 insertions(+), 7 deletions(-)

diff --git a/lisp/progmodes/python.el b/lisp/progmodes/python.el
index 49f7bcf..60bd4dc 100644
--- a/lisp/progmodes/python.el
+++ b/lisp/progmodes/python.el
@@ -4389,6 +4389,14 @@ python-imenu-format-parent-item-jump-label
       "*class definition*"
     "*function definition*"))
 
+(defun python-imenu--get-defun-type-name ()
+  "Return defun type and name at current position."
+  (when (looking-at python-nav-beginning-of-defun-regexp)
+    (let ((split (split-string (match-string-no-properties 0))))
+      (if (= (length split) 2)
+          split
+        (cdr split)))))
+
 (defun python-imenu--put-parent (type name pos tree)
   "Add the parent with TYPE, NAME and POS to TREE."
   (let ((label
@@ -4406,11 +4414,9 @@ python-imenu--build-tree
   (setq min-indent (or min-indent 0)
         prev-indent (or prev-indent python-indent-offset))
   (let* ((pos (python-nav-backward-defun))
-         (type)
-         (name (when (and pos (looking-at python-nav-beginning-of-defun-regexp))
-                 (let ((split (split-string (match-string-no-properties 0))))
-                   (setq type (car split))
-                   (cadr split))))
+         (defun-type-name (and pos (python-imenu--get-defun-type-name)))
+         (type (car defun-type-name))
+         (name (cadr defun-type-name))
          (label (when name
                   (funcall python-imenu-format-item-label-function type name)))
          (indent (current-indentation))
diff --git a/test/automated/python-tests.el b/test/automated/python-tests.el
index 54ed922..3cdabf8 100644
--- a/test/automated/python-tests.el
+++ b/test/automated/python-tests.el
@@ -3552,6 +3552,9 @@ python-tests-shell-interpreter
 
         def c(self):
             pass
+
+        async def d(self):
+            pass
 "
    (goto-char (point-max))
    (should (equal
@@ -3573,7 +3576,8 @@ python-tests-shell-interpreter
               (list
                "Frob (class)"
                (cons "*class definition*" (copy-marker 601))
-               (cons "c (def)" (copy-marker 626)))))
+               (cons "c (def)" (copy-marker 626))
+               (cons "d (def)" (copy-marker 665)))))
             (python-imenu-create-index)))))
 
 (ert-deftest python-imenu-create-index-2 ()
@@ -3695,6 +3699,9 @@ python-tests-shell-interpreter
 
         def c(self):
             pass
+
+        async def d(self):
+            pass
 "
    (goto-char (point-max))
    (should (equal
@@ -3707,7 +3714,8 @@ python-tests-shell-interpreter
                   (cons "Baz.a" (copy-marker 539))
                   (cons "Baz.b" (copy-marker 570))
                   (cons "Baz.Frob" (copy-marker 601))
-                  (cons "Baz.Frob.c" (copy-marker 626)))
+                  (cons "Baz.Frob.c" (copy-marker 626))
+                  (cons "Baz.Frob.d" (copy-marker 665)))
             (python-imenu-create-flat-index)))))
 
 (ert-deftest python-imenu-create-flat-index-2 ()
-- 
2.7.4






Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#24820; Package emacs. (Fri, 23 Dec 2016 17:34:02 GMT) Full text and rfc822 format available.

Message #8 received at 24820 <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Lazurkin <dilaz03 <at> gmail.com>
To: 24820 <at> debbugs.gnu.org
Subject: Any suggestions about patch?
Date: Fri, 23 Dec 2016 20:32:52 +0300
I have not quick navigation to async method without this patch. What i
should do for merging this patch?






Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#24820; Package emacs. (Mon, 26 Dec 2016 22:26:01 GMT) Full text and rfc822 format available.

Message #11 received at 24820 <at> debbugs.gnu.org (full text, mbox):

From: npostavs <at> users.sourceforge.net
To: Dmitry Lazurkin <dilaz03 <at> gmail.com>
Cc: 24820 <at> debbugs.gnu.org
Subject: Re: bug#24820: Any suggestions about patch?
Date: Mon, 26 Dec 2016 17:26:28 -0500
Dmitry Lazurkin <dilaz03 <at> gmail.com> writes:

> I have not quick navigation to async method without this patch. What i
> should do for merging this patch?

The patch looks good to me, except a minor formatting mistake in the
commit message.

  * test/automated/python-tests.el (python-imenu-create-index-1,
  python-imenu-create-flat-index-1): Add async def's.

should be

  * test/automated/python-tests.el (python-imenu-create-index-1):
  (python-imenu-create-flat-index-1): Add async def's.

Have you done copyright assignment for Emacs?

I think your current patch is a bit over the limit of what we can accept
without an assignment (unless we don't count lines added to tests?).
Though if you didn't refactor into the new function
python-imenu--get-defun-type-name it could probably squeeze in.

The form to start the assignment process is at
http://git.savannah.gnu.org/cgit/gnulib.git/tree/doc/Copyright/request-assign.program




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#24820; Package emacs. (Wed, 04 Jan 2017 16:49:01 GMT) Full text and rfc822 format available.

Message #14 received at 24820 <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Lazurkin <dilaz03 <at> gmail.com>
To: 24820 <at> debbugs.gnu.org
Subject: I think copyright is assigned
Date: Wed, 4 Jan 2017 19:48:48 +0300
Hello.


> Hello,
>
> Your assignment/disclaimer process with the FSF is currently
> complete; your fully executed PDF will be sent to you in a separate
> email immediately following this one.
>
> Please remember to let us know when your employment status changes, as
> this may affect your assignment status.
>
> Thank you for your contribution!
>
> All the best,
>
> Sincerely,
I think copyright is assigned. Or not?


Do you want merge this fix to branch 25.0? Or to master?







Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#24820; Package emacs. (Wed, 04 Jan 2017 16:55:02 GMT) Full text and rfc822 format available.

Message #17 received at 24820 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Dmitry Lazurkin <dilaz03 <at> gmail.com>
Cc: 24820 <at> debbugs.gnu.org
Subject: Re: bug#24820: I think copyright is assigned
Date: Wed, 04 Jan 2017 18:55:00 +0200
> From: Dmitry Lazurkin <dilaz03 <at> gmail.com>
> Date: Wed, 4 Jan 2017 19:48:48 +0300
> 
> Do you want merge this fix to branch 25.0? Or to master?

Is this a problem that is new with Emacs 25.1?  If not, then it should
go to the master branch.

Thanks.




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#24820; Package emacs. (Wed, 04 Jan 2017 20:26:02 GMT) Full text and rfc822 format available.

Message #20 received at 24820 <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Lazurkin <dilaz03 <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 24820 <at> debbugs.gnu.org
Subject: Re: bug#24820: Rebase against master
Date: Wed, 4 Jan 2017 23:24:54 +0300
From 730e455bdba33849bf47126527cc8ca477ebbb82 Mon Sep 17 00:00:00 2001
From: Dmitry Lazurkin <dilaz03 <at> gmail.com>
Date: Wed, 4 Jan 2017 21:46:21 +0300
Subject: [PATCH] Fix extracting async def type and name in python mode imenu

* lisp/progmodes/python.el (python-imenu--get-defun-type-name):
New function.
(python-imenu--build-tree): Use python-imenu--get-defun-type-name for
extract async or simple def type and name at current position.
* test/lisp/progmodes/python-tests.el (python-imenu-create-index-1):
(python-imenu-create-flat-index-1): Add async def's.
---
 lisp/progmodes/python.el            | 17 ++++++++++++-----
 test/lisp/progmodes/python-tests.el | 12 ++++++++++--
 2 files changed, 22 insertions(+), 7 deletions(-)

diff --git a/lisp/progmodes/python.el b/lisp/progmodes/python.el
index 68e19ef..d8262dd 100644
--- a/lisp/progmodes/python.el
+++ b/lisp/progmodes/python.el
@@ -4415,6 +4415,15 @@ python-imenu-format-parent-item-jump-label
       "*class definition*"
     "*function definition*"))

+(defun python-imenu--get-defun-type-name ()
+  "Return defun type and name at current position."
+  (when (looking-at python-nav-beginning-of-defun-regexp)
+    (let ((split (split-string (match-string-no-properties 0))))
+      (if (= (length split) 2)
+          split
+        (list (concat (car split) " " (cadr split))
+              (car (last split)))))))
+
 (defun python-imenu--put-parent (type name pos tree)
   "Add the parent with TYPE, NAME and POS to TREE."
   (let ((label
@@ -4432,11 +4441,9 @@ python-imenu--build-tree
   (setq min-indent (or min-indent 0)
         prev-indent (or prev-indent python-indent-offset))
   (let* ((pos (python-nav-backward-defun))
-         (type)
-         (name (when (and pos (looking-at 
python-nav-beginning-of-defun-regexp))
-                 (let ((split (split-string (match-string-no-properties 
0))))
-                   (setq type (car split))
-                   (cadr split))))
+         (defun-type-name (and pos (python-imenu--get-defun-type-name)))
+         (type (car defun-type-name))
+         (name (cadr defun-type-name))
          (label (when name
                   (funcall python-imenu-format-item-label-function 
type name)))
          (indent (current-indentation))
diff --git a/test/lisp/progmodes/python-tests.el 
b/test/lisp/progmodes/python-tests.el
index 94c356b..2df1bbf 100644
--- a/test/lisp/progmodes/python-tests.el
+++ b/test/lisp/progmodes/python-tests.el
@@ -3559,6 +3559,9 @@ python-tests-shell-interpreter

         def c(self):
             pass
+
+        async def d(self):
+            pass
 "
    (goto-char (point-max))
    (should (equal
@@ -3580,7 +3583,8 @@ python-tests-shell-interpreter
               (list
                "Frob (class)"
                (cons "*class definition*" (copy-marker 601))
-               (cons "c (def)" (copy-marker 626)))))
+               (cons "c (def)" (copy-marker 626))
+               (cons "d (async def)" (copy-marker 665)))))
             (python-imenu-create-index)))))

 (ert-deftest python-imenu-create-index-2 ()
@@ -3702,6 +3706,9 @@ python-tests-shell-interpreter

         def c(self):
             pass
+
+        async def d(self):
+            pass
 "
    (goto-char (point-max))
    (should (equal
@@ -3714,7 +3721,8 @@ python-tests-shell-interpreter
                   (cons "Baz.a" (copy-marker 539))
                   (cons "Baz.b" (copy-marker 570))
                   (cons "Baz.Frob" (copy-marker 601))
-                  (cons "Baz.Frob.c" (copy-marker 626)))
+                  (cons "Baz.Frob.c" (copy-marker 626))
+                  (cons "Baz.Frob.d" (copy-marker 665)))
             (python-imenu-create-flat-index)))))

 (ert-deftest python-imenu-create-flat-index-2 ()
-- 
2.7.4






Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#24820; Package emacs. (Wed, 04 Jan 2017 20:28:01 GMT) Full text and rfc822 format available.

Message #23 received at 24820 <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Lazurkin <dilaz03 <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 24820 <at> debbugs.gnu.org
Subject: Re: bug#24820: Rebase against master
Date: Wed, 4 Jan 2017 23:27:11 +0300
Some fixes:
- fix commit message
- return imenu type "async def" for async def's (is formatting code ugly?)





Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#24820; Package emacs. (Thu, 05 Jan 2017 04:07:01 GMT) Full text and rfc822 format available.

Message #26 received at 24820 <at> debbugs.gnu.org (full text, mbox):

From: npostavs <at> users.sourceforge.net
To: Dmitry Lazurkin <dilaz03 <at> gmail.com>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 24820 <at> debbugs.gnu.org
Subject: bug#24820: Imenu in `python-mode' does not display function name for
 async def
Date: Wed, 04 Jan 2017 23:07:53 -0500
Dmitry Lazurkin <dilaz03 <at> gmail.com> writes:

> Some fixes:
> - fix commit message
> - return imenu type "async def" for async def's

Thanks.  I'll push this to master in a week or so, unless there are
objections.

> (is formatting code ugly?)

I don't see any formatting problems in your code, but it looks like the
patch got word wrapped, I find sending as attachment generally avoids
such issues.

> -         (type)
> -         (name (when (and pos (looking-at
> python-nav-beginning-of-defun-regexp))
> -                 (let ((split (split-string
> (match-string-no-properties 0))))






Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#24820; Package emacs. (Thu, 05 Jan 2017 10:15:02 GMT) Full text and rfc822 format available.

Message #29 received at 24820 <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Lazurkin <dilaz03 <at> gmail.com>
To: npostavs <at> users.sourceforge.net
Cc: Eli Zaretskii <eliz <at> gnu.org>, 24820 <at> debbugs.gnu.org
Subject: Re: bug#24820: Imenu in `python-mode' does not display function name
 for async def
Date: Thu, 5 Jan 2017 13:14:31 +0300
On 01/05/2017 07:07 AM, npostavs <at> users.sourceforge.net wrote:
>> (is formatting code ugly?)
> I don't see any formatting problems in your code, but it looks like the
> patch got word wrapped, 

Formatting of "async def":
+        (list (concat (car split) " " (cadr split))
+              (car (last split)))))))

> I find sending as attachment generally avoids
> such issues.
>
>> -         (type)
>> -         (name (when (and pos (looking-at
>> python-nav-beginning-of-defun-regexp))
>> -                 (let ((split (split-string
>> (match-string-no-properties 0))))
>
Is resending patch as attachment correct for debbugs.gnu.org?





Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#24820; Package emacs. (Thu, 05 Jan 2017 20:21:02 GMT) Full text and rfc822 format available.

Message #32 received at 24820 <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Lazurkin <dilaz03 <at> gmail.com>
To: npostavs <at> users.sourceforge.net
Cc: Eli Zaretskii <eliz <at> gnu.org>, 24820 <at> debbugs.gnu.org
Subject: Re: bug#24820: Imenu in `python-mode' does not display function name
 for async def
Date: Thu, 5 Jan 2017 23:20:44 +0300
[Message part 1 (text/plain, inline)]
On 01/05/2017 07:07 AM, npostavs <at> users.sourceforge.net wrote:
> I don't see any formatting problems in your code, but it looks like the
> patch got word wrapped, I find sending as attachment generally avoids
> such issues.

This is strange because email from my sent emails has not wrapping problem...

Try to send patch in body and in attachment:

From 730e455bdba33849bf47126527cc8ca477ebbb82 Mon Sep 17 00:00:00 2001
From: Dmitry Lazurkin <dilaz03 <at> gmail.com>
Date: Wed, 4 Jan 2017 21:46:21 +0300
Subject: [PATCH] Fix extracting async def type and name in python mode imenu

* lisp/progmodes/python.el (python-imenu--get-defun-type-name):
New function.
(python-imenu--build-tree): Use python-imenu--get-defun-type-name for
extract async or simple def type and name at current position.
* test/lisp/progmodes/python-tests.el (python-imenu-create-index-1):
(python-imenu-create-flat-index-1): Add async def's.
---
 lisp/progmodes/python.el            | 17 ++++++++++++-----
 test/lisp/progmodes/python-tests.el | 12 ++++++++++--
 2 files changed, 22 insertions(+), 7 deletions(-)

diff --git a/lisp/progmodes/python.el b/lisp/progmodes/python.el
index 68e19ef..d8262dd 100644
--- a/lisp/progmodes/python.el
+++ b/lisp/progmodes/python.el
@@ -4415,6 +4415,15 @@ python-imenu-format-parent-item-jump-label
       "*class definition*"
     "*function definition*"))
 
+(defun python-imenu--get-defun-type-name ()
+  "Return defun type and name at current position."
+  (when (looking-at python-nav-beginning-of-defun-regexp)
+    (let ((split (split-string (match-string-no-properties 0))))
+      (if (= (length split) 2)
+          split
+        (list (concat (car split) " " (cadr split))
+              (car (last split)))))))
+
 (defun python-imenu--put-parent (type name pos tree)
   "Add the parent with TYPE, NAME and POS to TREE."
   (let ((label
@@ -4432,11 +4441,9 @@ python-imenu--build-tree
   (setq min-indent (or min-indent 0)
         prev-indent (or prev-indent python-indent-offset))
   (let* ((pos (python-nav-backward-defun))
-         (type)
-         (name (when (and pos (looking-at python-nav-beginning-of-defun-regexp))
-                 (let ((split (split-string (match-string-no-properties 0))))
-                   (setq type (car split))
-                   (cadr split))))
+         (defun-type-name (and pos (python-imenu--get-defun-type-name)))
+         (type (car defun-type-name))
+         (name (cadr defun-type-name))
          (label (when name
                   (funcall python-imenu-format-item-label-function type name)))
          (indent (current-indentation))
diff --git a/test/lisp/progmodes/python-tests.el b/test/lisp/progmodes/python-tests.el
index 94c356b..2df1bbf 100644
--- a/test/lisp/progmodes/python-tests.el
+++ b/test/lisp/progmodes/python-tests.el
@@ -3559,6 +3559,9 @@ python-tests-shell-interpreter
 
         def c(self):
             pass
+
+        async def d(self):
+            pass
 "
    (goto-char (point-max))
    (should (equal
@@ -3580,7 +3583,8 @@ python-tests-shell-interpreter
               (list
                "Frob (class)"
                (cons "*class definition*" (copy-marker 601))
-               (cons "c (def)" (copy-marker 626)))))
+               (cons "c (def)" (copy-marker 626))
+               (cons "d (async def)" (copy-marker 665)))))
             (python-imenu-create-index)))))
 
 (ert-deftest python-imenu-create-index-2 ()
@@ -3702,6 +3706,9 @@ python-tests-shell-interpreter
 
         def c(self):
             pass
+
+        async def d(self):
+            pass
 "
    (goto-char (point-max))
    (should (equal
@@ -3714,7 +3721,8 @@ python-tests-shell-interpreter
                   (cons "Baz.a" (copy-marker 539))
                   (cons "Baz.b" (copy-marker 570))
                   (cons "Baz.Frob" (copy-marker 601))
-                  (cons "Baz.Frob.c" (copy-marker 626)))
+                  (cons "Baz.Frob.c" (copy-marker 626))
+                  (cons "Baz.Frob.d" (copy-marker 665)))
             (python-imenu-create-flat-index)))))
 
 (ert-deftest python-imenu-create-flat-index-2 ()
-- 
2.7.4


[0001-Fix-extracting-async-def-type-and-name-in-python-mod.patch (text/x-patch, attachment)]

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#24820; Package emacs. (Thu, 05 Jan 2017 21:05:02 GMT) Full text and rfc822 format available.

Message #35 received at 24820 <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Lazurkin <dilaz03 <at> gmail.com>
To: npostavs <at> users.sourceforge.net
Cc: Eli Zaretskii <eliz <at> gnu.org>, 24820 <at> debbugs.gnu.org
Subject: Re: bug#24820: Imenu in `python-mode' does not display function name
 for async def
Date: Fri, 6 Jan 2017 00:03:58 +0300
[Message part 1 (text/plain, inline)]
      
        Oh, i missed "(Bug#24820)" in commit message.

[Message part 2 (text/html, inline)]

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#24820; Package emacs. (Fri, 06 Jan 2017 01:19:02 GMT) Full text and rfc822 format available.

Message #38 received at 24820 <at> debbugs.gnu.org (full text, mbox):

From: npostavs <at> users.sourceforge.net
To: Dmitry Lazurkin <dilaz03 <at> gmail.com>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 24820 <at> debbugs.gnu.org
Subject: Re: bug#24820: Imenu in `python-mode' does not display function name
 for async def
Date: Thu, 05 Jan 2017 20:19:15 -0500
Dmitry Lazurkin <dilaz03 <at> gmail.com> writes:

> On 01/05/2017 07:07 AM, npostavs <at> users.sourceforge.net wrote:
>>> (is formatting code ugly?)
>> I don't see any formatting problems in your code,
>
> Formatting of "async def":
> +        (list (concat (car split) " " (cadr split))
> +              (car (last split)))))))

Formatting looks fine here.  Since I'm staring at it anyway, it could be
optimized like so:

    (cons (concat (car split) " " (cadr split))
          (last split))

It's fine either way though.




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#24820; Package emacs. (Fri, 06 Jan 2017 12:08:02 GMT) Full text and rfc822 format available.

Message #41 received at 24820 <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Lazurkin <dilaz03 <at> gmail.com>
To: npostavs <at> users.sourceforge.net
Cc: Eli Zaretskii <eliz <at> gnu.org>, 24820 <at> debbugs.gnu.org
Subject: Re: bug#24820: Imenu in `python-mode' does not display function name
 for async def
Date: Fri, 6 Jan 2017 15:07:00 +0300
On 01/06/2017 04:19 AM, npostavs <at> users.sourceforge.net wrote:
>     (cons (concat (car split) " " (cadr split))
>           (last split))
This is not so easy because variable "split" is list which returned in
prev branch of if.






Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#24820; Package emacs. (Fri, 06 Jan 2017 14:00:02 GMT) Full text and rfc822 format available.

Message #44 received at 24820 <at> debbugs.gnu.org (full text, mbox):

From: npostavs <at> users.sourceforge.net
To: Dmitry Lazurkin <dilaz03 <at> gmail.com>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 24820 <at> debbugs.gnu.org
Subject: Re: bug#24820: Imenu in `python-mode' does not display function name
 for async def
Date: Fri, 06 Jan 2017 09:00:30 -0500
Dmitry Lazurkin <dilaz03 <at> gmail.com> writes:

> On 01/06/2017 04:19 AM, npostavs <at> users.sourceforge.net wrote:
>>     (cons (concat (car split) " " (cadr split))
>>           (last split))
> This is not so easy because variable "split" is list which returned in
> prev branch of if.

So, why is that a problem?




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#24820; Package emacs. (Fri, 06 Jan 2017 19:42:02 GMT) Full text and rfc822 format available.

Message #47 received at 24820 <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Lazurkin <dilaz03 <at> gmail.com>
To: npostavs <at> users.sourceforge.net
Cc: Eli Zaretskii <eliz <at> gnu.org>, 24820 <at> debbugs.gnu.org
Subject: Re: bug#24820: Imenu in `python-mode' does not display function name
 for async def
Date: Fri, 6 Jan 2017 22:41:21 +0300
On 01/06/2017 05:00 PM, npostavs <at> users.sourceforge.net wrote:
> So, why is that a problem?

This is not problem for me.




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#24820; Package emacs. (Fri, 13 Jan 2017 01:49:02 GMT) Full text and rfc822 format available.

Message #50 received at 24820 <at> debbugs.gnu.org (full text, mbox):

From: npostavs <at> users.sourceforge.net
To: Dmitry Lazurkin <dilaz03 <at> gmail.com>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 24820 <at> debbugs.gnu.org
Subject: Re: bug#24820: Imenu in `python-mode' does not display function name
 for async def
Date: Thu, 12 Jan 2017 20:49:07 -0500
tags 24820 fixed
close 24820 26.1
quit

Dmitry Lazurkin <dilaz03 <at> gmail.com> writes:

> On 01/06/2017 05:00 PM, npostavs <at> users.sourceforge.net wrote:
>> So, why is that a problem?
>
> This is not problem for me.

Okay, then I'm not quite sure what we were talking about.  Anyway, like
I said before, your patch looks fine so I've pushed it to master [1:
d4a9708].  I added "(Bug#24820)" to the commit, but I didn't change the
code.

1: 2017-01-12 20:40:19 -0500 d4a97088f69eb5729261ee4581cfb7d60c673ebd
  Fix extracting async def type and name in python mode imenu




Added tag(s) fixed. Request was from npostavs <at> users.sourceforge.net to control <at> debbugs.gnu.org. (Fri, 13 Jan 2017 01:49:02 GMT) Full text and rfc822 format available.

bug marked as fixed in version 26.1, send any further explanations to 24820 <at> debbugs.gnu.org and Dmitry Lazurkin <dilaz03 <at> gmail.com> Request was from npostavs <at> users.sourceforge.net to control <at> debbugs.gnu.org. (Fri, 13 Jan 2017 01:49:02 GMT) Full text and rfc822 format available.

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#24820; Package emacs. (Fri, 13 Jan 2017 09:35:01 GMT) Full text and rfc822 format available.

Message #57 received at 24820 <at> debbugs.gnu.org (full text, mbox):

From: "dilaz03 ." <dilaz03 <at> gmail.com>
To: npostavs <at> users.sourceforge.net
Cc: Eli Zaretskii <eliz <at> gnu.org>, 24820 <at> debbugs.gnu.org
Subject: Re: bug#24820: Imenu in `python-mode' does not display function name
 for async def
Date: Fri, 13 Jan 2017 12:34:51 +0300
[Message part 1 (text/plain, inline)]
Thanks.

13 янв. 2017 г. 4:48 пользователь <npostavs <at> users.sourceforge.net> написал:

> tags 24820 fixed
> close 24820 26.1
> quit
>
> Dmitry Lazurkin <dilaz03 <at> gmail.com> writes:
>
> > On 01/06/2017 05:00 PM, npostavs <at> users.sourceforge.net wrote:
> >> So, why is that a problem?
> >
> > This is not problem for me.
>
> Okay, then I'm not quite sure what we were talking about.  Anyway, like
> I said before, your patch looks fine so I've pushed it to master [1:
> d4a9708].  I added "(Bug#24820)" to the commit, but I didn't change the
> code.
>
> 1: 2017-01-12 20:40:19 -0500 d4a97088f69eb5729261ee4581cfb7d60c673ebd
>   Fix extracting async def type and name in python mode imenu
>
[Message part 2 (text/html, inline)]

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Fri, 10 Feb 2017 12:24:03 GMT) Full text and rfc822 format available.

bug unarchived. Request was from npostavs <at> users.sourceforge.net to control <at> debbugs.gnu.org. (Sat, 18 Feb 2017 14:22:03 GMT) Full text and rfc822 format available.

Forcibly Merged 24820 25734. Request was from npostavs <at> users.sourceforge.net to control <at> debbugs.gnu.org. (Sat, 18 Feb 2017 14:22:03 GMT) Full text and rfc822 format available.

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Sun, 19 Mar 2017 11:24:04 GMT) Full text and rfc822 format available.

This bug report was last modified 8 years and 95 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.