GNU bug report logs - #24727
25.1; Editing custom theme removes undefined variables and faces

Previous Next

Full log

Message #11 received at 24727 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Mauro Aranda <maurooaranda <at> gmail.com>
Cc: Allen Li <vianchielfaura <at> gmail.com>, 24727 <at> debbugs.gnu.org
Subject: Re: bug#24727: 25.1; Editing custom theme removes undefined
 variables and faces
Date: Fri, 04 Sep 2020 15:38:47 +0200

Mauro Aranda <maurooaranda <at> gmail.com> writes:

> There is a check in custom-theme-write-variables for a bound symbol, and
> a check in custom-theme-write-faces for a known face, and I wonder why,
> because that should not be a concern for these functions.

Yes, that seems odd.  I had a short look around at the commit history
here, but I was unable to find an explanation (but I didn't do an
extensive examination).

> But at least removing the checks makes it less rude, and undefined
> variables or faces stay in the file.
>
> Here's my proposed patch.

It makes sense to me (and the old behaviour didn't), so I've applied it
to Emacs 28.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.