GNU bug report logs - #24726
25.1; Small typo/bug in bookmark.el

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 24726 in the body.
You can then email your comments to 24726 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Allen Li <vianchielfaura <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 25.1; Small typo/bug in bookmark.el
Date: Tue, 18 Oct 2016 01:07:31 -0700

There appears to be a small typo in bookmark.el's
`bookmark-set-internal', which uses "(default: \"%s\")" for its
minibuffer prompt instead of "(default \"%s\")" (note the colon).  This
causes `minibuffer-electric-default-mode' some grief.

In GNU Emacs 25.1.1 (x86_64-unknown-linux-gnu, GTK+ Version 3.20.9)
 of 2016-09-18 built on juergen
Windowing system distributor 'The X.Org Foundation', version 11.0.11804000
Configured using:
 'configure --prefix=/usr --sysconfdir=/etc --libexecdir=/usr/lib
 --localstatedir=/var --with-x-toolkit=gtk3 --with-xft
 'CFLAGS=-march=x86-64 -mtune=generic -O2 -pipe
 -fstack-protector-strong' CPPFLAGS=-D_FORTIFY_SOURCE=2
 LDFLAGS=-Wl,-O1,--sort-common,--as-needed,-z,relro'

Configured features:
XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND GPM DBUS GCONF GSETTINGS
NOTIFY ACL GNUTLS LIBXML2 FREETYPE M17N_FLT LIBOTF XFT ZLIB
TOOLKIT_SCROLL_BARS GTK3 X11

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Allen Li <darkfeline <at> felesatra.moe>
To: bug-gnu-emacs <at> gnu.org
Subject: bug#24726: [PATCH] Small typo/bug in bookmark.el
Date: Sat, 08 Apr 2017 15:21:12 -0700

The standard default format (per `minibuffer-electric-default-mode')
does not use a colon.
---
 lisp/bookmark.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/bookmark.el b/lisp/bookmark.el
index 5b8ded7b22..8c33d13c55 100644
--- a/lisp/bookmark.el
+++ b/lisp/bookmark.el
@@ -802,7 +802,7 @@ bookmark-set-internal
          (let ((str
                 (or name
                     (read-from-minibuffer
-                     (format "%s (default: \"%s\"): " prompt default)
+                     (format "%s (default \"%s\"): " prompt default)
                      nil
                      bookmark-minibuffer-read-name-map
                      nil nil defaults))))
-- 
2.12.2

Message #13 received at 24726 <at> debbugs.gnu.org (full text, mbox):

From: Noam Postavsky <npostavs <at> gmail.com>
To: Allen Li <darkfeline <at> felesatra.moe>
Cc: 24726 <at> debbugs.gnu.org
Subject: Re: bug#24726: [PATCH] Small typo/bug in bookmark.el
Date: Tue, 05 Jun 2018 20:34:20 -0400

tags 24726 fixed
close 24726 26.2
quit

Allen Li <darkfeline <at> felesatra.moe> writes:

> -                     (format "%s (default: \"%s\"): " prompt default)
> +                     (format "%s (default \"%s\"): " prompt default)

Pushed to emacs-26.

[1: d20beef5f1]: 2018-06-05 20:29:22 -0400
  Fix prompt in bookmark.el (Bug#24726)
  https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=d20beef5f104909f765430e347f5f3711ea51149>

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.