GNU bug report logs - #24725
25.1.50; vc-region-history may exceed max line number of file in repository

Previous Next

Full log

Message #20 received at 24725 <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: Tino Calancha <tino.calancha <at> gmail.com>, Andreas Schwab <schwab <at> suse.de>
Cc: 24725 <at> debbugs.gnu.org
Subject: Re: bug#24725: 25.1.50; vc-region-history may exceed max line number
 of file in repository
Date: Thu, 20 Oct 2016 13:21:00 +0300

On 20.10.2016 11:09, Tino Calancha wrote:

>> Shouldn't that be fixed in the caller, and lto always be decremented if
>> the regions ends at bol?
> I think you are right.  Otherwise we are including a line out of the
> region, i.e., in interactive calls we also search in the history for
> a line out of the highlighted region.
> How about following new patch?

LGTM, please install.

Although I was thinking of simplifying it to just:

(line-number-at-pos (1- to))

That can only bite us if TO is at bob, which would be very unusual.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.