GNU bug report logs - #24573
25.1; Setting bookmark in buffer *Help* makes bookmarks non-loadable

Previous Next

Full log

Message #14 received at 24573 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: Noam Postavsky <npostavs <at> users.sourceforge.net>
Cc: Dmitri Paduchikh <dpaduchikh <at> gmail.com>, 24573 <at> debbugs.gnu.org,
 Win Treese <treese <at> acm.org>
Subject: Re: bug#24573: 25.1; Setting bookmark in buffer *Help* makes
 bookmarks non-loadable
Date: Tue, 2 Jul 2019 18:22:46 +0200

[Message part 1 (text/plain, inline)]

tags 24573 patch
quit

Noam Postavsky <npostavs <at> users.sourceforge.net> writes:

> The lambda is fine, it's the buffer which uses the unreadable print
> synax: #<...>.  The following which swaps buffer objects with their name
> seems to fix it, although I haven't really tested this much.
>
> --- i/lisp/help-mode.el
> +++ w/lisp/help-mode.el
> @@ -756,7 +756,9 @@ help-bookmark-make-record
>      (error "Cannot create bookmark - help command not known"))
>    `(,@(bookmark-make-record-default 'NO-FILE 'NO-CONTEXT)
>        (help-fn     . ,(car help-xref-stack-item))
> -      (help-args   . ,(cdr help-xref-stack-item))
> +      (help-args   . ,(mapcar (lambda (a)
> +                                (if (bufferp a) (buffer-name a) a))
> +                              (cdr help-xref-stack-item)))
>        (position    . ,(point))
>        (handler     . help-bookmark-jump)))

I can confirm this bug, which I've recently stumbled into myself.

I can also confirm that Noam Postavsky's fix works.

In the interest of getting it merged as soon as possible, I'm sending
it here as a diff to be easier to apply.  I could send it as a patch
too if that will get it merged faster.  But the credit for fixing this
should fully go to Noam Postavsky.

Thanks,
Stefan Kangas

[bug24573.diff (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.