GNU bug report logs - #24474
dired-diff doesn't know about backup-directory-alist

Previous Next

Package: emacs;

Reported by: 積丹尼 Dan Jacobson <jidanni <at> jidanni.org>

Date: Mon, 19 Sep 2016 23:17:02 UTC

Severity: minor

Merged with 30407

Found in version 25.1

Fixed in version 26.1

Done: Glenn Morris <rgm <at> gnu.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 24474 in the body.
You can then email your comments to 24474 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#24474; Package emacs. (Mon, 19 Sep 2016 23:17:02 GMT) Full text and rfc822 format available.
Acknowledgement sent to 積丹尼 Dan Jacobson <jidanni <at> jidanni.org>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Mon, 19 Sep 2016 23:17:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: 積丹尼 Dan Jacobson <jidanni <at> jidanni.org>
To: bug-gnu-emacs <bug-gnu-emacs <at> gnu.org>
Subject: dired-diff doesn't know about backup-directory-alist
Date: Mon, 19 Sep 2016 23:40:37 +0800

= runs the command dired-diff, which is an interactive autoloaded
compiled Lisp function in `dired-aux.el'.

It is bound to =, <menu-bar> <immediate> <diff>.

(dired-diff FILE &optional SWITCHES)

Compare file at point with file FILE using `diff'.
If called interactively, prompt for FILE.  If the file at point
has a backup file, use that as the default.  If the file at point
is a backup file, use its original...

[OK, let's try it. Oops:]

diff -U0 /home/jidanni/\!home\!jidanni\!.bash_profile.\~42\~ /home/jidanni/.bash_profile
diff: /home/jidanni/!home!jidanni!.bash_profile.~42~: No such file or directory

Diff finished (diff error).  Mon Sep 19 23:25:22 2016

[Which is because the correct file name is:]

/home/jidanni/.backups/!home!jidanni!.bash_profile.~42~

[because of my:]

backup-directory-alist is a variable defined in `files.el'.
Its value is ((".*" . "~/.backups/"))
Original value was nil

[So we see that dired-diff got the filename right, but the directory
wrong.

Furthermore, "if the file at point is a backup file..." also fails
miserably. Go to your ~/.backups directory and try it on a few files...]

diff -U0 /home/jidanni/.backups/\!home\!jidanni\!.bash_profile.\~42\~ /home/jidanni/.backups/\!home\!jidanni\!.bash_profile
diff: /home/jidanni/.backups/!home!jidanni!.bash_profile: No such file or directory

Diff finished (diff error).  Mon Sep 19 23:37:10 2016

[We see it assumes everything is in the same directory.
It should have tried comparing ~/.bash_profile .

emacs-version "24.5.1".]
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#24474; Package emacs. (Tue, 20 Sep 2016 01:40:01 GMT) Full text and rfc822 format available.

Message #8 received at 24474 <at> debbugs.gnu.org (full text, mbox):

From: npostavs <at> users.sourceforge.net
To: 積丹尼 Dan Jacobson <jidanni <at> jidanni.org>
Cc: 24474 <at> debbugs.gnu.org
Subject: Re: bug#24474: dired-diff doesn't know about backup-directory-alist
Date: Mon, 19 Sep 2016 21:40:01 -0400

unarchive 24089
forcemerge 24089 24474
quit

This was already reported in #24089 and fixed in master (not released yet).
Forcibly Merged 24089 24474. Request was from npostavs <at> users.sourceforge.net to control <at> debbugs.gnu.org. (Tue, 20 Sep 2016 01:40:02 GMT) Full text and rfc822 format available.
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Tue, 18 Oct 2016 11:24:04 GMT) Full text and rfc822 format available.
bug unarchived. Request was from Jorge Morais Neto <jorge13515 <at> gmail.com> to control <at> debbugs.gnu.org. (Tue, 15 Nov 2016 15:58:01 GMT) Full text and rfc822 format available.
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Wed, 14 Dec 2016 12:24:04 GMT) Full text and rfc822 format available.
bug unarchived. Request was from Jorge Morais Neto <jorge13515 <at> gmail.com> to control <at> debbugs.gnu.org. (Sun, 12 Feb 2017 14:29:01 GMT) Full text and rfc822 format available.
Did not alter fixed versions and reopened. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Sun, 12 Feb 2017 14:38:02 GMT) Full text and rfc822 format available.
Merged 24089 24474 30407. Request was from Glenn Morris <rgm <at> gnu.org> to control <at> debbugs.gnu.org. (Sat, 10 Feb 2018 19:31:03 GMT) Full text and rfc822 format available.
Disconnected #24089 from all other report(s). Request was from Glenn Morris <rgm <at> gnu.org> to control <at> debbugs.gnu.org. (Sat, 10 Feb 2018 19:33:02 GMT) Full text and rfc822 format available.
bug marked as fixed in version 26.1, send any further explanations to 30407 <at> debbugs.gnu.org and 積丹尼 Dan Jacobson <jidanni <at> jidanni.org> Request was from Glenn Morris <rgm <at> gnu.org> to control <at> debbugs.gnu.org. (Sat, 10 Feb 2018 19:34:02 GMT) Full text and rfc822 format available.
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Sun, 11 Mar 2018 11:24:04 GMT) Full text and rfc822 format available.
This bug report was last modified 7 years and 159 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.