GNU bug report logs - #24360
25.1; byte-compile-error-on-warn doesn't treat all warnings as errors

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 24360 in the body.
You can then email your comments to 24360 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Philipp <p.stephani2 <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 25.1; byte-compile-error-on-warn doesn't treat all warnings as errors
Date: Sat, 03 Sep 2016 19:40:05 +0200

Create a file /tmp/a.el with the following content:

(funcall '(lambda ()))

Then run

$ emacs -batch -Q -eval '(setq byte-compile-error-on-warn t)' -f batch-byte-compile /tmp/a.el ; echo $?

In toplevel form:
/tmp/a.el:1:1:Warning: (lambda nil ...) quoted with ' rather than with #'
0

Expected behavior: The warning is treated as an error because
byte-compile-error-on-warn is non-nil.

Actual behavior: The warning is not treated as an error.

This is because some warnings use byte-compile-log-warning instead of
byte-compile-warn.  In this case, macroexp--warn-and-return is the
culprit.  Probably byte-compile-log-warning should be made internal to
bytecomp.el, and never be called except from byte-compile-warn and
byte-compile-report-error.



In GNU Emacs 25.1.3 (x86_64-unknown-linux-gnu, GTK+ Version 3.10.8)
 of 2016-09-03 built on unknown
Repository revision: 803ad6f7e7a9c6bcf8a6cbf8eaad17501b114a33
Windowing system distributor 'The X.Org Foundation', version 11.0.11702000
System Description:	Ubuntu 14.04 LTS

Configured features:
XPM JPEG TIFF GIF PNG SOUND GSETTINGS NOTIFY GNUTLS FREETYPE XFT ZLIB
TOOLKIT_SCROLL_BARS GTK3 X11

Important settings:
  value of $LANG: en_US.UTF-8
  locale-coding-system: utf-8-unix

Major mode: Emacs-Lisp

Minor modes in effect:
  tooltip-mode: t
  global-eldoc-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Recent messages:
Mark set
Setting ‘send-mail-function’ temporarily since "emacs -q" would overwrite customizations
Sending...
Mark set [2 times]
Sending via mail...
Setting ‘smtpmail-smtp-server’ temporarily since "emacs -q" would overwrite customizations
Setting ‘smtpmail-smtp-service’ temporarily since "emacs -q" would overwrite customizations
Sending email 
Sending email done
Sending...done

Load-path shadows:
None found.

Features:
(network-stream nsm starttls tls gnutls mailalias smtpmail auth-source
cl-seq eieio byte-opt bytecomp byte-compile cl-extra cconv eieio-core
cl-macs gv qp cus-edit cus-start cus-load wid-edit pp shadow sort
mail-extr emacsbug message dired format-spec rfc822 mml mml-sec
password-cache epg epg-config gnus-util mm-decode mm-bodies mm-encode
mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047
rfc2045 ietf-drums mm-util help-fns help-mode easymenu cl-loaddefs pcase
cl-lib mail-prsvr mail-utils time-date mule-util tooltip eldoc electric
uniquify ediff-hook vc-hooks lisp-float-type mwheel x-win
term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe
tabulated-list newcomment elisp-mode lisp-mode prog-mode register page
menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock font-lock
syntax facemenu font-core frame cl-generic cham georgian utf-8-lang
misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms
cp51932 hebrew greek romanian slovak czech european ethiopic indian
cyrillic chinese charscript case-table epa-hook jka-cmpr-hook help
simple abbrev minibuffer cl-preloaded nadvice loaddefs button faces
cus-face macroexp files text-properties overlay sha1 md5 base64 format
env code-pages mule custom widget hashtable-print-readable backquote
inotify dynamic-setting system-font-setting font-render-setting
move-toolbar gtk x-toolkit x multi-tty make-network-process emacs)

Memory information:
((conses 16 119674 16537)
 (symbols 48 22519 1)
 (miscs 40 327 168)
 (strings 32 21974 7538)
 (string-bytes 1 636109)
 (vectors 16 18827)
 (vector-slots 8 872737 93406)
 (floats 8 211 249)
 (intervals 56 446 4)
 (buffers 976 28)
 (heap 1024 41113 5584))

Message #8 received at 24360 <at> debbugs.gnu.org (full text, mbox):

From: Philipp Stephani <p.stephani2 <at> gmail.com>
To: 24359 <at> debbugs.gnu.org, 24360 <at> debbugs.gnu.org
Subject: Patch for byte compilation bugs
Date: Sat, 03 Sep 2016 18:45:27 +0000

[Message part 1 (text/plain, inline)]

I've attached a patch for the two byte compilation bugs.

[Message part 2 (text/html, inline)]

[0001-Stop-calling-byte-compile-log-warning.patch (text/x-patch, attachment)]

Message #11 received at 24360 <at> debbugs.gnu.org (full text, mbox):

From: martin rudalics <rudalics <at> gmx.at>
To: Philipp Stephani <p.stephani2 <at> gmail.com>, 24359 <at> debbugs.gnu.org, 
 24360 <at> debbugs.gnu.org
Subject: Re: bug#24360: Patch for byte compilation bugs
Date: Sun, 04 Sep 2016 09:33:40 +0200

Pardon me this technical question: Receiving this in Thunderbird (on
Windows XP) gets me:


From: Philipp Stephani <phst <at> google.com>
Date: Sat, 3 Sep 2016 20:37:47 +0200
Subject: [PATCH] =?UTF-8?q?Stop=20calling=20=E2=80=98byte-compile-log-warn?=
 =?UTF-8?q?ing=E2=80=99?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

For errors, use ‘byte-compile-report-error’ instead so that the error
is registered and causes compilation to fail (Bug#24359).

For warnings, use ‘byte-compile-warn’ instead so that
‘byte-compile-error-on-warn’ is honored (Bug#24360).



What do I have to do to see the '`'...'´' correctly?

martin

Message #14 received at 24360 <at> debbugs.gnu.org (full text, mbox):

From: Andreas Schwab <schwab <at> linux-m68k.org>
To: martin rudalics <rudalics <at> gmx.at>
Cc: 24359 <at> debbugs.gnu.org, Philipp Stephani <p.stephani2 <at> gmail.com>,
 24360 <at> debbugs.gnu.org
Subject: Re: bug#24359: bug#24360: Patch for byte compilation bugs
Date: Sun, 04 Sep 2016 10:45:01 +0200

On Sep 04 2016, martin rudalics <rudalics <at> gmx.at> wrote:

> Pardon me this technical question: Receiving this in Thunderbird (on
> Windows XP) gets me:
>
>
> From: Philipp Stephani <phst <at> google.com>
> Date: Sat, 3 Sep 2016 20:37:47 +0200
> Subject: [PATCH] =?UTF-8?q?Stop=20calling=20=E2=80=98byte-compile-log-warn?=
>  =?UTF-8?q?ing=E2=80=99?=
> MIME-Version: 1.0
> Content-Type: text/plain; charset=UTF-8
> Content-Transfer-Encoding: 8bit
>
> For errors, use ‘byte-compile-report-error’ instead so that the error
> is registered and causes compilation to fail (Bug#24359).
>
> For warnings, use ‘byte-compile-warn’ instead so that
> ‘byte-compile-error-on-warn’ is honored (Bug#24360).
>
>
>
> What do I have to do to see the '`'...'´' correctly?

You can pass it directly to git am.

Andreas.

-- 
Andreas Schwab, schwab <at> linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

Message #17 received at 24360 <at> debbugs.gnu.org (full text, mbox):

From: Philipp Stephani <p.stephani2 <at> gmail.com>
To: martin rudalics <rudalics <at> gmx.at>, 24359 <at> debbugs.gnu.org,
 24360 <at> debbugs.gnu.org
Subject: Re: bug#24360: Patch for byte compilation bugs
Date: Sun, 04 Sep 2016 08:56:53 +0000

[Message part 1 (text/plain, inline)]

Seems Inbox generates an incorrect header for the attachment:

  Content-Type: text/x-patch; charset=US-ASCII

The following would be more appropriate:

  Content-Type: text/plain; charset=UTF-8

I've reported this; sorry for the trouble. You should be able to correctly
see the patch by downloading it an opening the file in Emacs.

martin rudalics <rudalics <at> gmx.at> schrieb am So., 4. Sep. 2016 um 09:33 Uhr:

> Pardon me this technical question: Receiving this in Thunderbird (on
> Windows XP) gets me:
>
>
> From: Philipp Stephani <phst <at> google.com>
> Date: Sat, 3 Sep 2016 20:37:47 +0200
> Subject: [PATCH]
> =?UTF-8?q?Stop=20calling=20=E2=80=98byte-compile-log-warn?=
>   =?UTF-8?q?ing=E2=80=99?=
> MIME-Version: 1.0
> Content-Type: text/plain; charset=UTF-8
> Content-Transfer-Encoding: 8bit
>
> For errors, use ‘byte-compile-report-error’ instead so that the error
> is registered and causes compilation to fail (Bug#24359).
>
> For warnings, use ‘byte-compile-warn’ instead so that
> ‘byte-compile-error-on-warn’ is honored (Bug#24360).
>
>
>
> What do I have to do to see the '`'...'´' correctly?
>
> martin
>
>

[Message part 2 (text/html, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.