GNU bug report logs - #24207
Fixing documentation example for make-custom-binary-input-port

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Andy Wingo <wingo <at> pobox.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#24207: closed (Fixing documentation example for
 make-custom-binary-input-port)
Date: Wed, 31 Aug 2016 13:53:01 +0000

[Message part 1 (text/plain, inline)]

Your message dated Wed, 31 Aug 2016 15:51:50 +0200
with message-id <87k2exjbbd.fsf <at> pobox.com>
and subject line Re: bug#24207: Fixing documentation example for make-custom-binary-input-port
has caused the debbugs.gnu.org bug report #24207,
regarding Fixing documentation example for make-custom-binary-input-port
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
24207: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=24207
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Christopher Allan Webber <cwebber <at> dustycloud.org>
To: bug-guile <at> gnu.org
Subject: Fixing documentation example for make-custom-binary-input-port
Date: Thu, 11 Aug 2016 15:13:23 -0500

[Message part 3 (text/plain, inline)]

The example previously did not run, because it was missing the "closed"
parameter.  Fixed.

[0001-Fix-example-in-make-custom-binary-input-port-documen.patch (text/x-patch, inline)]

From abed180e8ea3ada5c4e156165f0b5e648d517ba2 Mon Sep 17 00:00:00 2001
From: Christopher Allan Webber <cwebber <at> dustycloud.org>
Date: Thu, 11 Aug 2016 15:10:19 -0500
Subject: [PATCH] Fix example in make-custom-binary-input-port documentation

* doc/ref/api-io.texi (Custom Ports): Add additional argument to example's
  invocation of make-custom-binary-input-port.  Previously had mismatched arity
  by missing "closed" argument.
---
 doc/ref/api-io.texi | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/doc/ref/api-io.texi b/doc/ref/api-io.texi
index 76c8db8..e4e4f36 100644
--- a/doc/ref/api-io.texi
+++ b/doc/ref/api-io.texi
@@ -1,7 +1,7 @@
 @c -*-texinfo-*-
 @c This is part of the GNU Guile Reference Manual.
 @c Copyright (C)  1996, 1997, 2000, 2001, 2002, 2003, 2004, 2007, 2009,
-@c   2010, 2011, 2013  Free Software Foundation, Inc.
+@c   2010, 2011, 2013, 2016  Free Software Foundation, Inc.
 @c See the file guile.texi for copying conditions.
 
 @node Input and Output
@@ -1278,8 +1278,8 @@ procedure (@pxref{Bytevector Ports}) could be implemented as follows:
     (set! position new-position))
 
   (make-custom-binary-input-port "the port" read!
-                                  get-position
-                                  set-position!))
+                                  get-position set-position!
+                                  #f))
 
 (read (open-bytevector-input-port (string->utf8 "hello")))
 @result{} hello
-- 
2.9.2

[Message part 5 (message/rfc822, inline)]

From: Andy Wingo <wingo <at> pobox.com>
To: Christopher Allan Webber <cwebber <at> dustycloud.org>
Cc: 24207-done <at> debbugs.gnu.org
Subject: Re: bug#24207: Fixing documentation example for
 make-custom-binary-input-port
Date: Wed, 31 Aug 2016 15:51:50 +0200

On Thu 11 Aug 2016 22:13, Christopher Allan Webber <cwebber <at> dustycloud.org> writes:

> The example previously did not run, because it was missing the "closed"
> parameter.  Fixed.

Applied, thanks :)

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.