GNU bug report logs - #24207
Fixing documentation example for make-custom-binary-input-port

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 24207 in the body.
You can then email your comments to 24207 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Christopher Allan Webber <cwebber <at> dustycloud.org>
To: bug-guile <at> gnu.org
Subject: Fixing documentation example for make-custom-binary-input-port
Date: Thu, 11 Aug 2016 15:13:23 -0500

[Message part 1 (text/plain, inline)]

The example previously did not run, because it was missing the "closed"
parameter.  Fixed.

[0001-Fix-example-in-make-custom-binary-input-port-documen.patch (text/x-patch, inline)]

From abed180e8ea3ada5c4e156165f0b5e648d517ba2 Mon Sep 17 00:00:00 2001
From: Christopher Allan Webber <cwebber <at> dustycloud.org>
Date: Thu, 11 Aug 2016 15:10:19 -0500
Subject: [PATCH] Fix example in make-custom-binary-input-port documentation

* doc/ref/api-io.texi (Custom Ports): Add additional argument to example's
  invocation of make-custom-binary-input-port.  Previously had mismatched arity
  by missing "closed" argument.
---
 doc/ref/api-io.texi | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/doc/ref/api-io.texi b/doc/ref/api-io.texi
index 76c8db8..e4e4f36 100644
--- a/doc/ref/api-io.texi
+++ b/doc/ref/api-io.texi
@@ -1,7 +1,7 @@
 @c -*-texinfo-*-
 @c This is part of the GNU Guile Reference Manual.
 @c Copyright (C)  1996, 1997, 2000, 2001, 2002, 2003, 2004, 2007, 2009,
-@c   2010, 2011, 2013  Free Software Foundation, Inc.
+@c   2010, 2011, 2013, 2016  Free Software Foundation, Inc.
 @c See the file guile.texi for copying conditions.
 
 @node Input and Output
@@ -1278,8 +1278,8 @@ procedure (@pxref{Bytevector Ports}) could be implemented as follows:
     (set! position new-position))
 
   (make-custom-binary-input-port "the port" read!
-                                  get-position
-                                  set-position!))
+                                  get-position set-position!
+                                  #f))
 
 (read (open-bytevector-input-port (string->utf8 "hello")))
 @result{} hello
-- 
2.9.2

Message #10 received at 24207-done <at> debbugs.gnu.org (full text, mbox):

From: Andy Wingo <wingo <at> pobox.com>
To: Christopher Allan Webber <cwebber <at> dustycloud.org>
Cc: 24207-done <at> debbugs.gnu.org
Subject: Re: bug#24207: Fixing documentation example for
 make-custom-binary-input-port
Date: Wed, 31 Aug 2016 15:51:50 +0200

On Thu 11 Aug 2016 22:13, Christopher Allan Webber <cwebber <at> dustycloud.org> writes:

> The example previously did not run, because it was missing the "closed"
> parameter.  Fixed.

Applied, thanks :)

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.