GNU bug report logs - #24041
25.1.50; xwidget + -nw mode gives segfault

Previous Next

Full log

Message #8 received at 24041 <at> debbugs.gnu.org (full text, mbox):

From: Robert Cochran <robert-emacs <at> cochranmail.com>
To: Shane Hansen <shanemhansen <at> gmail.com>
Cc: 24041 <at> debbugs.gnu.org
Subject: Re: bug#24041: 25.1.50; xwidget + -nw mode gives segfault
Date: Fri, 19 Aug 2016 11:36:30 -0700

First, apologies for having left this alone this long. I meant to get to
it earlier.

Anyways, so the fix here is conceptually pretty simple: have a check in
place to ensure (display-graphic-p) returns non-nil before doing any
xwidgets stuff. Easy enough.

What I want to solicit feedback on before I write a patch is this: who
should be responsible for this check? Should the function provider (the
xwidget C 'library') check for the proper support? Or should that be
left to the user (the Lisp that calls the xwidget functions, in this
case `xwidget-webkit-browse-url`)?

Personal opinion is that xwidget should check: that way a Lisp caller
can't forget to do so. But I'm largely unaware of the conventions on how
to handle this, so I want to make sure I'm doing the correct thing
before I make a style mistake.

Thanks,
-- 
~Robert Cochran

GPG Fingerprint - E778 2DD4 FEA6 6A68 6F26  AD2D E5C3 EB36 4886 8871

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.