GNU bug report logs - #24034
25.0.95; shr-fill-line multiplies the number of images

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Katsumi Yamaoka <yamaoka <at> jpl.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#24034: closed (25.0.95; shr-fill-line multiplies the number
 of images)
Date: Wed, 20 Jul 2016 22:58:01 +0000

[Message part 1 (text/plain, inline)]

Your message dated Thu, 21 Jul 2016 07:57:12 +0900
with message-id <b4mbn1rvrxz.fsf <at> jpl.org>
and subject line Re: bug#24034: 25.0.95; shr-fill-line multiplies the number of images
has caused the debbugs.gnu.org bug report #24034,
regarding 25.0.95; shr-fill-line multiplies the number of images
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
24034: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=24034
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Katsumi Yamaoka <yamaoka <at> jpl.org>
To: bug-gnu-emacs <at> gnu.org
Subject: 25.0.95; shr-fill-line multiplies the number of images
Date: Wed, 20 Jul 2016 19:28:11 +0900

[Message part 3 (text/plain, inline)]

Hi,

If `gnus-inhibit-images' is t, shr shows the alt text of an image
in the article buffer.  If the alt text is long, `shr-fill-line'
devides it into two or more lines, and each line will get to
have a link to the image individually.  In that case, those
number of images will be displayed when a user invokes the WDW
command (gnus-article-show-images) even if there should be only
a single image.

The cause of this problem is that `shr-fill-line' divides not
only the alt text but also the `image-url' text property.  So,
I'd like to install the following change.  This is the right
fix, isn't it?

Regards,

[Message part 4 (text/x-patch, inline)]

--- shr.el~	2016-03-21 22:00:40.983451400 +0000
+++ shr.el	2016-07-20 10:26:30.487350400 +0000
@@ -636,13 +636,12 @@
       ;; Success; continue.
       (when (= (preceding-char) ?\s)
 	(delete-char -1))
-      (let ((face (get-text-property (point) 'face))
+      (let ((props (text-properties-at (point)))
 	    (background-start (point)))
 	(insert "\n")
 	(shr-indent)
-	(when face
-	  (put-text-property background-start (point) 'face
-			     `,(shr-face-background face))))
+	(when props
+	  (add-text-properties background-start (point) props)))
       (setq start (point))
       (shr-vertical-motion shr-internal-width)
       (when (looking-at " $")

[Message part 5 (message/rfc822, inline)]

From: Katsumi Yamaoka <yamaoka <at> jpl.org>
To: larsi <at> gnus.org
Cc: 24034-done <at> debbugs.gnu.org
Subject: Re: bug#24034: 25.0.95; shr-fill-line multiplies the number of images
Date: Thu, 21 Jul 2016 07:57:12 +0900

On Wed, 20 Jul 2016 12:31:56 +0200, Lars Ingebrigtsen wrote:
> Katsumi Yamaoka <yamaoka <at> jpl.org> writes:

>> The cause of this problem is that `shr-fill-line' divides not
>> only the alt text but also the `image-url' text property.  So,
>> I'd like to install the following change.  This is the right
>> fix, isn't it?

> Yes, I think so.

Done.  Thanks.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.