GNU bug report logs - #24034
25.0.95; shr-fill-line multiplies the number of images

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 24034 in the body.
You can then email your comments to 24034 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Katsumi Yamaoka <yamaoka <at> jpl.org>
To: bug-gnu-emacs <at> gnu.org
Subject: 25.0.95; shr-fill-line multiplies the number of images
Date: Wed, 20 Jul 2016 19:28:11 +0900

[Message part 1 (text/plain, inline)]

Hi,

If `gnus-inhibit-images' is t, shr shows the alt text of an image
in the article buffer.  If the alt text is long, `shr-fill-line'
devides it into two or more lines, and each line will get to
have a link to the image individually.  In that case, those
number of images will be displayed when a user invokes the WDW
command (gnus-article-show-images) even if there should be only
a single image.

The cause of this problem is that `shr-fill-line' divides not
only the alt text but also the `image-url' text property.  So,
I'd like to install the following change.  This is the right
fix, isn't it?

Regards,

[Message part 2 (text/x-patch, inline)]

--- shr.el~	2016-03-21 22:00:40.983451400 +0000
+++ shr.el	2016-07-20 10:26:30.487350400 +0000
@@ -636,13 +636,12 @@
       ;; Success; continue.
       (when (= (preceding-char) ?\s)
 	(delete-char -1))
-      (let ((face (get-text-property (point) 'face))
+      (let ((props (text-properties-at (point)))
 	    (background-start (point)))
 	(insert "\n")
 	(shr-indent)
-	(when face
-	  (put-text-property background-start (point) 'face
-			     `,(shr-face-background face))))
+	(when props
+	  (add-text-properties background-start (point) props)))
       (setq start (point))
       (shr-vertical-motion shr-internal-width)
       (when (looking-at " $")

Message #8 received at 24034 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Katsumi Yamaoka <yamaoka <at> jpl.org>
Cc: 24034 <at> debbugs.gnu.org
Subject: Re: bug#24034: 25.0.95; shr-fill-line multiplies the number of images
Date: Wed, 20 Jul 2016 12:31:56 +0200

Katsumi Yamaoka <yamaoka <at> jpl.org> writes:

> The cause of this problem is that `shr-fill-line' divides not
> only the alt text but also the `image-url' text property.  So,
> I'd like to install the following change.  This is the right
> fix, isn't it?

Yes, I think so.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #13 received at 24034-done <at> debbugs.gnu.org (full text, mbox):

From: Katsumi Yamaoka <yamaoka <at> jpl.org>
To: larsi <at> gnus.org
Cc: 24034-done <at> debbugs.gnu.org
Subject: Re: bug#24034: 25.0.95; shr-fill-line multiplies the number of images
Date: Thu, 21 Jul 2016 07:57:12 +0900

On Wed, 20 Jul 2016 12:31:56 +0200, Lars Ingebrigtsen wrote:
> Katsumi Yamaoka <yamaoka <at> jpl.org> writes:

>> The cause of this problem is that `shr-fill-line' divides not
>> only the alt text but also the `image-url' text property.  So,
>> I'd like to install the following change.  This is the right
>> fix, isn't it?

> Yes, I think so.

Done.  Thanks.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.