GNU bug report logs - #23988
[PATCH] Remove FIXME to alias fboundp to symbol-function

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 23988 in the body.
You can then email your comments to 23988 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Robert Cochran <robert-emacs <at> cochranmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Remove FIXME to alias fboundp to symbol-function
Date: Thu, 14 Jul 2016 15:49:37 -0700

[Message part 1 (text/plain, inline)]

Hello bug-gnu-emacs,

As discussed in Bug#23957, the FIXME above fboundp suggesting to alias
it to symbol-function is considered too great a risk to backwards
compatibility. This patch removes the FIXME, so that other developers do
not waste their time on it.

Thanks,
~Robert Cochran

[0001-Remove-FIXME-to-alias-fboundp-to-symbol-function.patch (text/x-patch, attachment)]

Message #10 received at 23988 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Robert Cochran <robert-emacs <at> cochranmail.com>
Cc: 23988 <at> debbugs.gnu.org
Subject: Re: bug#23988: [PATCH] Remove FIXME to alias fboundp to
 symbol-function
Date: Fri, 15 Jul 2016 10:13:21 +0300

> From: Robert Cochran <robert-emacs <at> cochranmail.com>
> Date: Thu, 14 Jul 2016 15:49:37 -0700
> 
> As discussed in Bug#23957, the FIXME above fboundp suggesting to alias
> it to symbol-function is considered too great a risk to backwards
> compatibility. This patch removes the FIXME, so that other developers do
> not waste their time on it.

How about adding a comment there that summarizes the discussion in
that bug?  Perhaps someone will come up with a clever idea to overcome
the difficulties.

Thanks.

Message #13 received at 23988 <at> debbugs.gnu.org (full text, mbox):

From: Robert Cochran <robert-emacs <at> cochranmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 23988 <at> debbugs.gnu.org, Robert Cochran <robert-emacs <at> cochranmail.com>
Subject: Re: bug#23988: [PATCH] Remove FIXME to alias fboundp to
 symbol-function
Date: Fri, 15 Jul 2016 12:50:02 -0700

[Message part 1 (text/plain, inline)]

Eli Zaretskii <eliz <at> gnu.org> writes:

> How about adding a comment there that summarizes the discussion in
> that bug?  Perhaps someone will come up with a clever idea to overcome
> the difficulties.

That's a good point. I have attached a new patch that summarizes the
discussion.

Thanks,
~Robert Cochran

[0001-Expand-FIXME-near-definition-of-fboundp.patch (text/x-patch, attachment)]

Message #16 received at 23988 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Robert Cochran <robert-emacs <at> cochranmail.com>
Cc: 23988 <at> debbugs.gnu.org
Subject: Re: bug#23988: [PATCH] Remove FIXME to alias fboundp to
 symbol-function
Date: Sat, 16 Jul 2016 09:56:26 +0300

> From: Robert Cochran <robert-emacs <at> cochranmail.com>
> Cc: Robert Cochran <robert-emacs <at> cochranmail.com>,  23988 <at> debbugs.gnu.org
> Date: Fri, 15 Jul 2016 12:50:02 -0700
> 
> Eli Zaretskii <eliz <at> gnu.org> writes:
> 
> > How about adding a comment there that summarizes the discussion in
> > that bug?  Perhaps someone will come up with a clever idea to overcome
> > the difficulties.
> 
> That's a good point. I have attached a new patch that summarizes the
> discussion.

LGTM, thanks.  Can someone please push this to the emacs-25 branch?

Message #19 received at 23988 <at> debbugs.gnu.org (full text, mbox):

From: npostavs <at> users.sourceforge.net
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 23988 <at> debbugs.gnu.org, Robert Cochran <robert-emacs <at> cochranmail.com>
Subject: Re: bug#23988: [PATCH] Remove FIXME to alias fboundp to
 symbol-function
Date: Sat, 16 Jul 2016 21:44:11 -0400

tags 23988 fixed
close 23988 25.1
quit

Eli Zaretskii <eliz <at> gnu.org> writes:

>> From: Robert Cochran <robert-emacs <at> cochranmail.com>
>> Cc: Robert Cochran <robert-emacs <at> cochranmail.com>,  23988 <at> debbugs.gnu.org
>> Date: Fri, 15 Jul 2016 12:50:02 -0700
>> 
>> That's a good point. I have attached a new patch that summarizes the
>> discussion.
>
> LGTM, thanks.  Can someone please push this to the emacs-25 branch?

Pushed as 9356fe2 (fixed a missing double space).  I marked as
"Copyright-paperwork-exempt: yes", since in the Bug #23957 Robert said

> I understand that the FSF requires a copyright assignment for
> non-trivial patches made to Emacs [...]
> I am perfectly happy to do so, but require guidance on how
> to accomplish it. On that topic, how can I go about this process so that
> I automatically perform the appropriate assignments for each
> contribution?

You can fill out the form here with program name "Emacs", and send email
to the address it mentions:
http://git.savannah.gnu.org/gitweb/?p=gnulib.git;a=blob;f=doc/Copyright/request-assign.program;hb=HEAD

You'll receive further instructions (signing a document and such).

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.