GNU bug report logs - #23957
[PATCH] Make fboundp an alias for symbol-function

Previous Next

Full log

View this message in rfc822 format

From: Robert Cochran <robert-emacs <at> cochranmail.com>
To: 23957 <at> debbugs.gnu.org
Subject: bug#23957: [PATCH] Make fboundp an alias for symbol-function
Date: Tue, 12 Jul 2016 00:08:18 -0700

[Message part 1 (text/plain, inline)]

Hello bug-gnu-emacs,

I was looking through the C portions of the Emacs source for fun, and
noticed a FIXME. I've wanted to start hacking on Emacs, the C portions
in specific, so I jumped right in.

My patch, attached, does the following:

* The function definition in src/data.c for fboundp has been removed,
  along with the corresponding defsubr in syms_of_data, as suggested in
  the FIXME

* All places where Ffboundp is used in the C code has been replaced with
  Fsymbol_function

* A defalias form that makes fboundp an alias of symbol-function has
  been inserted into lisp/subr.el

* In lisp/emacs-lisp/byte-run.el, and also lisp/loadup.el before loading
  lisp/subr.el, all instances of fboundp have been replaced with
  symbol-function

* All other instances of fboundp have been left alone

For anyone interested, I have a copy of the Emacs repository with the
patch applied here:

https://gitlab.com/RobertCochran/emacs/tree/alias-fboundp

I understand that the FSF requires a copyright assignment for
non-trivial patches made to Emacs, and this is likely considered
non-trivial. I am perfectly happy to do so, but require guidance on how
to accomplish it. On that topic, how can I go about this process so that
I automatically perform the appropriate assignments for each
contribution?

Please do offer suggestions and improvements for any deficiency in my
patch.

Thanks,
~Robert Cochran

[0001-Make-fboundp-an-alias-for-symbol-function.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.