GNU bug report logs - #23938
Commit 237244bbd5ce753bcdf79634561de515bd76c687 broke display of composed characters on master

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Paul Eggert <eggert <at> cs.ucla.edu>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#23938: closed (Commit 237244bbd5ce753bcdf79634561de515bd76c687
 broke display of composed characters on master)
Date: Mon, 11 Jul 2016 14:21:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Mon, 11 Jul 2016 16:20:09 +0200
with message-id <5783AB19.3020706 <at> cs.ucla.edu>
and subject line Re: Commit 237244bbd5ce753bcdf79634561de515bd76c687 broke display of composed characters on master
has caused the debbugs.gnu.org bug report #23938,
regarding Commit 237244bbd5ce753bcdf79634561de515bd76c687 broke display of composed characters on master
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
23938: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=23938
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Clément Pit--Claudel <clement.pitclaudel <at> live.com>
To: bug-gnu-emacs <at> gnu.org
Cc: Paul Eggert <eggert <at> cs.ucla.edu>
Subject: Commit 237244bbd5ce753bcdf79634561de515bd76c687 broke display of
 composed characters on master
Date: Mon, 11 Jul 2016 01:33:38 +0200

[Message part 3 (text/plain, inline)]

Hi all,

Running the following in Emacs 24 and 25-rc pops a buffer displaying "bd". On master, it displays "b" and "d" on top of each other.

    (with-current-buffer (get-buffer-create "*test*")
      (erase-buffer)
      (fundamental-mode)
      (insert "test")
      (compose-region (point-min) (point-max) '(?b (Br . Bl) ?d))
      (pop-to-buffer (current-buffer)))

Bisecting points to the following commit:

    237244bbd5ce753bcdf79634561de515bd76c687 is the first bad commit
    commit 237244bbd5ce753bcdf79634561de515bd76c687
    Author: Paul Eggert <eggert <at> cs.ucla.edu>
    Date:   Mon May 30 16:09:25 2016 -0700

        Omit IF_LINT code that no longer seems needed

        Nowadays GCC is smarter, or the Emacs code has mutated, or both,
        and now is as good a time as any to remove uses of IF_LINT that
        now seem to be unnecessary.
        (...)

The small test case is courtesy of Artur; we both noticed the issue while using his (awesome) ‘nameless’ package; see https://github.com/Malabarba/Nameless/issues/15 for details on the issue that prompted the investigation.

Cheers,
Clément.

In GNU Emacs 25.1.50.1 (x86_64-unknown-linux-gnu, GTK+ Version 3.10.8)
 of 2016-06-26 built on clem-w50-mint
Repository revision: 431437b6593320dc5a7a8aac9c911c778a656117
Windowing system distributor 'The X.Org Foundation', version 11.0.11501000
System Description:	Linux Mint 17.3 Rosa

[signature.asc (application/pgp-signature, attachment)]

[Message part 5 (message/rfc822, inline)]

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: Clément Pit--Claudel <clement.pitclaudel <at> live.com>,
 23938-done <at> debbugs.gnu.org
Subject: Re: Commit 237244bbd5ce753bcdf79634561de515bd76c687 broke display of
 composed characters on master
Date: Mon, 11 Jul 2016 16:20:09 +0200

[Message part 6 (text/plain, inline)]

Thanks for tracking that bug down and for the reproducible test case. It 
was a typo in that refactoring commit; sorry about that. I installed the 
attached patch into master to fix things.

[0001-Fix-composition-bug-caused-by-off-by-1-typo.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.