GNU bug report logs - #23938
Commit 237244bbd5ce753bcdf79634561de515bd76c687 broke display of composed characters on master

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 23938 in the body.
You can then email your comments to 23938 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Clément Pit--Claudel <clement.pitclaudel <at> live.com>
To: bug-gnu-emacs <at> gnu.org
Cc: Paul Eggert <eggert <at> cs.ucla.edu>
Subject: Commit 237244bbd5ce753bcdf79634561de515bd76c687 broke display of
 composed characters on master
Date: Mon, 11 Jul 2016 01:33:38 +0200

[Message part 1 (text/plain, inline)]

Hi all,

Running the following in Emacs 24 and 25-rc pops a buffer displaying "bd". On master, it displays "b" and "d" on top of each other.

    (with-current-buffer (get-buffer-create "*test*")
      (erase-buffer)
      (fundamental-mode)
      (insert "test")
      (compose-region (point-min) (point-max) '(?b (Br . Bl) ?d))
      (pop-to-buffer (current-buffer)))

Bisecting points to the following commit:

    237244bbd5ce753bcdf79634561de515bd76c687 is the first bad commit
    commit 237244bbd5ce753bcdf79634561de515bd76c687
    Author: Paul Eggert <eggert <at> cs.ucla.edu>
    Date:   Mon May 30 16:09:25 2016 -0700

        Omit IF_LINT code that no longer seems needed

        Nowadays GCC is smarter, or the Emacs code has mutated, or both,
        and now is as good a time as any to remove uses of IF_LINT that
        now seem to be unnecessary.
        (...)

The small test case is courtesy of Artur; we both noticed the issue while using his (awesome) ‘nameless’ package; see https://github.com/Malabarba/Nameless/issues/15 for details on the issue that prompted the investigation.

Cheers,
Clément.

In GNU Emacs 25.1.50.1 (x86_64-unknown-linux-gnu, GTK+ Version 3.10.8)
 of 2016-06-26 built on clem-w50-mint
Repository revision: 431437b6593320dc5a7a8aac9c911c778a656117
Windowing system distributor 'The X.Org Foundation', version 11.0.11501000
System Description:	Linux Mint 17.3 Rosa

[signature.asc (application/pgp-signature, attachment)]

Message #10 received at 23938-done <at> debbugs.gnu.org (full text, mbox):

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: Clément Pit--Claudel <clement.pitclaudel <at> live.com>,
 23938-done <at> debbugs.gnu.org
Subject: Re: Commit 237244bbd5ce753bcdf79634561de515bd76c687 broke display of
 composed characters on master
Date: Mon, 11 Jul 2016 16:20:09 +0200

[Message part 1 (text/plain, inline)]

Thanks for tracking that bug down and for the reproducible test case. It 
was a typo in that refactoring commit; sorry about that. I installed the 
attached patch into master to fix things.

[0001-Fix-composition-bug-caused-by-off-by-1-typo.patch (text/x-patch, attachment)]

Message #13 received at 23938-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Clément Pit--Claudel <clement.pitclaudel <at> live.com>
Cc: eggert <at> cs.ucla.edu, 23938-done <at> debbugs.gnu.org
Subject: Re: bug#23938: Commit 237244bbd5ce753bcdf79634561de515bd76c687 broke
 display of composed characters on master
Date: Mon, 11 Jul 2016 17:21:20 +0300

> From: Clément Pit--Claudel <clement.pitclaudel <at> live.com>
> Date: Mon, 11 Jul 2016 01:33:38 +0200
> Cc: Paul Eggert <eggert <at> cs.ucla.edu>
> 
> Running the following in Emacs 24 and 25-rc pops a buffer displaying "bd". On master, it displays "b" and "d" on top of each other.
> 
>     (with-current-buffer (get-buffer-create "*test*")
>       (erase-buffer)
>       (fundamental-mode)
>       (insert "test")
>       (compose-region (point-min) (point-max) '(?b (Br . Bl) ?d))
>       (pop-to-buffer (current-buffer)))
> 
> Bisecting points to the following commit:
> 
>     237244bbd5ce753bcdf79634561de515bd76c687 is the first bad commit
>     commit 237244bbd5ce753bcdf79634561de515bd76c687
>     Author: Paul Eggert <eggert <at> cs.ucla.edu>
>     Date:   Mon May 30 16:09:25 2016 -0700
> 
>         Omit IF_LINT code that no longer seems needed
> 
>         Nowadays GCC is smarter, or the Emacs code has mutated, or both,
>         and now is as good a time as any to remove uses of IF_LINT that
>         now seem to be unnecessary.
>         (...)

Thanks, fixed.

Message #16 received at 23938-done <at> debbugs.gnu.org (full text, mbox):

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: Eli Zaretskii <eliz <at> gnu.org>,
 Clément Pit--Claudel <clement.pitclaudel <at> live.com>
Cc: 23938-done <at> debbugs.gnu.org
Subject: Re: bug#23938: Commit 237244bbd5ce753bcdf79634561de515bd76c687 broke
 display of composed characters on master
Date: Mon, 11 Jul 2016 16:36:19 +0200

On 07/11/2016 04:21 PM, Eli Zaretskii wrote:
> Thanks, fixed.

Amusingly enough, you and I independently installed exactly the same 
code patch, byte-for-byte, nearly simultaneously. There is no difference 
between commits 4ba2946369cb19dfeb258839add0658c742c12a1 and 
10cfb736e2d32bd2604dc93a979ce136473b5944, and Git silently merged the 
two when you merged your commit into master. I don't know whether to 
worry about our duplicative work or to re-tell the famous war story 
about Ritchie and Thompson; see, for example, page 4 of:

McIlroy MD. Remarks for Japan Prize award ceremony for Dennis Ritchie. 
2011-05-19, Murray Hill, NJ. http://www.cs.dartmouth.edu/~doug/dmr.pdf

Message #19 received at 23938 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Paul Eggert <eggert <at> cs.ucla.edu>
Cc: clement.pitclaudel <at> live.com, 23938 <at> debbugs.gnu.org
Subject: Re: bug#23938: Commit 237244bbd5ce753bcdf79634561de515bd76c687 broke
 display of composed characters on master
Date: Mon, 11 Jul 2016 18:04:36 +0300

> Cc: 23938-done <at> debbugs.gnu.org
> From: Paul Eggert <eggert <at> cs.ucla.edu>
> Date: Mon, 11 Jul 2016 16:36:19 +0200
> 
> On 07/11/2016 04:21 PM, Eli Zaretskii wrote:
> > Thanks, fixed.
> 
> Amusingly enough, you and I independently installed exactly the same 
> code patch, byte-for-byte, nearly simultaneously. There is no difference 
> between commits 4ba2946369cb19dfeb258839add0658c742c12a1 and 
> 10cfb736e2d32bd2604dc93a979ce136473b5944, and Git silently merged the 
> two when you merged your commit into master.

Yep.  It happens.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.