GNU bug report logs - #23785
Emacs 25: "Undo" overdoes things.

Previous Next

Full log

View this message in rfc822 format

From: phillip.lord <at> russet.org.uk (Phillip Lord)
To: "Stefan Monnier" <monnier <at> iro.umontreal.ca>
Cc: acm <at> muc.de, Eli Zaretskii <eliz <at> gnu.org>, 23785 <at> debbugs.gnu.org
Subject: bug#23785: Emacs 25: 'Undo' overdoes things.
Date: Mon, 20 Jun 2016 16:03:35 +0100

"Phillip Lord" <phillip.lord <at> russet.org.uk> writes:

> On Sat, June 18, 2016 8:52 pm, Stefan Monnier wrote:
>>> My concern is not with the behavior the proposed change intends to get
>>> us, the concern is with the unintended consequences of the change.  At
>>> this late stage, I'd like to keep the risk of unintended consequences to
>>> the minimum, unless we want this change so badly we agree to extend the
>>> pretesting by another month or two.
>>
>> Yes, that's the other side of the coin, indeed.
>
> So many possibilities!


So, final patch possibility -- this one, I think directly fixes the
problem -- it ensures that the changes in the buffer result in an
undoable change.

It's probably less efficient (cause the undo-list will be created, then
dumped), but is the most minimal change.

My suggestion: this patch goes to Emacs-25. And the previous patch
(which automatically adds an undo boundary to current-buffer regardless
of changes), goes to master.

Phil

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.