GNU bug report logs - #23769
25.0.95; Mode Line breakage in vc-git

Previous Next

Full log

Message #65 received at 23769 <at> debbugs.gnu.org (full text, mbox):

From: phillip.lord <at> russet.org.uk (Phillip Lord)
To: Dmitry Gutov <dgutov <at> yandex.ru>
Cc: 23769 <at> debbugs.gnu.org
Subject: Re: bug#23769: 25.0.95; Mode Line breakage in vc-git
Date: Thu, 16 Jun 2016 22:47:02 +0100

Dmitry Gutov <dgutov <at> yandex.ru> writes:

> On 06/16/2016 02:25 PM, Dmitry Gutov wrote:
>> If new arguments arise in favor of this, we
>> can do it, but so far unsetting GIT_DIR seems like the cheapest option.
>> Like this:
>
> Actually, this is better. The previous one broke vc-git. :)
>
> diff --git a/lisp/vc/vc-git.el b/lisp/vc/vc-git.el
> index f35c84d..2b827a3 100644
> --- a/lisp/vc/vc-git.el
> +++ b/lisp/vc/vc-git.el
> @@ -1451,6 +1451,7 @@ vc-git--call
>  	(coding-system-for-write
>           (or coding-system-for-write vc-git-commits-coding-system))
>  	(process-environment (cons "PAGER=" process-environment)))
> +    (setenv "GIT_DIR" nil)
>      (apply 'process-file vc-git-program nil buffer nil command args)))
>
>  (defun vc-git--out-ok (command &rest args)

This just sets GIT_DIR nil globally right? It does appear to work, but
is it not a bit blunt.

Phil

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.