GNU bug report logs - #23745
25.0.94; Org: (pop-to-mark-command) doesn't work when using (org-open-at-point) to visit a same-file link

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#23745: closed (25.0.94; Org: (pop-to-mark-command) doesn't
 work when using (org-open-at-point) to visit a same-file link)
Date: Tue, 27 Feb 2018 00:11:01 +0000

[Message part 1 (text/plain, inline)]

Your message dated Tue, 27 Feb 2018 01:10:48 +0100
with message-id <87tvu3xpfb.fsf <at> nicolasgoaziou.fr>
and subject line Re: bug#23745: 25.0.94; Org: (pop-to-mark-command) doesn't work when using (org-open-at-point) to visit a same-file link
has caused the debbugs.gnu.org bug report #23745,
regarding 25.0.94; Org: (pop-to-mark-command) doesn't work when using (org-open-at-point) to visit a same-file link
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
23745: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=23745
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Dima Kogan <dima <at> secretsauce.net>
To: bug-gnu-emacs <at> gnu.org
Subject: 25.0.94; Org: (pop-to-mark-command) doesn't work when using
 (org-open-at-point) to visit a same-file link
Date: Fri, 10 Jun 2016 17:05:09 -0700

Hi. Consider this org-mode file:

=====================
* aaaa
bbbbb

* cccc
[[aaaa]]
=====================

With the point at the [[aaaa]] link, I can visit the aaaa heading with
C-c C-o (org-open-at-point), and I can go back to where I was with the
org-specific C-c & (org-mark-ring-goto). But I should also be able to go
back with C-u C-SPC (effectively pop-to-mark-command), since that works
for inside-the-same-buffer jumps in all other emacs context, including
non-org ones. I suspect all we would need to do is to
(push-mark-command) before we jump in (org-open-at-point). Is this
simply forgotten, or was it omitted on purpose? If the former, I'll post
a patch.

dima

[Message part 3 (message/rfc822, inline)]

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Dima Kogan <dima <at> secretsauce.net>
Cc: 23745-done <at> debbugs.gnu.org
Subject: Re: bug#23745: 25.0.94;
 Org: (pop-to-mark-command) doesn't work when using
 (org-open-at-point) to visit a same-file link
Date: Tue, 27 Feb 2018 01:10:48 +0100

Hello,

Dima Kogan <dima <at> secretsauce.net> writes:

> Hi. Consider this org-mode file:
>
> =====================
> * aaaa
> bbbbb
>
> * cccc
> [[aaaa]]
> =====================
>
> With the point at the [[aaaa]] link, I can visit the aaaa heading with
> C-c C-o (org-open-at-point), and I can go back to where I was with the
> org-specific C-c & (org-mark-ring-goto). But I should also be able to go
> back with C-u C-SPC (effectively pop-to-mark-command), since that works
> for inside-the-same-buffer jumps in all other emacs context, including
> non-org ones. I suspect all we would need to do is to
> (push-mark-command) before we jump in (org-open-at-point). Is this
> simply forgotten, or was it omitted on purpose? If the former, I'll post
> a patch.

Fixed.

Now `org-mark-ring-push' also calls `push-mark'. Ultimately, I think the
latter should replace former, although navigation with Org dedicated
mark ring is still slightly easier (e.g., no distinction between global
and local rings).

Thank you.

Regards,

-- 
Nicolas Goaziou                                                0x80A93738

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.