GNU bug report logs - #23745
25.0.94; Org: (pop-to-mark-command) doesn't work when using (org-open-at-point) to visit a same-file link

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 23745 in the body.
You can then email your comments to 23745 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Dima Kogan <dima <at> secretsauce.net>
To: bug-gnu-emacs <at> gnu.org
Subject: 25.0.94; Org: (pop-to-mark-command) doesn't work when using
 (org-open-at-point) to visit a same-file link
Date: Fri, 10 Jun 2016 17:05:09 -0700

Hi. Consider this org-mode file:

=====================
* aaaa
bbbbb

* cccc
[[aaaa]]
=====================

With the point at the [[aaaa]] link, I can visit the aaaa heading with
C-c C-o (org-open-at-point), and I can go back to where I was with the
org-specific C-c & (org-mark-ring-goto). But I should also be able to go
back with C-u C-SPC (effectively pop-to-mark-command), since that works
for inside-the-same-buffer jumps in all other emacs context, including
non-org ones. I suspect all we would need to do is to
(push-mark-command) before we jump in (org-open-at-point). Is this
simply forgotten, or was it omitted on purpose? If the former, I'll post
a patch.

dima

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Rasmus <rasmus <at> gmx.us>
To: bug-gnu-emacs <at> gnu.org
Cc: emacs-orgmode <at> gnu.org
Subject: Re: bug#23745: 25.0.94;
 Org: (pop-to-mark-command) doesn't work when using
 (org-open-at-point) to visit a same-file link
Date: Sat, 11 Jun 2016 13:37:37 +0200

Hi Dima,

Thanks for the report.

Dima Kogan <dima <at> secretsauce.net> writes:

> =====================
> * aaaa
> bbbbb
>
> * cccc
> [[aaaa]]
> =====================
>
> With the point at the [[aaaa]] link, I can visit the aaaa heading with
> C-c C-o (org-open-at-point), and I can go back to where I was with the
> org-specific C-c & (org-mark-ring-goto). But I should also be able to go
> back with C-u C-SPC (effectively pop-to-mark-command), since that works
> for inside-the-same-buffer jumps in all other emacs context, including
> non-org ones. I suspect all we would need to do is to
> (push-mark-command) before we jump in (org-open-at-point). Is this
> simply forgotten, or was it omitted on purpose? If the former, I'll post
> a patch.

I think you are right; your description of behavior would be consistent.
Note that once I click C-c & at "* aaaa" and thus return to the link
"[[aaaa]]" I can pop the mark to go back to "* aaaa" but the reverse is
not possible.

A fix for this would be appreciated.

Thanks,
Rasmus

-- 
Send from my Emacs

Message #13 received at 23745-done <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Dima Kogan <dima <at> secretsauce.net>
Cc: 23745-done <at> debbugs.gnu.org
Subject: Re: bug#23745: 25.0.94;
 Org: (pop-to-mark-command) doesn't work when using
 (org-open-at-point) to visit a same-file link
Date: Tue, 27 Feb 2018 01:10:48 +0100

Hello,

Dima Kogan <dima <at> secretsauce.net> writes:

> Hi. Consider this org-mode file:
>
> =====================
> * aaaa
> bbbbb
>
> * cccc
> [[aaaa]]
> =====================
>
> With the point at the [[aaaa]] link, I can visit the aaaa heading with
> C-c C-o (org-open-at-point), and I can go back to where I was with the
> org-specific C-c & (org-mark-ring-goto). But I should also be able to go
> back with C-u C-SPC (effectively pop-to-mark-command), since that works
> for inside-the-same-buffer jumps in all other emacs context, including
> non-org ones. I suspect all we would need to do is to
> (push-mark-command) before we jump in (org-open-at-point). Is this
> simply forgotten, or was it omitted on purpose? If the former, I'll post
> a patch.

Fixed.

Now `org-mark-ring-push' also calls `push-mark'. Ultimately, I think the
latter should replace former, although navigation with Org dedicated
mark ring is still slightly easier (e.g., no distinction between global
and local rings).

Thank you.

Regards,

-- 
Nicolas Goaziou                                                0x80A93738

Message #16 received at 23745 <at> debbugs.gnu.org (full text, mbox):

From: Samuel Wales <samologist <at> gmail.com>
To: 23745 <at> debbugs.gnu.org, mail <at> nicolasgoaziou.fr, dima <at> secretsauce.net
Cc: 23745-done <at> debbugs.gnu.org
Subject: Re: [O] bug#23745: 25.0.94; Org: (pop-to-mark-command) doesn't work
 when using (org-open-at-point) to visit a same-file link
Date: Mon, 26 Feb 2018 19:12:43 -0700

quite useful to have this for reference in the org mailing list, as we
are discussing it.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.