GNU bug report logs - #23644
bug with context greater than 0

Previous Next

To reply to this bug, email your comments to 23644 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Claude <lamy.claude <at> gmail.com>
To: bug-diffutils <at> gnu.org
Subject: bug with context greater than 0
Date: Sat, 28 May 2016 23:51:07 -0400

[Message part 1 (text/plain, inline)]

Hi

I think I have found a bug with diff when context is greater then zero.
I have included the two files and the diff file produced.

This diff file has been generated with version 2.7 running on Windows 7.
The same behavior have been noticed with version 3.3 running on linux.

My command was  diff -C 2 original.txt modified.txt

Now looking on the produced diff file, I had two additions.  At the 
beggining and at the end of my modified file.

*** Original.txt    Sat May 28 09:07:08 2016
--- Modified.txt    Sat May 28 09:07:18 2016
***************
*** 1,2 ****
--- 1,8 ----
+ This is an important
+ notice! It should
+ therefore be located at
+ the beginning of this
+ document!
+
  This part of the
  document has stayed the
***************
*** 6,20 ****
  change.  Otherwise, that
  would not be helping to
! compress the size of the
! changes.
!
! This paragraph contains
! text that is outdated.
! It will be deleted in the
! near future.

  allo
  It is important to spell
! check this dokument. On
  the other hand, a
  misspelled word isn't
--- 12,20 ----
  change.  Otherwise, that
  would not be helping to
! compress anything.

  allo
  It is important to spell
! check this document. On
  the other hand, a
  misspelled word isn't
***************
*** 24,25 ****
--- 24,29 ----
  be changed. Things can
  be added after it.
+
+ This paragraph contains
+ important new additions
+ to this document.

Notice that  on the original file diff specifies that it will list 
context lines content 1,2 for the
beginning and 24,25 for the end, but the lines are not displayed in the 
diff block description.
The two context lines appear for the modified files for the same 
differences though.
Also, the two context lines are displayed, at top, and at bottom when 
differences occure in the middle of the file.

I have no corrections for this bug.  I haven't looked at the code.

Thanks

[Original.txt (text/plain, attachment)]

[differences-context-2.txt (text/plain, attachment)]

[Modified.txt (text/plain, attachment)]

Message #8 received at 23644 <at> debbugs.gnu.org (full text, mbox):

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: Claude <lamy.claude <at> gmail.com>, 23644 <at> debbugs.gnu.org
Subject: Re: [bug-diffutils] bug#23644: bug with context greater than 0
Date: Sat, 28 May 2016 23:46:53 -0700

Claude wrote:
> Notice that  on the original file diff specifies that it will list context lines
> content 1,2 for the
> beginning and 24,25 for the end, but the lines are not displayed in the diff
> block description.

Yes they are; they are common context, e.g., lines 24-25 of the first file are 
the same as lines 24-25 of the second file, so they are displayed once with 
leading ' '.

> The two context lines appear for the modified files for the same differences
> though.
> Also, the two context lines are displayed, at top, and at bottom when
> differences occure in the middle of the file.

Sorry, I don't see the bugs here; the output looks OK to me.

Message #11 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Eric Deplagne <Eric <at> Deplagne.name>
To: bug-diffutils <at> gnu.org
Subject: Re: [bug-diffutils] bug#23644: bug#23644: bug with context greater
 than 0
Date: Sun, 29 May 2016 21:50:30 +0200

[Message part 1 (text/plain, inline)]

On Sat, 28 May 2016 23:46:53 -0700, Paul Eggert wrote:
> Claude wrote:
>> Notice that  on the original file diff specifies that it will list context lines
>> content 1,2 for the
>> beginning and 24,25 for the end, but the lines are not displayed in the diff
>> block description.
>
> Yes they are; they are common context, e.g., lines 24-25 of the first 
> file are the same as lines 24-25 of the second file, so they are 
> displayed once with leading ' '.
>
>> The two context lines appear for the modified files for the same differences
>> though.
>> Also, the two context lines are displayed, at top, and at bottom when
>> differences occure in the middle of the file.
>
> Sorry, I don't see the bugs here; the output looks OK to me.

  Same for me.

  Third chunk beginning line 24 in both files
  at first seemed odd to me,
  but there are as many less lines in chunk 2 
  than there are more lines in chunk 1.

  So everything is fine.

-- 
  Eric Deplagne

[signature.asc (application/pgp-signature, inline)]

Message #14 received at 23644 <at> debbugs.gnu.org (full text, mbox):

From: Jim Meyering <jim <at> meyering.net>
To: Paul Eggert <eggert <at> cs.ucla.edu>
Cc: 23644 <at> debbugs.gnu.org, Claude <lamy.claude <at> gmail.com>
Subject: Re: [bug-diffutils] bug#23644: bug#23644: bug with context greater
 than 0
Date: Tue, 31 May 2016 07:53:58 -0700

tags 23644 notabug
close 23644
thanks

On Sat, May 28, 2016 at 11:46 PM, Paul Eggert <eggert <at> cs.ucla.edu> wrote:
> Claude wrote:
>>
>> Notice that  on the original file diff specifies that it will list context
>> lines
>> content 1,2 for the
>> beginning and 24,25 for the end, but the lines are not displayed in the
>> diff
>> block description.
>
>
> Yes they are; they are common context, e.g., lines 24-25 of the first file
> are the same as lines 24-25 of the second file, so they are displayed once
> with leading ' '.
>
>> The two context lines appear for the modified files for the same
>> differences
>> though.
>> Also, the two context lines are displayed, at top, and at bottom when
>> differences occure in the middle of the file.
>
> Sorry, I don't see the bugs here; the output looks OK to me.

Same here, so I'm marking this auto-created 'issue' as a non-bug and closing it.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.