GNU bug report logs - #23632
25.1.50; Gratuitous undo boundary in latex-insert-block

Previous Next

Package: emacs;

Reported by: Chong Yidong <cyd <at> gnu.org>

Date: Fri, 27 May 2016 15:12:02 UTC

Severity: minor

Tags: patch

Found in version 25.1.50

Fixed in version 25.1

Done: phillip.lord <at> russet.org.uk (Phillip Lord)

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: "Phillip Lord" <phillip.lord <at> russet.org.uk>
To: "Stefan Monnier" <monnier <at> iro.umontreal.ca>
Cc: Chong Yidong <cyd <at> gnu.org>, 23632 <at> debbugs.gnu.org, Phillip Lord <phillip.lord <at> russet.org.uk>
Subject: bug#23632: 25.1.50; Gratuitous undo boundary in latex-insert-block
Date: Sat, 4 Jun 2016 18:17:57 +0100
On Sat, June 4, 2016 5:49 pm, Stefan Monnier wrote:
>> Yes. This is assuming that commands *both* change recursion depth *and*
>>  change a buffer.
>
> Yes, it's like a fairly rare occurrence, where a command does both:
> - modify some buffer(s)
> - exit a recursive edit
> So maybe we can live without paying attention to it.
>
>
>>>> -- once when we capture the undoable changes (which happens
>>>> often) and once on at the end of each command.
>>> Right.  I see no need for any changes there.
>>>
>> Really? I have to know the recursion depth at this point
>>
>
> No, let-bind the var to nil around each recursive edit should take care
> of "everything" so you don't need to change anything else (including, non
> need to pay any attention to the recursion depth).
>
>> To be clear, though, to do this I need to augment recursive-edit in C?
>> I
>> need the let binding to last the life of the recursive edit?
>
> That's right.  A call to `specbind' at the right spot might even be all
> it takes.

Okay, I will take a good look -- I've not done this before, but can try.

I guess "recursive-edit" is the only way to enter a recursive edit?






This bug report was last modified 8 years and 350 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.