GNU bug report logs - #23631
25.0.94; Directories in completion-ignored-extensions not ignored

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 23631 in the body.
You can then email your comments to 23631 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: bug-gnu-emacs <at> gnu.org
Subject: 25.0.94; Directories in completion-ignored-extensions not ignored
Date: Fri, 27 May 2016 15:32:07 +0300

Evaluate something like

(file-name-all-completions "" "~/.emacs.d/")

On my machine, this returns a list which includes ".git/". It should
not, however, because ".git/" is in completion-ignored-extensions.

Not 100% sure it's supposed to work, because it seems broken at least
since 24.2 (maybe longer).

in GNU Emacs 25.0.94.2 (x86_64-pc-linux-gnu, GTK+ Version 3.18.9)
 of 2016-05-25 built on axl
Repository revision: 897fb6fa49d5ffc85f0a796e7414a43ef05ad096
Windowing system distributor 'The X.Org Foundation', version 11.0.11803000
System Description:	Ubuntu 16.04 LTS

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: thierry <thierry.volpiatto <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: Re: bug#23631: 25.0.94; Directories in completion-ignored-extensions
 not ignored
Date: Fri, 27 May 2016 14:51:56 +0200

Le 27/05/2016 14:32, Dmitry Gutov a écrit :
> Evaluate something like
> 
> (file-name-all-completions "" "~/.emacs.d/")
> 
> On my machine, this returns a list which includes ".git/". It should
> not, however, because ".git/" is in completion-ignored-extensions.
> 
> Not 100% sure it's supposed to work, because it seems broken at least
> since 24.2 (maybe longer).

I don't think it's supposed to filter ignored extensions, if is was the
case how one can list all the files in a directory using e.g
directory-files-recursively ?

IMO the filtering should happen (or not) in the application that use
file-name-all-completions.

I would be annoyed in my own applications if you modify
file-name-all-completion to handle ignored extensions.

So please don't do that.

Thanks.

> in GNU Emacs 25.0.94.2 (x86_64-pc-linux-gnu, GTK+ Version 3.18.9)
>  of 2016-05-25 built on axl
> Repository revision: 897fb6fa49d5ffc85f0a796e7414a43ef05ad096
> Windowing system distributor 'The X.Org Foundation', version 11.0.11803000
> System Description:	Ubuntu 16.04 LTS
> 
> 
> 
> 

Message #11 received at 23631 <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: thierry <thierry.volpiatto <at> gmail.com>, 23631 <at> debbugs.gnu.org
Subject: Re: bug#23631: 25.0.94; Directories in completion-ignored-extensions
 not ignored
Date: Fri, 27 May 2016 15:58:14 +0300

On 05/27/2016 03:51 PM, thierry wrote:

> I don't think it's supposed to filter ignored extensions,

file-name-all-completions's docstring says it does.

> if is was the
> case how one can list all the files in a directory using e.g
> directory-files-recursively ?

You can bind the relevant variables to nil locally.

Message #14 received at 23631 <at> debbugs.gnu.org (full text, mbox):

From: Thierry Volpiatto <thierry.volpiatto <at> gmail.com>
To: Dmitry Gutov <dgutov <at> yandex.ru>
Cc: 23631 <at> debbugs.gnu.org
Subject: Re: bug#23631: 25.0.94;
 Directories in completion-ignored-extensions not ignored
Date: Fri, 27 May 2016 15:05:26 +0200

Dmitry Gutov <dgutov <at> yandex.ru> writes:

> On 05/27/2016 03:51 PM, thierry wrote:
>
>> I don't think it's supposed to filter ignored extensions,
>
> file-name-all-completions's docstring says it does.

Not in emacs-24.5, so applications created before emacs-25 use this
behavior, i.e ignored extensions not handled.
And it is good like this.

>> if is was the
>> case how one can list all the files in a directory using e.g
>> directory-files-recursively ?
>
> You can bind the relevant variables to nil locally.

Of course.

-- 
Thierry

Message #17 received at 23631 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Dmitry Gutov <dgutov <at> yandex.ru>
Cc: 23631 <at> debbugs.gnu.org
Subject: Re: bug#23631: 25.0.94;
 Directories in completion-ignored-extensions not ignored
Date: Fri, 27 May 2016 16:11:58 +0300

> From: Dmitry Gutov <dgutov <at> yandex.ru>
> Date: Fri, 27 May 2016 15:32:07 +0300
> 
> Evaluate something like
> 
> (file-name-all-completions "" "~/.emacs.d/")
> 
> On my machine, this returns a list which includes ".git/". It should
> not, however, because ".git/" is in completion-ignored-extensions.

This works as designed: completion-ignored-extensions only affects
file-name-completion, but not file-name-all-completions.  I've just
pushed a fix for the doc string of file-name-all-completions.  (The
ELisp manual correctly says that the variable has no effect in your
case.)

Message #22 received at 23631-done <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 23631-done <at> debbugs.gnu.org
Subject: Re: bug#23631: 25.0.94; Directories in completion-ignored-extensions
 not ignored
Date: Fri, 27 May 2016 16:53:25 +0300

On 05/27/2016 04:11 PM, Eli Zaretskii wrote:

> This works as designed: completion-ignored-extensions only affects
> file-name-completion, but not file-name-all-completions.  I've just
> pushed a fix for the doc string of file-name-all-completions.

I see, thanks!

> (The
> ELisp manual correctly says that the variable has no effect in your
> case.)

That kind of illustrates the problem of divergence between different 
kinds of documentation.

Message #25 received at 23631 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Dmitry Gutov <dgutov <at> yandex.ru>
Cc: 23631 <at> debbugs.gnu.org
Subject: Re: bug#23631: 25.0.94; Directories in completion-ignored-extensions
 not ignored
Date: Fri, 27 May 2016 17:06:53 +0300

> Cc: 23631-done <at> debbugs.gnu.org
> From: Dmitry Gutov <dgutov <at> yandex.ru>
> Date: Fri, 27 May 2016 16:53:25 +0300
> 
> On 05/27/2016 04:11 PM, Eli Zaretskii wrote:
> 
> > (The
> > ELisp manual correctly says that the variable has no effect in your
> > case.)
> 
> That kind of illustrates the problem of divergence between different 
> kinds of documentation.

Yes, nothing new here.

Message #28 received at 23631 <at> debbugs.gnu.org (full text, mbox):

From: Michael Albinus <michael.albinus <at> gmx.de>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 23631 <at> debbugs.gnu.org, Dmitry Gutov <dgutov <at> yandex.ru>
Subject: Re: bug#23631: 25.0.94;
 Directories in completion-ignored-extensions not ignored
Date: Fri, 27 May 2016 17:48:57 +0200

Eli Zaretskii <eliz <at> gnu.org> writes:

>> Evaluate something like
>> 
>> (file-name-all-completions "" "~/.emacs.d/")
>> 
>> On my machine, this returns a list which includes ".git/". It should
>> not, however, because ".git/" is in completion-ignored-extensions.
>
> This works as designed: completion-ignored-extensions only affects
> file-name-completion, but not file-name-all-completions.  I've just
> pushed a fix for the doc string of file-name-all-completions.  (The
> ELisp manual correctly says that the variable has no effect in your
> case.)

Tramp does not honor `completion-ignored-extensions'. I will fix it, but
it shall go into the master branch then. Not important enough for
emacs-25.

Best regards, Michael.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.