GNU bug report logs - #23607
Please apply this patched function to package.el in Emacs 25.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 23607 in the body.
You can then email your comments to 23607 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Robert Weiner <rswgnu <at> gmail.com>
To: Tom Tromey <tromey <at> redhat.com>, Daniel Hackney <dan <at> haxney.org>
Cc: bug-gnu-emacs <at> gnu.org, emacs-devel <emacs-devel <at> gnu.org>
Subject: Please apply this patched function to package.el in Emacs 25.
Date: Mon, 23 May 2016 19:11:07 -0400

[Message part 1 (text/plain, inline)]

Replacing this function in package.el allows for correct generation of the
<package>-autoloads.el file for packages that have .el files in multiple
subdirectories.  The only thing changed is the line with 'apply' in it.  It
ignores symlinks to directories in case there are any.  It is a simple
change.  I hope you like it.

This is important for larger packages such as my forthcoming Hyperbole
package which includes a 2nd directory of code.


(defun package-generate-autoloads (name pkg-dir)
  (let* ((auto-name (format "%s-autoloads.el" name))
         ;;(ignore-name (concat name "-pkg.el"))
         (generated-autoload-file (expand-file-name auto-name pkg-dir))
         ;; Silence `autoload-generate-file-autoloads'.
         (noninteractive inhibit-message)
         (backup-inhibited t)
         (version-control 'never))
    (package-autoload-ensure-default-file generated-autoload-file)
    (apply #'update-directory-autoloads pkg-dir
  (delq nil (mapcar (lambda (f) (and (file-directory-p f)
     (not (file-symlink-p f)) f))
    (directory-files pkg-dir t "[a-zA-Z].*" nil))))
    (let ((buf (find-buffer-visiting generated-autoload-file)))
      (when buf (kill-buffer buf)))
    auto-name))

[Message part 2 (text/html, inline)]

Message #12 received at 23607 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Robert Weiner <rswgnu <at> gmail.com>
Cc: Tom Tromey <tromey <at> redhat.com>, 23607 <at> debbugs.gnu.org,
 Daniel Hackney <dan <at> haxney.org>
Subject: Re: bug#23607: Please apply this patched function to package.el in
 Emacs 25.
Date: Wed, 20 Jul 2016 22:05:09 -0400

> Replacing this function in package.el allows for correct generation of the
> <package>-autoloads.el file for packages that have .el files in multiple
> subdirectories.

FWIW, I think this will break the dash package which includes
a dev/ert.el file with autoload cookies in it and those shouldn't be
placed into the dash-autoloads.el file.


        Stefan


PS: Please send it as a patch so we can see what changed without having
to try and guess.

Message #15 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Clément Pit--Claudel <clement.pit <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Cc: Stefan Monnier <monnier <at> iro.umontreal.ca>
Subject: Re: bug#23607: Please apply this patched function to package.el in
 Emacs 25.
Date: Wed, 20 Jul 2016 23:50:25 -0400

[Message part 1 (text/plain, inline)]

On 2016-07-20 22:05, Stefan Monnier wrote:
> FWIW, I think this will break the dash package which includes
> a dev/ert.el file with autoload cookies in it and those shouldn't be
> placed into the dash-autoloads.el file.

What kind of breakage do you have in mind?

[signature.asc (application/pgp-signature, attachment)]

Message #18 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Clément Pit--Claudel <clement.pit <at> gmail.com>
Cc: bug-gnu-emacs <at> gnu.org
Subject: Re: bug#23607: Please apply this patched function to package.el in
 Emacs 25.
Date: Thu, 21 Jul 2016 00:40:40 -0400

>> FWIW, I think this will break the dash package which includes
>> a dev/ert.el file with autoload cookies in it and those shouldn't be
>> placed into the dash-autoloads.el file.
> What kind of breakage do you have in mind?

The autoloads for the real ert.el will be overridden by those from
dash-autoloads.el which will say that for example that ert-deftest
should be autoloaded from "dev/ert.el".


        Stefan

Message #21 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Clément Pit--Claudel <clement.pit <at> gmail.com>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: bug-gnu-emacs <at> gnu.org
Subject: Re: bug#23607: Please apply this patched function to package.el in
 Emacs 25.
Date: Thu, 21 Jul 2016 01:02:55 -0400

[Message part 1 (text/plain, inline)]

On 2016-07-21 00:40, Stefan Monnier wrote:
>>> FWIW, I think this will break the dash package which includes
>>> a dev/ert.el file with autoload cookies in it and those shouldn't be
>>> placed into the dash-autoloads.el file.
>> What kind of breakage do you have in mind?
> 
> The autoloads for the real ert.el will be overridden by those from
> dash-autoloads.el which will say that for example that ert-deftest
> should be autoloaded from "dev/ert.el".

I see; I didn't realize dash had their own copy of ert... I wonder why they do.
But you're right, this is definitely an issue.

Clément.

[signature.asc (application/pgp-signature, attachment)]

Message #24 received at 23607 <at> debbugs.gnu.org (full text, mbox):

From: Robert Weiner <rsw <at> gnu.org>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: Tom Tromey <tromey <at> redhat.com>, 23607 <at> debbugs.gnu.org,
 Daniel Hackney <dan <at> haxney.org>
Subject: Re: bug#23607: Please apply this patched function to package.el in
 Emacs 25.
Date: Thu, 21 Jul 2016 11:47:49 -0400

[Message part 1 (text/plain, inline)]

On Wed, Jul 20, 2016 at 10:05 PM, Stefan Monnier <monnier <at> iro.umontreal.ca>
wrote:
>> Replacing this function in package.el allows for correct generation of
the
>> <package>-autoloads.el file for packages that have .el files in multiple
>> subdirectories.
>
> FWIW, I think this will break the dash package which includes
> a dev/ert.el file with autoload cookies in it and those shouldn't be
> placed into the dash-autoloads.el file.
>
>
>         Stefan
>
>
> PS: Please send it as a patch so we can see what changed without having
> to try and guess.

Here is the patch.  -- Bob


*** package-orig.el 2016-05-17 12:16:33.000000000 -0400
--- package.el 2016-06-15 14:43:46.000000000 -0400
***************
*** 916,928 ****
           (backup-inhibited t)
           (version-control 'never))
      (package-autoload-ensure-default-file generated-autoload-file)
!     (update-directory-autoloads pkg-dir)
      (let ((buf (find-buffer-visiting generated-autoload-file)))
        (when buf (kill-buffer buf)))
      auto-name))

  (defun package--make-autoloads-and-stuff (pkg-desc pkg-dir)
   "Generate autoloads, description file, etc.. for PKG-DESC installed at
PKG-DIR."
    (package-generate-autoloads (package-desc-name pkg-desc) pkg-dir)
    (let ((desc-file (expand-file-name (package--description-file pkg-dir)
                                       pkg-dir)))
--- 913,929 ----
           (backup-inhibited t)
           (version-control 'never))
      (package-autoload-ensure-default-file generated-autoload-file)
!     (apply #'update-directory-autoloads pkg-dir
!   (delq nil (mapcar (lambda (f) (and (file-directory-p f)
!      (not (file-symlink-p f))
!      f))
!     (directory-files pkg-dir t "[a-zA-Z].*" nil))))
      (let ((buf (find-buffer-visiting generated-autoload-file)))
        (when buf (kill-buffer buf)))
      auto-name))

  (defun package--make-autoloads-and-stuff (pkg-desc pkg-dir)
   "Generate autoloads, description file, etc.. for PKG-DESC installed at
PKG-DIR."
    (package-generate-autoloads (package-desc-name pkg-desc) pkg-dir)
    (let ((desc-file (expand-file-name (package--description-file pkg-dir)
                                       pkg-dir)))

[Message part 2 (text/html, inline)]

Message #27 received at 23607 <at> debbugs.gnu.org (full text, mbox):

From: phillip.lord <at> russet.org.uk (Phillip Lord)
To: Clément Pit--Claudel <clement.pit <at> gmail.com>
Cc: 23607 <at> debbugs.gnu.org, Stefan Monnier <monnier <at> iro.umontreal.ca>
Subject: Re: bug#23607: Please apply this patched function to package.el in
 Emacs 25.
Date: Sun, 24 Jul 2016 16:58:43 +0100

Clément Pit--Claudel <clement.pit <at> gmail.com> writes:

> On 2016-07-21 00:40, Stefan Monnier wrote:
>>>> FWIW, I think this will break the dash package which includes
>>>> a dev/ert.el file with autoload cookies in it and those shouldn't be
>>>> placed into the dash-autoloads.el file.
>>> What kind of breakage do you have in mind?
>> 
>> The autoloads for the real ert.el will be overridden by those from
>> dash-autoloads.el which will say that for example that ert-deftest
>> should be autoloaded from "dev/ert.el".
>
> I see; I didn't realize dash had their own copy of ert... I wonder why they do.
> But you're right, this is definitely an issue.

Dash isn't the only package to do this. I've also seen package.el
packaged in other places. Mostly, I think, to support backward
compatability, I think.

Why are dev files being packaged, though? At the moment, I don't think
that they should be.

Phil

Message #30 received at 23607 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 23607 <at> debbugs.gnu.org,
 Clément Pit--Claudel <clement.pit <at> gmail.com>
Subject: Re: bug#23607: Please apply this patched function to package.el in
 Emacs 25.
Date: Tue, 15 Sep 2020 17:56:39 +0200

Stefan Monnier <monnier <at> iro.umontreal.ca> writes:

>>> FWIW, I think this will break the dash package which includes
>>> a dev/ert.el file with autoload cookies in it and those shouldn't be
>>> placed into the dash-autoloads.el file.
>> What kind of breakage do you have in mind?
>
> The autoloads for the real ert.el will be overridden by those from
> dash-autoloads.el which will say that for example that ert-deftest
> should be autoloaded from "dev/ert.el".

It seems like the proposed patch would introduce breaking changes, and
the bug report stalled at that point.  So it seem unlikely that there'll
be further progress in this bug report, and I'm closing it.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.