GNU bug report logs - #23600
25.1.50; encode-time returns wrong result

Previous Next

Full log

Message #41 received at 23600 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: eggert <at> cs.ucla.edu
Cc: kzhr <at> d1.dion.ne.jp, 23600 <at> debbugs.gnu.org
Subject: Re: bug#23600: 25.1.50; encode-time returns wrong result
Date: Sun, 05 Jun 2016 18:20:04 +0300

> Date: Sun, 05 Jun 2016 05:47:27 +0300
> From: Eli Zaretskii <eliz <at> gnu.org>
> Cc: kzhr <at> d1.dion.ne.jp, 23600 <at> debbugs.gnu.org
> 
> > Cc: kzhr <at> d1.dion.ne.jp, 23600 <at> debbugs.gnu.org
> > From: Paul Eggert <eggert <at> cs.ucla.edu>
> > Date: Sat, 4 Jun 2016 15:18:43 -0700
> > 
> > Eli Zaretskii wrote:
> > > I think it would be cleaner if we copied the string before modifying
> > > it.
> > 
> > Other parts of Emacs modify the string in place and expect the modifications to 
> > affect the time zone setting, so in general it won't work to copy the string, 
> > modify the copy, and pass the copy's address to putenv.
> 
> Too bad.

Actually, could you point me to those places?  Because if the code
which expects that is not already ifdef'ed out/around for Windows,
it's a problem waiting to be discovered, since MS _putenv accepts a
'const char *' argument, and my references indicate that the
implementation indeed copies the input string.  So those other parts
of the code expect something that cannot work on Windows.

Thanks.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.