GNU bug report logs - #23601
[bisected] Emacs can't build after 2dc0ef29425b7

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 23601 in the body.
You can then email your comments to 23601 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "谢成骏" <xiechj <at> mail2.sysu.edu.cn>
To: "bug-gnu-emacs" <bug-gnu-emacs <at> gnu.org>
Cc: madper.xie <madper.xie <at> canonical.com>
Subject: [bisected] Emacs can't build after 2dc0ef29425b7
Date: Mon, 23 May 2016 11:19:48 +0800

[Message part 1 (text/plain, inline)]

Hi All,
Yesterday my emacs failed to build. 
Here is the error msg:
`````
(require seq) while preparing to dump
Makefile:545: recipe for target 'emacs' failed
make[1]: *** [emacs] Error 255
make[1]: Leaving directory '/home/madper/source/emacs/src'
Makefile:398: recipe for target 'src' failed
make: *** [src] Error 2
`````

After bisect I got:
`````
λ  emacs  848d487 ✓ git bisect good 
2dc0ef29425b7ee4c6c13b832c2a11dfe26ebb35 is the first bad commit
commit 2dc0ef29425b7ee4c6c13b832c2a11dfe26ebb35
Author: Nicolas Petton <nicolas <at> petton.fr>
Date:   Sun May 22 21:51:11 2016 +0200

    Add missing dependencies to seq.el
    
    * lisp/emacs-lisp/find-func.el:
    * lisp/ibuffer.el:
    * lisp/image.el: Require seq.

:040000 040000 e3ae0052facd3cd6728259f6536363c0d0c9d70b 2105b394fefa44da3475d72f61be0f4f393ad985 M      lisp
`````

Thanks a lot in advance,
Madper

[Message part 2 (text/html, inline)]

Message #8 received at 23601 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Petton <nicolas <at> petton.fr>
To: 谢成骏 <xiechj <at> mail2.sysu.edu.cn>, 23601 <at> debbugs.gnu.org
Cc: "madper.xie" <madper.xie <at> canonical.com>
Subject: Re: bug#23601: [bisected] Emacs can't build after 2dc0ef29425b7
Date: Mon, 23 May 2016 11:00:35 +0200

[Message part 1 (text/plain, inline)]

谢成骏 <xiechj <at> mail2.sysu.edu.cn> writes:

> `````
> (require seq) while preparing to dump
> Makefile:545: recipe for target 'emacs' failed
> make[1]: *** [emacs] Error 255

I actually do not know why adding (require 'seq) to image.el makes the
build fail.

I can revert this commit in the meantime.

Nico

[signature.asc (application/pgp-signature, inline)]

Message #11 received at 23601 <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: Nicolas Petton <nicolas <at> petton.fr>
Cc: "madper.xie" <madper.xie <at> canonical.com>,
 谢成骏 <xiechj <at> mail2.sysu.edu.cn>, 23601 <at> debbugs.gnu.org
Subject: Re: bug#23601: [bisected] Emacs can't build after 2dc0ef29425b7
Date: Mon, 23 May 2016 11:35:44 -0400

Nicolas Petton wrote:

> I actually do not know why adding (require 'seq) to image.el makes the
> build fail.

Files which are preloaded (ie, in loadup.el) cannot require any files
that are not themselves in loadup (because those required files would
then be preloaded too). This is an explicit check for such a case.

Message #14 received at 23601 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Petton <nicolas <at> petton.fr>
To: Glenn Morris <rgm <at> gnu.org>
Cc: "madper.xie" <madper.xie <at> canonical.com>,
 谢成骏 <xiechj <at> mail2.sysu.edu.cn>, 23601 <at> debbugs.gnu.org
Subject: Re: bug#23601: [bisected] Emacs can't build after 2dc0ef29425b7
Date: Mon, 23 May 2016 17:54:10 +0200

[Message part 1 (text/plain, inline)]

Glenn Morris <rgm <at> gnu.org> writes:

> Nicolas Petton wrote:
>
>> I actually do not know why adding (require 'seq) to image.el makes the
>> build fail.
>
> Files which are preloaded (ie, in loadup.el) cannot require any files
> that are not themselves in loadup (because those required files would
> then be preloaded too). This is an explicit check for such a case.

Ok, that makes sense.  I'll remove the dependency to seq.el then in
image.el, I don't think it should be preloaded.

Nico

[signature.asc (application/pgp-signature, inline)]

Message #17 received at 23601 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Petton <nicolas <at> petton.fr>
To: Glenn Morris <rgm <at> gnu.org>
Cc: "madper.xie" <madper.xie <at> canonical.com>, 23601-done <at> debbugs.gnu.org,
 谢成骏 <xiechj <at> mail2.sysu.edu.cn>, 23601 <at> debbugs.gnu.org
Subject: Re: bug#23601: [bisected] Emacs can't build after 2dc0ef29425b7
Date: Mon, 23 May 2016 17:56:25 +0200

[Message part 1 (text/plain, inline)]

Glenn Morris <rgm <at> gnu.org> writes:

> Nicolas Petton wrote:
>
>> I actually do not know why adding (require 'seq) to image.el makes the
>> build fail.
>
> Files which are preloaded (ie, in loadup.el) cannot require any files
> that are not themselves in loadup (because those required files would
> then be preloaded too). This is an explicit check for such a case.

Commit c6493c6 fixes the problem, I'm closing this ticket.

Nico

[signature.asc (application/pgp-signature, inline)]

Message #25 received at 23601 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Nicolas Petton <nicolas <at> petton.fr>
Cc: madper.xie <at> canonical.com, rgm <at> gnu.org, xiechj <at> mail2.sysu.edu.cn,
 23601 <at> debbugs.gnu.org
Subject: Re: bug#23601: [bisected] Emacs can't build after 2dc0ef29425b7
Date: Mon, 23 May 2016 19:33:05 +0300

> From: Nicolas Petton <nicolas <at> petton.fr>
> Date: Mon, 23 May 2016 17:54:10 +0200
> Cc: "madper.xie" <madper.xie <at> canonical.com>,
> 	谢成骏 <xiechj <at> mail2.sysu.edu.cn>,
> 	23601 <at> debbugs.gnu.org
> 
> I'll remove the dependency to seq.el then in image.el, I don't think
> it should be preloaded.

Yes, please.  Thanks.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.