GNU bug report logs - #23508
25.1.50; make-network-process fails on :service t

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 23508 in the body.
You can then email your comments to 23508 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: mola mola <mola <at> molamola.xyz>
To: "bug-gnu-emacs <at> gnu.org" <bug-gnu-emacs <at> gnu.org>
Subject: 25.1.50; make-network-process fails on :service t
Date: Tue, 10 May 2016 11:13:38 +0000

[Message part 1 (text/plain, inline)]

In GNU Emacs 25.1.50.1 (x86_64-pc-linux-gnu, GTK+ Version 2.24.30)
 of 2016-05-09 built on ubuntu
Repository revision: c20cc0986cdade6577d6ce169330db19e2169794
Windowing system distributor 'The X.Org Foundation', version 11.0.11803000
System Description:    Ubuntu 16.04 LTS

Recent messages:
For information about GNU Emacs and the GNU system, type C-h C-a.
Mark set
Entering debugger...

Configured features:
XPM JPEG TIFF GIF PNG RSVG SOUND DBUS GSETTINGS NOTIFY LIBXML2 FREETYPE
M17N_FLT LIBOTF XFT ZLIB TOOLKIT_SCROLL_BARS GTK2 X11

Important settings:
  value of $LANG: en_US.UTF-8
  value of $XMODIFIERS: @im=ibus
  locale-coding-system: utf-8-unix

Major mode: Debugger

Minor modes in effect:
  tooltip-mode: t
  global-eldoc-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  buffer-read-only: t
  line-number-mode: t
  transient-mark-mode: t

Load-path shadows:
None found.

Features:
(shadow sort mail-extr emacsbug message puny dired dired-loaddefs
format-spec rfc822 mml mml-sec epa derived epg gnus-util rmail
rmail-loaddefs mm-decode mm-bodies mm-encode mail-parse rfc2231
mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums
mm-util mail-prsvr mail-utils debug edmacro kmacro finder-inf package
epg-config url-handlers url-parse auth-source cl-seq eieio eieio-core
cl-macs eieio-loaddefs password-cache url-vars seq byte-opt gv bytecomp
byte-compile cl-extra help-mode easymenu cconv cl-loaddefs pcase cl-lib
time-date mule-util tooltip eldoc electric uniquify ediff-hook vc-hooks
lisp-float-type mwheel term/x-win x-win term/common-win x-dnd tool-bar
dnd fontset image regexp-opt fringe tabulated-list newcomment elisp-mode
lisp-mode prog-mode register page menu-bar rfn-eshadow timer select
scroll-bar mouse jit-lock font-lock syntax facemenu font-core
term/tty-colors frame cl-generic cham georgian utf-8-lang misc-lang
vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932
hebrew greek romanian slovak czech european ethiopic indian cyrillic
chinese charscript case-table epa-hook jka-cmpr-hook help simple abbrev
obarray minibuffer cl-preloaded nadvice loaddefs button faces cus-face
macroexp files text-properties overlay sha1 md5 base64 format env
code-pages mule custom widget hashtable-print-readable backquote
dbusbind inotify dynamic-setting system-font-setting font-render-setting
move-toolbar gtk x-toolkit x multi-tty make-network-process emacs)

Memory information:
((conses 16 160686 9061)
 (symbols 48 25447 0)
 (miscs 40 269 204)
 (strings 32 36119 6289)
 (string-bytes 1 970348)
 (vectors 16 19072)
 (vector-slots 8 522924 5107)
 (floats 8 224 52)
 (intervals 56 232 10)
 (buffers 976 13)
 (heap 1024 18327 1206))


(setq testprocess
      (make-network-process :name "test"
                            :host 'local
                            :server t
                            :service t
                            :family 'ipv4))

This works fine on emacs 24. It is not working in emacs 25. In emacs 25, it seems that only string and integer is accepted.

:service service

    service specifies a port number to connect to; or, for a server, the port number to listen on. It should be a service name that translates to a port number, or an integer specifying the port number directly. For a server, it can also be t, which means to let the system select an unused port number.


Backtrace log:
Debugger entered--Lisp error: (error "Invalid argument 4 of operation 'open-network-stream'")
  make-network-process(:name "test" :host local :server t :service t :family ipv4)
  (setq testprocess (make-network-process :name "test" :host (quote local) :server t :service t :family (quote ipv4)))
  eval((setq testprocess (make-network-process :name "test" :host (quote local) :server t :service t :family (quote ipv4))) nil)
  elisp--eval-last-sexp(nil)
  eval-last-sexp(nil)
  funcall-interactively(eval-last-sexp nil)
  call-interactively(eval-last-sexp nil nil)
   command-execute(eval-last-sexp)

[Message part 2 (text/html, inline)]

Message #10 received at 23508 <at> debbugs.gnu.org (full text, mbox):

From: Kaushal Modi <kaushal.modi <at> gmail.com>
To: 23508 <at> debbugs.gnu.org, Lars Ingebrigtsen <larsi <at> gnus.org>,
 matthew <at> mattleach.net
Cc: joe <at> jschaf.com
Subject: 25.1.50; make-network-process fails on :service t
Date: Fri, 15 Jul 2016 11:56:59 +0000

[Message part 1 (text/plain, inline)]

Hi all,

I was trying out the esup[1] package when I stumbled upon the exact same
make-network-process error[2] in this debbugs.

I am copying Lars and Matthew on this thread hoping that they have an
insight into what might be causing this, based on the commit history[3].

[1]: https://github.com/jschaf/esup
[2]: https://github.com/jschaf/esup/issues/25#issuecomment-232932617
[3]:
http://git.savannah.gnu.org/cgit/emacs.git/log/?qt=grep&q=make-network-process

-- 

Kaushal Modi

[Message part 2 (text/html, inline)]

Message #13 received at 23508 <at> debbugs.gnu.org (full text, mbox):

From: Kaushal Modi <kaushal.modi <at> gmail.com>
To: Joe Schafer <joe <at> jschaf.com>, 23508 <at> debbugs.gnu.org, 
 Lars Ingebrigtsen <larsi <at> gnus.org>, matthew <at> mattleach.net
Subject: Re: 25.1.50; make-network-process fails on :service t
Date: Fri, 15 Jul 2016 18:21:35 +0000

[Message part 1 (text/plain, inline)]

Thanks Joe,

I confirm this workaround.

On Fri, Jul 15, 2016 at 1:44 PM Joe Schafer <joe <at> jschaf.com> wrote:

> If I set :nowait to nil, make-network-process works with :service t on Emacs25
> (25.1.50.2 2016-07-03).
>
-- 

Kaushal Modi

[Message part 2 (text/html, inline)]

Message #16 received at 23508 <at> debbugs.gnu.org (full text, mbox):

From: Joe Schafer <joe <at> jschaf.com>
To: Kaushal Modi <kaushal.modi <at> gmail.com>, 23508 <at> debbugs.gnu.org, 
 Lars Ingebrigtsen <larsi <at> gnus.org>, matthew <at> mattleach.net
Subject: Re: 25.1.50; make-network-process fails on :service t
Date: Fri, 15 Jul 2016 17:44:43 +0000

[Message part 1 (text/plain, inline)]

If I set :nowait to nil, make-network-process works with :service t on Emacs25
(25.1.50.2 2016-07-03).

On Fri, Jul 15, 2016 at 5:04 AM Kaushal Modi <kaushal.modi <at> gmail.com> wrote:

> Hi all,
>
> I was trying out the esup[1] package when I stumbled upon the exact same
> make-network-process error[2] in this debbugs.
>
> I am copying Lars and Matthew on this thread hoping that they have an
> insight into what might be causing this, based on the commit history[3].
>
> [1]: https://github.com/jschaf/esup
> [2]: https://github.com/jschaf/esup/issues/25#issuecomment-232932617
> [3]:
> http://git.savannah.gnu.org/cgit/emacs.git/log/?qt=grep&q=make-network-process
>
> --
>
> Kaushal Modi
>

[Message part 2 (text/html, inline)]

Message #21 received at 23508 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Ken Brown <kbrown <at> cornell.edu>
Cc: 23540 <at> debbugs.gnu.org, Eli Zaretskii <eliz <at> gnu.org>, 23508 <at> debbugs.gnu.org
Subject: Re: bug#23540: 25.1.50; make-ipv4-tcp-server-with-unspecified-port
 fails
Date: Wed, 23 Oct 2019 12:32:05 +0200

Ken Brown <kbrown <at> cornell.edu> writes:

>> Presumably the documentation of open-network-stream should also be
>> updated to reflect this.  I hesitate to do this myself without knowing
>> for sure that t is an acceptable value for all calls to
>> open-network-stream.  I'd rather leave it for someone more familiar with
>> the code, like Lars.
>
> I went ahead and installed the obvious fix, to get rid of the test
> failure.  I'm leaving the bug open because someone knowledgeable still 
> needs to update the documentation of open-network-stream.

The test calls make-network-process, not open-network-stream, so
altering the documentation of the latter doesn't seem appropriate.

As for make-network-process, it's already documented there:

:service SERVICE -- SERVICE is name of the service desired, or an
integer specifying a port number to connect to.  If SERVICE is t,
a random port number is selected for the server.  A port number can
be specified as an integer string, e.g., "80", as well as an integer.

So unless I'm misreading this bug report (which is possible, it's a bit
involved) there's nothing more to do here, and I'm closing this bug
report.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #28 received at 23508 <at> debbugs.gnu.org (full text, mbox):

From: Ken Brown <kbrown <at> cornell.edu>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: "23540 <at> debbugs.gnu.org" <23540 <at> debbugs.gnu.org>,
 Eli Zaretskii <eliz <at> gnu.org>, "23508 <at> debbugs.gnu.org" <23508 <at> debbugs.gnu.org>
Subject: Re: bug#23540: 25.1.50; make-ipv4-tcp-server-with-unspecified-port
 fails
Date: Wed, 23 Oct 2019 16:31:08 +0000

On 10/23/2019 6:32 AM, Lars Ingebrigtsen wrote:
> Ken Brown <kbrown <at> cornell.edu> writes:
> 
>>> Presumably the documentation of open-network-stream should also be
>>> updated to reflect this.  I hesitate to do this myself without knowing
>>> for sure that t is an acceptable value for all calls to
>>> open-network-stream.  I'd rather leave it for someone more familiar with
>>> the code, like Lars.
>>
>> I went ahead and installed the obvious fix, to get rid of the test
>> failure.  I'm leaving the bug open because someone knowledgeable still
>> needs to update the documentation of open-network-stream.
> 
> The test calls make-network-process, not open-network-stream, so
> altering the documentation of the latter doesn't seem appropriate.

It's appropriate because the documentation is wrong.  The documentation of 
open-network-stream doesn't say that the fourth argument can be t.

Ken

Message #31 received at 23508 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Ken Brown <kbrown <at> cornell.edu>
Cc: "23540 <at> debbugs.gnu.org" <23540 <at> debbugs.gnu.org>,
 Eli Zaretskii <eliz <at> gnu.org>, "23508 <at> debbugs.gnu.org" <23508 <at> debbugs.gnu.org>
Subject: Re: bug#23540: 25.1.50; make-ipv4-tcp-server-with-unspecified-port
 fails
Date: Thu, 24 Oct 2019 13:48:03 +0200

Ken Brown <kbrown <at> cornell.edu> writes:

>>>> Presumably the documentation of open-network-stream should also be
>>>> updated to reflect this.  I hesitate to do this myself without knowing
>>>> for sure that t is an acceptable value for all calls to
>>>> open-network-stream.  I'd rather leave it for someone more familiar with
>>>> the code, like Lars.
>>>
>>> I went ahead and installed the obvious fix, to get rid of the test
>>> failure.  I'm leaving the bug open because someone knowledgeable still
>>> needs to update the documentation of open-network-stream.
>> 
>> The test calls make-network-process, not open-network-stream, so
>> altering the documentation of the latter doesn't seem appropriate.
>
> It's appropriate because the documentation is wrong.  The documentation of 
> open-network-stream doesn't say that the fourth argument can be t.

open-network-stream is for opening a client connection.  The t value for
service only makes sense for servers, so mentioning that value in
the open-network-stream doc string seems odd.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.