GNU bug report logs - #23356
[PATCH] Cache results of `css--property-values'

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Simen Heggestøyl <simenheg <at> gmail.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#23356: closed ([PATCH] Cache results of `css--property-values')
Date: Sun, 24 Apr 2016 13:08:01 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sun, 24 Apr 2016 15:07:50 +0200
with message-id <1461503270.5416.2 <at> smtp.gmail.com>
and subject line Re: bug#23356: [PATCH] Cache results of `css--property-values'
has caused the debbugs.gnu.org bug report #23356,
regarding [PATCH] Cache results of `css--property-values'
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
23356: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=23356
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Simen Heggestøyl <simenheg <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Cc: Dmitry Gutov <dgutov <at> yandex.ru>
Subject: [PATCH] Cache results of `css--property-values'
Date: Sun, 24 Apr 2016 14:44:50 +0200

[Message part 3 (text/plain, inline)]

During one of the iterations for 269d5631 (Support completion of
attribute values in CSS mode), the code that actually updates the
`css--property-value-cache' cache in `css--property-values' got lost.
The attached patch reintroduces it along with a regression test.

--Simen

[Message part 4 (text/html, inline)]

[0001-Cache-results-of-css-property-values.patch (text/x-patch, attachment)]

[Message part 6 (message/rfc822, inline)]

From: Simen Heggestøyl <simenheg <at> gmail.com>
To: Dmitry Gutov <dgutov <at> yandex.ru>
Cc: 23356-done <at> debbugs.gnu.org
Subject: Re: bug#23356: [PATCH] Cache results of `css--property-values'
Date: Sun, 24 Apr 2016 15:07:50 +0200

[Message part 7 (text/plain, inline)]

On Sun, Apr 24, 2016 at 3:00 PM, Dmitry Gutov <dgutov <at> yandex.ru> wrote:
> LGTM.

Thanks for the review, installed in master.

> You should be able to push this kind of changes without going through 
> review anyway.

I thought so too, but I wasn't entirely sure. I'll adjust my threshold
then for what I can go ahead with without a review.

-- Simen

[Message part 8 (text/html, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.