GNU bug report logs - #23356
[PATCH] Cache results of `css--property-values'

Previous Next

Package: emacs;

Reported by: Simen Heggestøyl <simenheg <at> gmail.com>

Date: Sun, 24 Apr 2016 12:46:02 UTC

Severity: normal

Tags: patch

Done: Simen Heggestøyl <simenheg <at> gmail.com>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 23356 in the body.
You can then email your comments to 23356 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#23356; Package emacs. (Sun, 24 Apr 2016 12:46:02 GMT) Full text and rfc822 format available.
Acknowledgement sent to Simen Heggestøyl <simenheg <at> gmail.com>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Sun, 24 Apr 2016 12:46:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Simen Heggestøyl <simenheg <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Cc: Dmitry Gutov <dgutov <at> yandex.ru>
Subject: [PATCH] Cache results of `css--property-values'
Date: Sun, 24 Apr 2016 14:44:50 +0200

[Message part 1 (text/plain, inline)]
During one of the iterations for 269d5631 (Support completion of
attribute values in CSS mode), the code that actually updates the
`css--property-value-cache' cache in `css--property-values' got lost.
The attached patch reintroduces it along with a regression test.

--Simen

[Message part 2 (text/html, inline)]
[0001-Cache-results-of-css-property-values.patch (text/x-patch, attachment)]
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#23356; Package emacs. (Sun, 24 Apr 2016 13:01:02 GMT) Full text and rfc822 format available.

Message #8 received at 23356 <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: Simen Heggestøyl <simenheg <at> gmail.com>,
 23356 <at> debbugs.gnu.org
Subject: Re: bug#23356: [PATCH] Cache results of `css--property-values'
Date: Sun, 24 Apr 2016 16:00:01 +0300

On 04/24/2016 03:44 PM, Simen Heggestøyl wrote:
> During one of the iterations for 269d5631 (Support completion of
> attribute values in CSS mode), the code that actually updates the
> `css--property-value-cache' cache in `css--property-values' got lost.
> The attached patch reintroduces it along with a regression test.

LGTM.

You should be able to push this kind of changes without going through 
review anyway.
Reply sent to Simen Heggestøyl <simenheg <at> gmail.com>:
You have taken responsibility. (Sun, 24 Apr 2016 13:08:01 GMT) Full text and rfc822 format available.
Notification sent to Simen Heggestøyl <simenheg <at> gmail.com>:
bug acknowledged by developer. (Sun, 24 Apr 2016 13:08:01 GMT) Full text and rfc822 format available.

Message #13 received at 23356-done <at> debbugs.gnu.org (full text, mbox):

From: Simen Heggestøyl <simenheg <at> gmail.com>
To: Dmitry Gutov <dgutov <at> yandex.ru>
Cc: 23356-done <at> debbugs.gnu.org
Subject: Re: bug#23356: [PATCH] Cache results of `css--property-values'
Date: Sun, 24 Apr 2016 15:07:50 +0200

[Message part 1 (text/plain, inline)]
On Sun, Apr 24, 2016 at 3:00 PM, Dmitry Gutov <dgutov <at> yandex.ru> wrote:
> LGTM.

Thanks for the review, installed in master.

> You should be able to push this kind of changes without going through 
> review anyway.

I thought so too, but I wasn't entirely sure. I'll adjust my threshold
then for what I can go ahead with without a review.

-- Simen

[Message part 2 (text/html, inline)]
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Mon, 23 May 2016 11:24:04 GMT) Full text and rfc822 format available.
This bug report was last modified 9 years and 113 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.