GNU bug report logs - #23288
25.0.92; Clicking on links inserts primary X selection

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 23288 in the body.
You can then email your comments to 23288 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Philipp Stephani <p.stephani2 <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 25.0.92; Clicking on links inserts primary X selection
Date: Thu, 14 Apr 2016 14:31:08 +0200

Here 'emacs' is an Emacs binary using Gtk+ on GNU/Linux.

echo -n bar | xsel -i && \
  emacs -Q -eval \
  "(insert (propertize \"foo\" 'follow-link (lambda (pos) \"a\")))"

Then click on "foo" in the scratch buffer.  If 'emacs' is Emacs 24.3,
"a" will be inserted.  If 'emacs' is from the emacs-25 branch, "bar"
will be inserted.  I think this is a regression; follow-link should
adhere to the link action no matter what is in the X selection.



In GNU Emacs 25.0.92.2 (x86_64-unknown-linux-gnu, GTK+ Version 3.10.8)
 of 2016-04-14 built on localhost
Repository revision: 567ab529f313bc8fe68d25b2ca95f5987cce81a1
Windowing system distributor 'The X.Org Foundation', version 11.0.11501000
System Description:	Ubuntu 14.04 LTS

Configured using:
 'configure --with-modules CFLAGS=-g'

Configured features:
XPM JPEG TIFF GIF PNG SOUND GSETTINGS NOTIFY FREETYPE XFT ZLIB
TOOLKIT_SCROLL_BARS GTK3 X11 MODULES

Important settings:
  value of $LANG: en_US.UTF-8
  locale-coding-system: utf-8-unix

Major mode: Lisp Interaction

Minor modes in effect:
  tooltip-mode: t
  global-eldoc-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Recent messages:
For information about GNU Emacs and the GNU system, type C-h C-a.

Load-path shadows:
None found.

Features:
(shadow sort mail-extr emacsbug message dired format-spec rfc822 mml
mml-sec password-cache epg epg-config gnus-util mm-decode mm-bodies
mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail
rfc2047 rfc2045 ietf-drums mm-util help-fns help-mode easymenu
cl-loaddefs pcase cl-lib mail-prsvr mail-utils time-date mule-util
tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type
mwheel x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt
fringe tabulated-list newcomment elisp-mode lisp-mode prog-mode register
page menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock
font-lock syntax facemenu font-core frame cl-generic cham georgian
utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean
japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european
ethiopic indian cyrillic chinese charscript case-table epa-hook
jka-cmpr-hook help simple abbrev minibuffer cl-preloaded nadvice
loaddefs button faces cus-face macroexp files text-properties overlay
sha1 md5 base64 format env code-pages mule custom widget
hashtable-print-readable backquote inotify dynamic-setting
system-font-setting font-render-setting move-toolbar gtk x-toolkit x
multi-tty make-network-process emacs)

Memory information:
((conses 16 88168 9879)
 (symbols 48 19855 0)
 (miscs 40 325 173)
 (strings 32 14741 4231)
 (string-bytes 1 437388)
 (vectors 16 12106)
 (vector-slots 8 439789 6169)
 (floats 8 164 78)
 (intervals 56 208 0)
 (buffers 976 12)
 (heap 1024 24962 1011))

-- 
Google Germany GmbH
Erika-Mann-Straße 33
80636 München

Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg
Geschäftsführer: Matthew Scott Sucherman, Paul Terence Manicle

Diese E-Mail ist vertraulich.  Wenn Sie nicht der richtige Adressat sind,
leiten Sie diese bitte nicht weiter, informieren Sie den Absender und löschen
Sie die E-Mail und alle Anhänge.  Vielen Dank.

This e-mail is confidential.  If you are not the right addressee please do not
forward it, please inform the sender, and please erase this e-mail including
any attachments.  Thanks.

Message #8 received at 23288 <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: Philipp Stephani <p.stephani2 <at> gmail.com>
Cc: 23288 <at> debbugs.gnu.org
Subject: Re: bug#23288: 25.0.92; Clicking on links inserts primary X selection
Date: Thu, 14 Apr 2016 11:33:30 -0400

Sounds like http://debbugs.gnu.org/22434

Message #13 received at 23288 <at> debbugs.gnu.org (full text, mbox):

From: Nils Berg <nilsb <at> google.com>
To: 23288 <at> debbugs.gnu.org
Subject: Re: bug#23288: 25.0.92; Clicking on links inserts primary X selection
Date: Thu, 14 Apr 2016 19:14:40 +0200

[Message part 1 (text/plain, inline)]

I've tracked down the bug to mouse--down-1-maybe-follows-link too, but
don't think read-event is the culprit here.

Rather, mouse--down-1-maybe-follows-link discards the result of
mouse-on-link-p, which contains the event a click is supposed to be
translated into. Instead, it just replaces the mouse event with mouse-2 if
mouse-on-link-p returns non-nil.

[Message part 2 (text/html, inline)]

Message #16 received at 23288 <at> debbugs.gnu.org (full text, mbox):

From: Philipp Stephani <p.stephani2 <at> gmail.com>
To: Nils Berg <nilsb <at> google.com>, 23288 <at> debbugs.gnu.org
Subject: Re: bug#23288: 25.0.92; Clicking on links inserts primary X selection
Date: Sat, 16 Apr 2016 13:36:35 +0000

[Message part 1 (text/plain, inline)]

Nils Berg <nilsb <at> google.com> schrieb am Do., 14. Apr. 2016 um 19:18 Uhr:

> I've tracked down the bug to mouse--down-1-maybe-follows-link too, but
> don't think read-event is the culprit here.
>
> Rather, mouse--down-1-maybe-follows-link discards the result of
> mouse-on-link-p, which contains the event a click is supposed to be
> translated into. Instead, it just replaces the mouse event with mouse-2 if
> mouse-on-link-p returns non-nil.
>

I've attached a patch that should fix this. According to the documentation
of mouse-on-link-p no such translation should happen if the return value is
a string or vector.

[Message part 2 (text/html, inline)]

[0001-Fix-link-handling.patch (application/octet-stream, attachment)]

Message #19 received at 23288 <at> debbugs.gnu.org (full text, mbox):

From: Nils Berg <nilsb <at> google.com>
To: Philipp Stephani <p.stephani2 <at> gmail.com>
Cc: 23288 <at> debbugs.gnu.org
Subject: Re: bug#23288: 25.0.92; Clicking on links inserts primary X selection
Date: Mon, 18 Apr 2016 10:50:37 +0200

[Message part 1 (text/plain, inline)]

I applied the patch, and the paste-on-click behavior is gone.

However, if you try your original example again, you'll find that nothing
happens at all, when we're expecting an "a" to be inserted.
As the documentation of mouse-on-link-p says, a string or vector return
value indicates the event to translate the original mouse-1 click into. In
emacs24, that translation was done in mouse-drag-track:
(let (on-link (and mouse-1-click-follows-link
                       ;; Use start-point before the intangibility
                       ;; treatment, in case we click on a link inside
                       ;; intangible text.
  (mouse-on-link-p start-posn)))
  (if (or (vectorp on-link) (stringp on-link))
 (setq event (aref on-link 0))
(select-window original-window)
(setcar event 'mouse-2)
;; If this mouse click has never been done by the
;; user, it doesn't have the necessary property to be
;; interpreted correctly.
(put 'mouse-2 'event-kind 'mouse-click)))

(abridged from mouse.el:791/901 in Emacs 24.3.1)

I think mouse--down-1-maybe-follows-link should do something similar.

On Sat, Apr 16, 2016 at 3:36 PM, Philipp Stephani <p.stephani2 <at> gmail.com>
wrote:

>
>
> Nils Berg <nilsb <at> google.com> schrieb am Do., 14. Apr. 2016 um 19:18 Uhr:
>
>> I've tracked down the bug to mouse--down-1-maybe-follows-link too, but
>> don't think read-event is the culprit here.
>>
>> Rather, mouse--down-1-maybe-follows-link discards the result of
>> mouse-on-link-p, which contains the event a click is supposed to be
>> translated into. Instead, it just replaces the mouse event with mouse-2 if
>> mouse-on-link-p returns non-nil.
>>
>
> I've attached a patch that should fix this. According to the documentation
> of mouse-on-link-p no such translation should happen if the return value is
> a string or vector.
>

[Message part 2 (text/html, inline)]

Message #22 received at 23288 <at> debbugs.gnu.org (full text, mbox):

From: Philipp Stephani <p.stephani2 <at> gmail.com>
To: Nils Berg <nilsb <at> google.com>
Cc: 23288 <at> debbugs.gnu.org
Subject: Re: bug#23288: 25.0.92; Clicking on links inserts primary X selection
Date: Wed, 20 Apr 2016 16:53:38 +0000

[Message part 1 (text/plain, inline)]

Nils Berg <nilsb <at> google.com> schrieb am Mo., 18. Apr. 2016 um 10:50 Uhr:

> I applied the patch, and the paste-on-click behavior is gone.
>
> However, if you try your original example again, you'll find that nothing
> happens at all, when we're expecting an "a" to be inserted.
> As the documentation of mouse-on-link-p says, a string or vector return
> value indicates the event to translate the original mouse-1 click into. In
> emacs24, that translation was done in mouse-drag-track:
> (let (on-link (and mouse-1-click-follows-link
>                        ;; Use start-point before the intangibility
>                        ;; treatment, in case we click on a link inside
>                        ;; intangible text.
>   (mouse-on-link-p start-posn)))
>   (if (or (vectorp on-link) (stringp on-link))
>  (setq event (aref on-link 0))
> (select-window original-window)
> (setcar event 'mouse-2)
> ;; If this mouse click has never been done by the
> ;; user, it doesn't have the necessary property to be
> ;; interpreted correctly.
> (put 'mouse-2 'event-kind 'mouse-click)))
>
> (abridged from mouse.el:791/901 in Emacs 24.3.1)
>
> I think mouse--down-1-maybe-follows-link should do something similar.
>

Agreed. https://debbugs.gnu.org/cgi/bugreport.cgi?bug=17887 might also be
related.

[Message part 2 (text/html, inline)]

Message #25 received at 23288 <at> debbugs.gnu.org (full text, mbox):

From: Philipp Stephani <p.stephani2 <at> gmail.com>
To: Nils Berg <nilsb <at> google.com>
Cc: 23288 <at> debbugs.gnu.org
Subject: Re: bug#23288: 25.0.92; Clicking on links inserts primary X selection
Date: Tue, 10 May 2016 21:25:47 +0000

[Message part 1 (text/plain, inline)]

Philipp Stephani <p.stephani2 <at> gmail.com> schrieb am Mi., 20. Apr. 2016 um
18:53 Uhr:

> Nils Berg <nilsb <at> google.com> schrieb am Mo., 18. Apr. 2016 um 10:50 Uhr:
>
>> I applied the patch, and the paste-on-click behavior is gone.
>>
>> However, if you try your original example again, you'll find that nothing
>> happens at all, when we're expecting an "a" to be inserted.
>> As the documentation of mouse-on-link-p says, a string or vector return
>> value indicates the event to translate the original mouse-1 click into. In
>> emacs24, that translation was done in mouse-drag-track:
>> (let (on-link (and mouse-1-click-follows-link
>>                        ;; Use start-point before the intangibility
>>                        ;; treatment, in case we click on a link inside
>>                        ;; intangible text.
>>   (mouse-on-link-p start-posn)))
>>   (if (or (vectorp on-link) (stringp on-link))
>>  (setq event (aref on-link 0))
>> (select-window original-window)
>> (setcar event 'mouse-2)
>> ;; If this mouse click has never been done by the
>> ;; user, it doesn't have the necessary property to be
>> ;; interpreted correctly.
>> (put 'mouse-2 'event-kind 'mouse-click)))
>>
>> (abridged from mouse.el:791/901 in Emacs 24.3.1)
>>
>> I think mouse--down-1-maybe-follows-link should do something similar.
>>
>
> Agreed. https://debbugs.gnu.org/cgi/bugreport.cgi?bug=17887 might also be
> related.
>
>
I've attached a new patch that should hopefully correct the behavior.

[Message part 2 (text/html, inline)]

[0001-Fix-handling-of-mouse-on-link-p.patch (application/octet-stream, attachment)]

Message #28 received at 23288 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Philipp Stephani <p.stephani2 <at> gmail.com>
Cc: 23288 <at> debbugs.gnu.org, nilsb <at> google.com
Subject: Re: bug#23288: 25.0.92; Clicking on links inserts primary X selection
Date: Wed, 11 May 2016 11:14:06 +0300

> From: Philipp Stephani <p.stephani2 <at> gmail.com>
> Date: Tue, 10 May 2016 21:25:47 +0000
> Cc: 23288 <at> debbugs.gnu.org
> 
>  Agreed. https://debbugs.gnu.org/cgi/bugreport.cgi?bug=17887 might also be related.
> 
> I've attached a new patch that should hopefully correct the behavior. 

Thanks.  If no one objects in a week, please push to the master
branch.

Message #31 received at 23288 <at> debbugs.gnu.org (full text, mbox):

From: Nils Berg <nilsb <at> google.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: Philipp Stephani <p.stephani2 <at> gmail.com>, 23288 <at> debbugs.gnu.org
Subject: Re: bug#23288: 25.0.92; Clicking on links inserts primary X selection
Date: Wed, 11 May 2016 10:32:42 +0200

[Message part 1 (text/plain, inline)]

Still no dice, sorry.  I just tried the patched version with the original
example:
echo -n bar | xsel -i && \
  emacs -Q -eval \
  "(insert (propertize \"foo\" 'follow-link (lambda (pos) \"a\")))"

Now when I click foo nothing happens in the buffer, but there's an error
message:
Function mouse--down-1-maybe-follows-link returns invalid key sequence

I can't think of a reason why though :(

M-x version: GNU Emacs 25.0.93.1 (x86_64-pc-linux-gnu, GTK+ Version 3.10.8)

On Wed, May 11, 2016 at 10:14 AM, Eli Zaretskii <eliz <at> gnu.org> wrote:

> > From: Philipp Stephani <p.stephani2 <at> gmail.com>
> > Date: Tue, 10 May 2016 21:25:47 +0000
> > Cc: 23288 <at> debbugs.gnu.org
> >
> >  Agreed. https://debbugs.gnu.org/cgi/bugreport.cgi?bug=17887 might also
> be related.
> >
> > I've attached a new patch that should hopefully correct the behavior.
>
> Thanks.  If no one objects in a week, please push to the master
> branch.
>

[Message part 2 (text/html, inline)]

Message #34 received at 23288 <at> debbugs.gnu.org (full text, mbox):

From: Philipp Stephani <p.stephani2 <at> gmail.com>
To: Nils Berg <nilsb <at> google.com>, Eli Zaretskii <eliz <at> gnu.org>
Cc: 23288 <at> debbugs.gnu.org
Subject: Re: bug#23288: 25.0.92; Clicking on links inserts primary X selection
Date: Wed, 11 May 2016 13:01:55 +0000

[Message part 1 (text/plain, inline)]

There was a small bug in the patch. I've attached a new version that
hopefully fixes that.

Nils Berg <nilsb <at> google.com> schrieb am Mi., 11. Mai 2016 um 10:32 Uhr:

> Still no dice, sorry.  I just tried the patched version with the original
> example:
> echo -n bar | xsel -i && \
>   emacs -Q -eval \
>   "(insert (propertize \"foo\" 'follow-link (lambda (pos) \"a\")))"
>
> Now when I click foo nothing happens in the buffer, but there's an error
> message:
> Function mouse--down-1-maybe-follows-link returns invalid key sequence
>
> I can't think of a reason why though :(
>
> M-x version: GNU Emacs 25.0.93.1 (x86_64-pc-linux-gnu, GTK+ Version 3.10.8)
>
> On Wed, May 11, 2016 at 10:14 AM, Eli Zaretskii <eliz <at> gnu.org> wrote:
>
>> > From: Philipp Stephani <p.stephani2 <at> gmail.com>
>> > Date: Tue, 10 May 2016 21:25:47 +0000
>> > Cc: 23288 <at> debbugs.gnu.org
>> >
>> >  Agreed. https://debbugs.gnu.org/cgi/bugreport.cgi?bug=17887 might
>> also be related.
>> >
>> > I've attached a new patch that should hopefully correct the behavior.
>>
>> Thanks.  If no one objects in a week, please push to the master
>> branch.
>>
>
>

[Message part 2 (text/html, inline)]

[0001-Fix-handling-of-mouse-on-link-p.patch (text/x-patch, attachment)]

Message #37 received at 23288 <at> debbugs.gnu.org (full text, mbox):

From: Nils Berg <nilsb <at> google.com>
To: Philipp Stephani <p.stephani2 <at> gmail.com>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 23288 <at> debbugs.gnu.org
Subject: Re: bug#23288: 25.0.92; Clicking on links inserts primary X selection
Date: Wed, 11 May 2016 15:14:39 +0200

[Message part 1 (text/plain, inline)]

Perfect, now it works :) Thanks for fixing this!

On Wed, May 11, 2016 at 3:01 PM, Philipp Stephani <p.stephani2 <at> gmail.com>
wrote:

> There was a small bug in the patch. I've attached a new version that
> hopefully fixes that.
>
>
> Nils Berg <nilsb <at> google.com> schrieb am Mi., 11. Mai 2016 um 10:32 Uhr:
>
>> Still no dice, sorry.  I just tried the patched version with the original
>> example:
>> echo -n bar | xsel -i && \
>>   emacs -Q -eval \
>>   "(insert (propertize \"foo\" 'follow-link (lambda (pos) \"a\")))"
>>
>> Now when I click foo nothing happens in the buffer, but there's an error
>> message:
>> Function mouse--down-1-maybe-follows-link returns invalid key sequence
>>
>> I can't think of a reason why though :(
>>
>> M-x version: GNU Emacs 25.0.93.1 (x86_64-pc-linux-gnu, GTK+ Version
>> 3.10.8)
>>
>> On Wed, May 11, 2016 at 10:14 AM, Eli Zaretskii <eliz <at> gnu.org> wrote:
>>
>>> > From: Philipp Stephani <p.stephani2 <at> gmail.com>
>>> > Date: Tue, 10 May 2016 21:25:47 +0000
>>> > Cc: 23288 <at> debbugs.gnu.org
>>> >
>>> >  Agreed. https://debbugs.gnu.org/cgi/bugreport.cgi?bug=17887 might
>>> also be related.
>>> >
>>> > I've attached a new patch that should hopefully correct the behavior.
>>>
>>> Thanks.  If no one objects in a week, please push to the master
>>> branch.
>>>
>>
>>

[Message part 2 (text/html, inline)]

Message #40 received at 23288 <at> debbugs.gnu.org (full text, mbox):

From: Philipp Stephani <p.stephani2 <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 23288 <at> debbugs.gnu.org, nilsb <at> google.com
Subject: Re: bug#23288: 25.0.92; Clicking on links inserts primary X selection
Date: Wed, 11 May 2016 13:32:09 +0000

[Message part 1 (text/plain, inline)]

Eli Zaretskii <eliz <at> gnu.org> schrieb am Mi., 11. Mai 2016 um 10:14 Uhr:

> > From: Philipp Stephani <p.stephani2 <at> gmail.com>
> > Date: Tue, 10 May 2016 21:25:47 +0000
> > Cc: 23288 <at> debbugs.gnu.org
> >
> >  Agreed. https://debbugs.gnu.org/cgi/bugreport.cgi?bug=17887 might also
> be related.
> >
> > I've attached a new patch that should hopefully correct the behavior.
>
> Thanks.  If no one objects in a week, please push to the master
> branch.
>

Not to emacs-25? The bug is rather annoying, and the fix comparatively
simple.

[Message part 2 (text/html, inline)]

Message #43 received at 23288 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Philipp Stephani <p.stephani2 <at> gmail.com>, John Wiegley <johnw <at> gnu.org>
Cc: 23288 <at> debbugs.gnu.org, nilsb <at> google.com
Subject: Re: bug#23288: 25.0.92; Clicking on links inserts primary X selection
Date: Wed, 11 May 2016 16:56:14 +0300

> From: Philipp Stephani <p.stephani2 <at> gmail.com>
> Date: Wed, 11 May 2016 13:32:09 +0000
> Cc: nilsb <at> google.com, 23288 <at> debbugs.gnu.org
> 
>  Thanks. If no one objects in a week, please push to the master
>  branch.
> 
> Not to emacs-25? The bug is rather annoying, and the fix comparatively simple. 

It didn't look simple to me, but maybe I'm missing something.

CC'ing John, so he could make the decision.

Thanks.

Message #46 received at 23288 <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: Philipp Stephani <p.stephani2 <at> gmail.com>, John Wiegley <johnw <at> gnu.org>,
 23288 <at> debbugs.gnu.org, nilsb <at> google.com
Subject: Re: bug#23288: 25.0.92; Clicking on links inserts primary X selection
Date: Wed, 11 May 2016 14:40:54 -0400

FWIW, this seems to me like a bad bug that should be fixed for 25.1.
Accidentally pasting the selection can be bad (eg if you don't notice it
happened and there was something sensitive there).

(See also merged #22434. Marked as release blocking for 3+ months.)

Message #49 received at 23288 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Glenn Morris <rgm <at> gnu.org>
Cc: p.stephani2 <at> gmail.com, johnw <at> gnu.org, 23288 <at> debbugs.gnu.org,
 nilsb <at> google.com
Subject: Re: bug#23288: 25.0.92; Clicking on links inserts primary X selection
Date: Thu, 12 May 2016 00:04:02 +0300

> From: Glenn Morris <rgm <at> gnu.org>
> Cc: Philipp Stephani <p.stephani2 <at> gmail.com>,  John Wiegley <johnw <at> gnu.org>,  23288 <at> debbugs.gnu.org,  nilsb <at> google.com
> Date: Wed, 11 May 2016 14:40:54 -0400
> 
> 
> FWIW, this seems to me like a bad bug that should be fixed for 25.1.
> Accidentally pasting the selection can be bad (eg if you don't notice it
> happened and there was something sensitive there).
> 
> (See also merged #22434. Marked as release blocking for 3+ months.)

Sorry, I don't see the list of blocking bugs being treated seriously.
If we did treat it seriously, we wouldn't have had "deep freeze" on
emacs-25, and wouldn't be planning the release in less than a month.

Message #52 received at 23288 <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: p.stephani2 <at> gmail.com, johnw <at> gnu.org, 23288 <at> debbugs.gnu.org,
 nilsb <at> google.com
Subject: Re: bug#23288: 25.0.92; Clicking on links inserts primary X selection
Date: Thu, 12 May 2016 12:49:13 -0400

Eli Zaretskii wrote:

> Sorry, I don't see the list of blocking bugs being treated seriously.
> If we did treat it seriously, we wouldn't have had "deep freeze" on
> emacs-25, and wouldn't be planning the release in less than a month.

(off-topic)

Indeed. Though I have noticed some people looking at those issues
recently (thanks!).

I'd hope those in charge would be encouraging people to work on those
issues, but I haven't noticed it happening. Previous Emacs releases
weren't time-based, but were made when they were ready.

Also, good luck proof-reading every manual chapter in a month! :)

Message #55 received at 23288 <at> debbugs.gnu.org (full text, mbox):

From: John Wiegley <jwiegley <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: Philipp Stephani <p.stephani2 <at> gmail.com>, 23288 <at> debbugs.gnu.org,
 nilsb <at> google.com
Subject: Re: bug#23288: 25.0.92; Clicking on links inserts primary X selection
Date: Wed, 11 May 2016 11:18:54 -0700

[Message part 1 (text/plain, inline)]

>>>>> Eli Zaretskii <eliz <at> gnu.org> writes:

> It didn't look simple to me, but maybe I'm missing something.

It doesn't look simple enough for 25.1.

Remember, 25.2 can come out as quickly after as we want it to, so please tag
it for that release.

-- 
John Wiegley                  GPG fingerprint = 4710 CF98 AF9B 327B B80F
http://newartisans.com                          60E1 46C4 BD1A 7AC1 4BA2

[signature.asc (application/pgp-signature, inline)]

Message #58 received at 23288 <at> debbugs.gnu.org (full text, mbox):

From: John Wiegley <jwiegley <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: Glenn Morris <rgm <at> gnu.org>, p.stephani2 <at> gmail.com, 23288 <at> debbugs.gnu.org,
 nilsb <at> google.com
Subject: Re: bug#23288: 25.0.92; Clicking on links inserts primary X selection
Date: Wed, 11 May 2016 22:42:21 -0700

>>>>> Eli Zaretskii <eliz <at> gnu.org> writes:

>> (See also merged #22434. Marked as release blocking for 3+ months.)

> Sorry, I don't see the list of blocking bugs being treated seriously. If we
> did treat it seriously, we wouldn't have had "deep freeze" on emacs-25, and
> wouldn't be planning the release in less than a month.

I'm not sure how those two things follow from not treating the blocking list
seriously, Eli. Can you please explain? As far as I understand it, others will
treat it as seriously as we do.

As it stands right now, I think many of the bugs on that list do not deserve
to be there, so it's a matter of priority setting.

-- 
John Wiegley                  GPG fingerprint = 4710 CF98 AF9B 327B B80F
http://newartisans.com                          60E1 46C4 BD1A 7AC1 4BA2

Message #61 received at 23288 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: John Wiegley <jwiegley <at> gmail.com>
Cc: rgm <at> gnu.org, p.stephani2 <at> gmail.com, 23288 <at> debbugs.gnu.org, nilsb <at> google.com
Subject: Re: bug#23288: 25.0.92; Clicking on links inserts primary X selection
Date: Thu, 12 May 2016 22:26:43 +0300

> From: John Wiegley <jwiegley <at> gmail.com>
> Cc: Glenn Morris <rgm <at> gnu.org>,  p.stephani2 <at> gmail.com,  23288 <at> debbugs.gnu.org,  nilsb <at> google.com
> Date: Wed, 11 May 2016 22:42:21 -0700
> 
> >>>>> Eli Zaretskii <eliz <at> gnu.org> writes:
> 
> >> (See also merged #22434. Marked as release blocking for 3+ months.)
> 
> > Sorry, I don't see the list of blocking bugs being treated seriously. If we
> > did treat it seriously, we wouldn't have had "deep freeze" on emacs-25, and
> > wouldn't be planning the release in less than a month.
> 
> I'm not sure how those two things follow from not treating the blocking list
> seriously, Eli. Can you please explain?

The long list of blocking bugs is simply incompatible with the current
release schedule.  And I don't see any intensive work to resolve those
bugs.

> As it stands right now, I think many of the bugs on that list do not deserve
> to be there, so it's a matter of priority setting.

Bugs that don't deserve being there should be removed from the list.
After that is done, we could again decide whether we can still release
as planned.

Message #64 received at 23288 <at> debbugs.gnu.org (full text, mbox):

From: John Wiegley <jwiegley <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: rgm <at> gnu.org, p.stephani2 <at> gmail.com, 23288 <at> debbugs.gnu.org, nilsb <at> google.com
Subject: Re: bug#23288: 25.0.92; Clicking on links inserts primary X selection
Date: Thu, 12 May 2016 14:24:16 -0700

>>>>> Eli Zaretskii <eliz <at> gnu.org> writes:

> Bugs that don't deserve being there should be removed from the list. After
> that is done, we could again decide whether we can still release as planned.

Agreed. Then consider the release date flexible until we've determined what
our real workload is.

-- 
John Wiegley                  GPG fingerprint = 4710 CF98 AF9B 327B B80F
http://newartisans.com                          60E1 46C4 BD1A 7AC1 4BA2

Message #67 received at 23288 <at> debbugs.gnu.org (full text, mbox):

From: Philipp Stephani <p.stephani2 <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 23288 <at> debbugs.gnu.org, nilsb <at> google.com
Subject: Re: bug#23288: 25.0.92; Clicking on links inserts primary X selection
Date: Fri, 20 May 2016 18:24:44 +0000

[Message part 1 (text/plain, inline)]

Eli Zaretskii <eliz <at> gnu.org> schrieb am Mi., 11. Mai 2016 um 10:14 Uhr:

> > From: Philipp Stephani <p.stephani2 <at> gmail.com>
> > Date: Tue, 10 May 2016 21:25:47 +0000
> > Cc: 23288 <at> debbugs.gnu.org
> >
> >  Agreed. https://debbugs.gnu.org/cgi/bugreport.cgi?bug=17887 might also
> be related.
> >
> > I've attached a new patch that should hopefully correct the behavior.
>
> Thanks.  If no one objects in a week, please push to the master
> branch.
>

Pushed to master (after moving  the test file).

[Message part 2 (text/html, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.