GNU bug report logs - #22893
25.1.50; dired-get-marked-files get all marked

Previous Next

Full log

Message #30 received at 22893 <at> debbugs.gnu.org (full text, mbox):

From: Tino Calancha <f92capac <at> gmail.com>
To: Juri Linkov <juri <at> linkov.net>
Cc: Tino Calancha <f92capac <at> gmail.com>, Eli Zaretskii <eliz <at> gnu.org>,
 22893 <at> debbugs.gnu.org, larsi <at> gnus.org
Subject: Re: bug#22893: 25.1.50; dired-get-marked-files get all marked
Date: Thu, 10 Mar 2016 13:19:10 +0900 (JST)

[Message part 1 (text/plain, inline)]

> Since you are changing the function signatures anyway,
> you could make them consistent between `dired-map-over-marks'
> and `dired-get-marked-files' by adding an explicit arg `marker-char',
> i.e. both `dired-get-marked-files' and `dired-map-over-marks'
> could end with "distinguish-one-marked marker-char all-marks",
> thus explicitly passing `marker-char' arg down the call chain.
> Then you'll need `(or marker-char dired-marker-char)' in
> `dired-marker-regexp' for backward-compatibility.  And then also
> no need to let-bind `dired-marker-char' in `dired-get-marked-files'
> (it's better to avoid dynamically binding global variables where possible).

It sounds good. Thank you. Implemented in the new patch.

[0001-Avoid-dynamic-global-var-binding.patch (text/plain, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.