GNU bug report logs - #22894
25.1.50; dired-mark: Not remark a marked file

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 22894 in the body.
You can then email your comments to 22894 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Tino Calancha <f92capac <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 25.1.50; dired-mark: Not remark a marked file
Date: Thu, 3 Mar 2016 19:09:39 +0900 (JST)

[Message part 1 (text/plain, inline)]

* lisp/dired.el (dired-mark-files-in-region,dired-mark):
A marked file can be remarked just:
1) To mark for deletion.
2) To unmark it, that is, the mark changes to `?\\s'.
3) If its marked for deletion, a different mark can be assigned.

The purpose of this changes is to prevent changing accidentally
the mark of a file. Current code allow to change marks on files very
easily.

Marking many files using several markers may need some time, with
some regexp gimnastics. Its a pity if someone accidentaly change
one of the marks. For instance, using `dired-mark-files-in-region',
the last/first file in the region could be included unintentionally
changing the mark of one file.


I'm not sure if allow 1) or to ban it.
I'm not sure if someone find this thread useful either :-)

In GNU Emacs 25.1.50.1 (x86_64-pc-linux-gnu, GTK+ Version 2.24.29)
 of 2016-03-03 built on calancha-pc
Repository revision: 887f6126c5ce9084f93083765ac026ca6b28175c

[dired_no_remark.patch (text/plain, attachment)]

Message #10 received at 22894 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Tino Calancha <f92capac <at> gmail.com>
Cc: 22894 <at> debbugs.gnu.org
Subject: Re: bug#22894: 25.1.50; dired-mark: Not remark a marked file
Date: Fri, 04 Mar 2016 12:31:21 +0000

Tino Calancha <f92capac <at> gmail.com> writes:

> Marking many files using several markers may need some time, with
> some regexp gimnastics. Its a pity if someone accidentaly change
> one of the marks. For instance, using `dired-mark-files-in-region',
> the last/first file in the region could be included unintentionally
> changing the mark of one file.
>
> I'm not sure if allow 1) or to ban it.
> I'm not sure if someone find this thread useful either :-)

You're right.  :-)  I think if the user tries to change the marks in a
region, then the marks in the region should be changed.  So I'm not sure
I understand the use case at all...

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #13 received at 22894 <at> debbugs.gnu.org (full text, mbox):

From: Tino Calancha <f92capac <at> gmail.com>
To: 22894 <at> debbugs.gnu.org
Subject: Re: bug#22894: 25.1.50; dired-mark: Not remark a marked file
Date: Sat, 5 Mar 2016 22:41:18 +0900 (JST)

> You're right.  :-)  I think if the user tries to change the marks in a
> region, then the marks in the region should be changed.  So I'm not sure
> I understand the use case at all...
User can change the marks with:
1) `dired-change-marks': this is, IMO, the recommended way: you control 
what you want to change, let's say, the mark 'F' into the mark 'G'.
2) Calling `dired-mark-files-regexp': the patch does't prevent this 
function changing mark 'F' into `dired-marker-char'.
3) Calling `dired-flag-file-deletion', that is, changing from mark 'F'
to 'D' (that is what i called before 1) in previous comunication).
4) In two steps: unmarking the file, and after that marking it.

What i am trying to prevent is related with `dired-mark' and 
`dired-mark-files-in-region'. The former is bound to 'm'. I can imagine
someone, keeping push the 'm' button to mark a bunch of files, and 
releasing such button one fraction of seocnd late, so one marked file with
'F' get remarked by `dired-marker-char'.
Similar thing could happen if using the second function setting the region 
not very carefully (pick uping one additional file up/down in the region).

The patch just prevent in this two function, one marked file be remarked. 
Those files still not marked are marked.

I am against to restrict users, and i understand this thread is 
controversial, but i use a lot these features and i believe it could
prevent people (including me) doing unintentional changes.

Message #16 received at 22894 <at> debbugs.gnu.org (full text, mbox):

From: Tino Calancha <f92capac <at> gmail.com>
To: 22894 <at> debbugs.gnu.org
Subject: Re: bug#22894: 25.1.50; dired-mark: Not remark a marked file
Date: Sat, 5 Mar 2016 23:06:32 +0900 (JST)

>i believe it could prevent people (including me) doing unintentional 
>changes.
I miss a point: certainly we could use 'dired-undo' so i lost my main
argument.
I still don't like `dired-mark' remarking but now becames a matter of 
taste, so i agree to keep the things as they are.

Message #19 received at 22894 <at> debbugs.gnu.org (full text, mbox):

From: Drew Adams <drew.adams <at> oracle.com>
To: Tino Calancha <f92capac <at> gmail.com>, 22894 <at> debbugs.gnu.org
Subject: RE: bug#22894: 25.1.50; dired-mark: Not remark a marked file
Date: Sat, 5 Mar 2016 10:59:06 -0800 (PST)

Hi Tino,

> What i am trying to prevent is related with `dired-mark' and
> `dired-mark-files-in-region'. The former is bound to 'm'. I can
> imagine someone, keeping push the 'm' button to mark a bunch of files,
> and releasing such button one fraction of seocnd late, so one marked
> file with 'F' get remarked by `dired-marker-char'.
> Similar thing could happen if using the second function setting the
> region not very carefully (pick uping one additional file up/down
> in the region).
> 
> The patch just prevent in this two function, one marked file be
> remarked. Those files still not marked are marked.

Doesn't sound like a great idea, to me.  At most it should be
optional behavior: a user choice.

Novice users, whom one could think might benefit most from this
protection, will not benefit from it, because they are not likely
to have changed marks.

(In my experience, very few people are even aware of the ability
to change marks, and this is true even of people who have been
developing and maintaining Emacs.)

> I am against to restrict users, and i understand this thread is
> controversial, but i use a lot these features and i believe it
> could prevent people (including me) doing unintentional changes.

But also intentional changes.  Users who know about and use the
ability to change marks should be able to mark over changed marks
with `*', including with `m' and using the region.

You say that you have been using this feature for a while and
appreciate it.  That is the best argument for it, I guess.

If this behavior is optional then it is OK, but I don't see a
great use case for it.  And you mention undo, which also argues
against this.

Message #22 received at 22894 <at> debbugs.gnu.org (full text, mbox):

From: npostavs <at> users.sourceforge.net
To: Tino Calancha <f92capac <at> gmail.com>
Cc: 22894 <at> debbugs.gnu.org
Subject: Re: bug#22894: 25.1.50; dired-mark: Not remark a marked file
Date: Thu, 30 Jun 2016 23:22:54 -0400

tags 22894 wontfix
close 22894
quit

Tino Calancha <f92capac <at> gmail.com> writes:

>> i believe it could prevent people (including me) doing unintentional
>> changes.
> I miss a point: certainly we could use 'dired-undo' so i lost my main
> argument.
> I still don't like `dired-mark' remarking but now becames a matter of
> taste, so i agree to keep the things as they are.

Hence closing.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.