GNU bug report logs - #22893
25.1.50; dired-get-marked-files get all marked

Previous Next

Full log

View this message in rfc822 format

From: Juri Linkov <juri <at> linkov.net>
To: Tino Calancha <f92capac <at> gmail.com>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 22893 <at> debbugs.gnu.org, larsi <at> gnus.org
Subject: bug#22893: 25.1.50; dired-get-marked-files get all marked
Date: Thu, 10 Mar 2016 01:57:17 +0200

merge 22893 22892
thanks

> +*** New optional arg ALL-MARKS for `dired-map-over-marks'
> +allow to operate over all marked files, not just those
> +marked with `dired-marker-char'.
> +
> +*** New optional args MARKER-CHAR and ALL-MARKS for
> +`dired-get-marked-files' to retrieve marked files with a
> +particular mark character or with any.

Since you are changing the function signatures anyway,
you could make them consistent between `dired-map-over-marks'
and `dired-get-marked-files' by adding an explicit arg `marker-char',
i.e. both `dired-get-marked-files' and `dired-map-over-marks'
could end with "distinguish-one-marked marker-char all-marks",
thus explicitly passing `marker-char' arg down the call chain.
Then you'll need `(or marker-char dired-marker-char)' in
`dired-marker-regexp' for backward-compatibility.  And then also
no need to let-bind `dired-marker-char' in `dired-get-marked-files'
(it's better to avoid dynamically binding global variables where possible).

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.