GNU bug report logs - #22686
An empty string marked for translation

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Pádraig Brady <P <at> draigBrady.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#22686: closed (An empty string marked for translation)
Date: Mon, 15 Feb 2016 21:11:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Mon, 15 Feb 2016 13:10:40 -0800
with message-id <56C23ED0.8090401 <at> draigBrady.com>
and subject line Re: bug#22686: An empty string marked for translation
has caused the debbugs.gnu.org bug report #22686,
regarding An empty string marked for translation
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
22686: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=22686
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Göran Uddeborg <goeran <at> uddeborg.se>
To: bug-coreutils <at> gnu.org
Subject: An empty string marked for translation
Date: Mon, 15 Feb 2016 20:10:52 +0100

On line 955 of src/stty.c there is an empty string marked for
translation.

	  fputs (_("\
    "), stdout);

This might actually be harmful.  Po files use the translation of the
empty string as a header.  So depending on the gettext implementation,
it might be replaced by a header which I'm sure isn't intended.
(Maybe GNU gettext guards against this, I haven't investigated.  But
even if so, it is still pretty pointless to mark it for translation.)

[Message part 3 (message/rfc822, inline)]

From: Pádraig Brady <P <at> draigBrady.com>
To: Göran Uddeborg <goeran <at> uddeborg.se>,
 22686-done <at> debbugs.gnu.org
Subject: Re: bug#22686: An empty string marked for translation
Date: Mon, 15 Feb 2016 13:10:40 -0800

On 15/02/16 11:10, Göran Uddeborg wrote:
> On line 955 of src/stty.c there is an empty string marked for
> translation.
> 
> 	  fputs (_("\
>     "), stdout);
> 
> This might actually be harmful.  Po files use the translation of the
> empty string as a header.  So depending on the gettext implementation,
> it might be replaced by a header which I'm sure isn't intended.
> (Maybe GNU gettext guards against this, I haven't investigated.  But
> even if so, it is still pretty pointless to mark it for translation.)

Ouch it does output the header when translating (so not for English).
I pushed the fix in your name:
http://git.sv.gnu.org/gitweb/?p=coreutils.git;a=commitdiff;h=v8.25-6-g222e830

thanks!
Pádraig.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.